[INFO] updating cached repository skade/mailbox-konstanz [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/skade/mailbox-konstanz [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/skade/mailbox-konstanz" "work/ex/clippy-test-run/sources/stable/gh/skade/mailbox-konstanz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/skade/mailbox-konstanz'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/skade/mailbox-konstanz" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skade/mailbox-konstanz"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skade/mailbox-konstanz'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 64541b0b572eb5d7bc47ee3cd9340d7fca74fd01 [INFO] sha for GitHub repo skade/mailbox-konstanz: 64541b0b572eb5d7bc47ee3cd9340d7fca74fd01 [INFO] validating manifest of skade/mailbox-konstanz on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skade/mailbox-konstanz on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skade/mailbox-konstanz [INFO] finished frobbing skade/mailbox-konstanz [INFO] frobbed toml for skade/mailbox-konstanz written to work/ex/clippy-test-run/sources/stable/gh/skade/mailbox-konstanz/Cargo.toml [INFO] started frobbing skade/mailbox-konstanz [INFO] finished frobbing skade/mailbox-konstanz [INFO] frobbed toml for skade/mailbox-konstanz written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skade/mailbox-konstanz/Cargo.toml [INFO] crate skade/mailbox-konstanz has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skade/mailbox-konstanz against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skade/mailbox-konstanz:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 616c58170e9f25846eb3687a7c341ea0c06204c72b032a9283fd01857062c7cc [INFO] running `"docker" "start" "-a" "616c58170e9f25846eb3687a7c341ea0c06204c72b032a9283fd01857062c7cc"` [INFO] [stderr] Checking mailbox v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | None => write!(stream, "No message in inbox!\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:59:17 [INFO] [stderr] | [INFO] [stderr] 59 | None => write!(stream, "No message in inbox!\n") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match data { [INFO] [stderr] 58 | | Some(message) => write!(stream, "{}", message), [INFO] [stderr] 59 | | None => write!(stream, "No message in inbox!\n") [INFO] [stderr] 60 | | }.ok().expect("Write failed!"); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | res.ok().expect("An error occured while reading!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match data { [INFO] [stderr] 58 | | Some(message) => write!(stream, "{}", message), [INFO] [stderr] 59 | | None => write!(stream, "No message in inbox!\n") [INFO] [stderr] 60 | | }.ok().expect("Write failed!"); [INFO] [stderr] | |__________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | res.ok().expect("An error occured while reading!"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "616c58170e9f25846eb3687a7c341ea0c06204c72b032a9283fd01857062c7cc"` [INFO] running `"docker" "rm" "-f" "616c58170e9f25846eb3687a7c341ea0c06204c72b032a9283fd01857062c7cc"` [INFO] [stdout] 616c58170e9f25846eb3687a7c341ea0c06204c72b032a9283fd01857062c7cc