[INFO] updating cached repository sjb3d/smallpt_rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sjb3d/smallpt_rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sjb3d/smallpt_rust" "work/ex/clippy-test-run/sources/stable/gh/sjb3d/smallpt_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sjb3d/smallpt_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sjb3d/smallpt_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjb3d/smallpt_rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjb3d/smallpt_rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 71db290a55e81903e3ea47df226dbfcc0b260948
[INFO] sha for GitHub repo sjb3d/smallpt_rust: 71db290a55e81903e3ea47df226dbfcc0b260948
[INFO] validating manifest of sjb3d/smallpt_rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sjb3d/smallpt_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sjb3d/smallpt_rust
[INFO] finished frobbing sjb3d/smallpt_rust
[INFO] frobbed toml for sjb3d/smallpt_rust written to work/ex/clippy-test-run/sources/stable/gh/sjb3d/smallpt_rust/Cargo.toml
[INFO] started frobbing sjb3d/smallpt_rust
[INFO] finished frobbing sjb3d/smallpt_rust
[INFO] frobbed toml for sjb3d/smallpt_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjb3d/smallpt_rust/Cargo.toml
[INFO] crate sjb3d/smallpt_rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sjb3d/smallpt_rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjb3d/smallpt_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 70463f6d6b64b4942bf6d497d7bc018a9484253dc785b302cd71ecbafa4251ca
[INFO] running `"docker" "start" "-a" "70463f6d6b64b4942bf6d497d7bc018a9484253dc785b302cd71ecbafa4251ca"`
[INFO] [stderr]     Checking smallpt_rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:226:7
[INFO] [stderr]     |
[INFO] [stderr] 226 |         let p = f.x.max(f.y).max(f.z); // max refl
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 let w = nl;
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:244:9
[INFO] [stderr]     |
[INFO] [stderr] 244 |                 let u = cross(if w.x.abs() > 0.1 { Vec3{ x: 0.0, y: 1.0, z: 0.0 } } else { Vec3{ x: 1.0, y: 0.0, z: 0.0 } }, w).norm();
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 let v = cross(w, u);
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:247:9
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 let d = (u*r1.cos()*r2s + v*r1.sin()*r2s + w*(1.0 - r2).sqrt()).norm();
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:270:10
[INFO] [stderr]     |
[INFO] [stderr] 270 |                     let a = nt - nc;
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:271:10
[INFO] [stderr]     |
[INFO] [stderr] 271 |                     let b = nt + nc;
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:273:10
[INFO] [stderr]     |
[INFO] [stderr] 273 |                     let c = 1.0 - if into { -ddn } else { dot(tdir, n) };
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:249:35
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 obj.e + f*radiance(Ray{ o: x, d: d }, depth, xi)
[INFO] [stderr]     |                                               ^^^^ help: replace it with: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:226:7
[INFO] [stderr]     |
[INFO] [stderr] 226 |         let p = f.x.max(f.y).max(f.z); // max refl
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:243:9
[INFO] [stderr]     |
[INFO] [stderr] 243 |                 let w = nl;
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:244:9
[INFO] [stderr]     |
[INFO] [stderr] 244 |                 let u = cross(if w.x.abs() > 0.1 { Vec3{ x: 0.0, y: 1.0, z: 0.0 } } else { Vec3{ x: 1.0, y: 0.0, z: 0.0 } }, w).norm();
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:245:9
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 let v = cross(w, u);
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:247:9
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 let d = (u*r1.cos()*r2s + v*r1.sin()*r2s + w*(1.0 - r2).sqrt()).norm();
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:270:10
[INFO] [stderr]     |
[INFO] [stderr] 270 |                     let a = nt - nc;
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:271:10
[INFO] [stderr]     |
[INFO] [stderr] 271 |                     let b = nt + nc;
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/main.rs:273:10
[INFO] [stderr]     |
[INFO] [stderr] 273 |                     let c = 1.0 - if into { -ddn } else { dot(tdir, n) };
[INFO] [stderr]     |                         ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/main.rs:249:35
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 obj.e + f*radiance(Ray{ o: x, d: d }, depth, xi)
[INFO] [stderr]     |                                               ^^^^ help: replace it with: `d`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:210:27
[INFO] [stderr]     |
[INFO] [stderr] 210 |     xi.s = xi.s.wrapping_mul(0x5deece66du64).wrapping_add(0xbu64) & 0xffffffffffffu64;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: consider: `0x0005_deec_e66du64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:210:66
[INFO] [stderr]     |
[INFO] [stderr] 210 |     xi.s = xi.s.wrapping_mul(0x5deece66du64).wrapping_add(0xbu64) & 0xffffffffffffu64;
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffffu64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:319:24
[INFO] [stderr]     |
[INFO] [stderr] 319 |         d: Vec3{ x: 0.0, y: -0.042612, z: -1.0 }.norm() };
[INFO] [stderr]     |                              ^^^^^^^^ help: consider: `0.042_612`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:210:27
[INFO] [stderr]     |
[INFO] [stderr] 210 |     xi.s = xi.s.wrapping_mul(0x5deece66du64).wrapping_add(0xbu64) & 0xffffffffffffu64;
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^ help: consider: `0x0005_deec_e66du64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:210:66
[INFO] [stderr]     |
[INFO] [stderr] 210 |     xi.s = xi.s.wrapping_mul(0x5deece66du64).wrapping_add(0xbu64) & 0xffffffffffffu64;
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffffu64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/main.rs:319:24
[INFO] [stderr]     |
[INFO] [stderr] 319 |         d: Vec3{ x: 0.0, y: -0.042612, z: -1.0 }.norm() };
[INFO] [stderr]     |                              ^^^^^^^^ help: consider: `0.042_612`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/main.rs:194:24
[INFO] [stderr]     |
[INFO] [stderr] 194 |     for (i, s) in SPHERES.into_iter().enumerate() {
[INFO] [stderr]     |                           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: requested on the command line with `-D clippy::into-iter-on-array`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:300:24
[INFO] [stderr]     |
[INFO] [stderr] 300 | fn write_output(image: &Image) -> Result<()> {
[INFO] [stderr]     |                        ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:350:19
[INFO] [stderr]     |
[INFO] [stderr] 350 |                                     + cx*(((((sx as F) + 0.5 + dx)/2.0) + (x as F))/(W as F) - 0.5)
[INFO] [stderr]     |                                              ^^^^^^^^^ help: try: `f64::from(sx)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:351:25
[INFO] [stderr]     |
[INFO] [stderr] 351 |                                     + cy*(0.5 - ((((sy as F) + 0.5 + dy)/2.0) + (y as F))/(H as F));
[INFO] [stderr]     |                                                    ^^^^^^^^^ help: try: `f64::from(sy)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `smallpt_rust`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array
[INFO] [stderr]    --> src/main.rs:194:24
[INFO] [stderr]     |
[INFO] [stderr] 194 |     for (i, s) in SPHERES.into_iter().enumerate() {
[INFO] [stderr]     |                           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: requested on the command line with `-D clippy::into-iter-on-array`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/main.rs:300:24
[INFO] [stderr]     |
[INFO] [stderr] 300 | fn write_output(image: &Image) -> Result<()> {
[INFO] [stderr]     |                        ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:350:19
[INFO] [stderr]     |
[INFO] [stderr] 350 |                                     + cx*(((((sx as F) + 0.5 + dx)/2.0) + (x as F))/(W as F) - 0.5)
[INFO] [stderr]     |                                              ^^^^^^^^^ help: try: `f64::from(sx)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:351:25
[INFO] [stderr]     |
[INFO] [stderr] 351 |                                     + cy*(0.5 - ((((sy as F) + 0.5 + dy)/2.0) + (y as F))/(H as F));
[INFO] [stderr]     |                                                    ^^^^^^^^^ help: try: `f64::from(sy)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `smallpt_rust`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "70463f6d6b64b4942bf6d497d7bc018a9484253dc785b302cd71ecbafa4251ca"`
[INFO] running `"docker" "rm" "-f" "70463f6d6b64b4942bf6d497d7bc018a9484253dc785b302cd71ecbafa4251ca"`
[INFO] [stdout] 70463f6d6b64b4942bf6d497d7bc018a9484253dc785b302cd71ecbafa4251ca