[INFO] updating cached repository sirkibsirkib/tsp_genetic_alg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sirkibsirkib/tsp_genetic_alg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/tsp_genetic_alg" "work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/tsp_genetic_alg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/tsp_genetic_alg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/tsp_genetic_alg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/tsp_genetic_alg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/tsp_genetic_alg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2bec582bcc0d34f50ec77ff16dcadec74267f4ae [INFO] sha for GitHub repo sirkibsirkib/tsp_genetic_alg: 2bec582bcc0d34f50ec77ff16dcadec74267f4ae [INFO] validating manifest of sirkibsirkib/tsp_genetic_alg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sirkibsirkib/tsp_genetic_alg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sirkibsirkib/tsp_genetic_alg [INFO] finished frobbing sirkibsirkib/tsp_genetic_alg [INFO] frobbed toml for sirkibsirkib/tsp_genetic_alg written to work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/tsp_genetic_alg/Cargo.toml [INFO] started frobbing sirkibsirkib/tsp_genetic_alg [INFO] finished frobbing sirkibsirkib/tsp_genetic_alg [INFO] frobbed toml for sirkibsirkib/tsp_genetic_alg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/tsp_genetic_alg/Cargo.toml [INFO] crate sirkibsirkib/tsp_genetic_alg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sirkibsirkib/tsp_genetic_alg against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/tsp_genetic_alg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7927bf82aaf9ec5d5d3c75bc3fd4ac41f634485e278cc86d5bbfad0bc4ef0c85 [INFO] running `"docker" "start" "-a" "7927bf82aaf9ec5d5d3c75bc3fd4ac41f634485e278cc86d5bbfad0bc4ef0c85"` [INFO] [stderr] Checking crossbeam v0.2.10 [INFO] [stderr] Checking bidir-map v0.6.0 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking num_cpus v1.7.0 [INFO] [stderr] Checking textwrap v0.8.0 [INFO] [stderr] Checking clap v2.26.2 [INFO] [stderr] Checking syncbox v0.2.4 [INFO] [stderr] Checking cue v0.1.0 [INFO] [stderr] Checking tsp_genetic_alg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tsp.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / write!( [INFO] [stderr] 89 | | &mut writer, [INFO] [stderr] 90 | | "{}\t|{}\t|{}\n", [INFO] [stderr] 91 | | city_map.get_by_first(cid_1).unwrap(), [INFO] [stderr] 92 | | city_map.get_by_first(cid_2).unwrap(), [INFO] [stderr] 93 | | dist_map.get(&(*cid_1, *cid_2)).unwrap(), [INFO] [stderr] 94 | | ).is_ok(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/tsp.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | / write!( [INFO] [stderr] 89 | | &mut writer, [INFO] [stderr] 90 | | "{}\t|{}\t|{}\n", [INFO] [stderr] 91 | | city_map.get_by_first(cid_1).unwrap(), [INFO] [stderr] 92 | | city_map.get_by_first(cid_2).unwrap(), [INFO] [stderr] 93 | | dist_map.get(&(*cid_1, *cid_2)).unwrap(), [INFO] [stderr] 94 | | ).is_ok(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/setup.rs:85:12 [INFO] [stderr] | [INFO] [stderr] 85 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 86 | | if config.in_path == "INVALID"{ [INFO] [stderr] 87 | | panic!("NO IN PATH GIVEN IN CONFIG FILE NOR INPUT"); [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | } else if config.in_path == "INVALID"{ [INFO] [stderr] 86 | panic!("NO IN PATH GIVEN IN CONFIG FILE NOR INPUT"); [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/setup.rs:85:12 [INFO] [stderr] | [INFO] [stderr] 85 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 86 | | if config.in_path == "INVALID"{ [INFO] [stderr] 87 | | panic!("NO IN PATH GIVEN IN CONFIG FILE NOR INPUT"); [INFO] [stderr] 88 | | } [INFO] [stderr] 89 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 85 | } else if config.in_path == "INVALID"{ [INFO] [stderr] 86 | panic!("NO IN PATH GIVEN IN CONFIG FILE NOR INPUT"); [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tsp.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | let res = Vec::from_iter(l.split("|").map(|x| String::from(x).trim().to_owned())); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tsp.rs:117:42 [INFO] [stderr] | [INFO] [stderr] 117 | let res = Vec::from_iter(l.split("|").map(|x| String::from(x).trim().to_owned())); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/setup.rs:45:46 [INFO] [stderr] | [INFO] [stderr] 45 | let res = Vec::from_iter(l.split(":").map(|x| String::from(x).trim().to_owned())); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | fn evolve(start : &Vec, mut r : R, distances : &DistMap, num_cities : u32, config : &setup::Config) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Creature]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tsp.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | let res = Vec::from_iter(l.split("|").map(|x| String::from(x).trim().to_owned())); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/tsp.rs:117:42 [INFO] [stderr] | [INFO] [stderr] 117 | let res = Vec::from_iter(l.split("|").map(|x| String::from(x).trim().to_owned())); [INFO] [stderr] | ^^^ help: try using a char instead: `'|'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/setup.rs:45:46 [INFO] [stderr] | [INFO] [stderr] 45 | let res = Vec::from_iter(l.split(":").map(|x| String::from(x).trim().to_owned())); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | fn evolve(start : &Vec, mut r : R, distances : &DistMap, num_cities : u32, config : &setup::Config) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Creature]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.71s [INFO] running `"docker" "inspect" "7927bf82aaf9ec5d5d3c75bc3fd4ac41f634485e278cc86d5bbfad0bc4ef0c85"` [INFO] running `"docker" "rm" "-f" "7927bf82aaf9ec5d5d3c75bc3fd4ac41f634485e278cc86d5bbfad0bc4ef0c85"` [INFO] [stdout] 7927bf82aaf9ec5d5d3c75bc3fd4ac41f634485e278cc86d5bbfad0bc4ef0c85