[INFO] updating cached repository sirkibsirkib/cardgame [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sirkibsirkib/cardgame [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/cardgame" "work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/cardgame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/cardgame'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/cardgame" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/cardgame"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/cardgame'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 09ad26188796f859f7e916f83c5d1cfb02eb6f3c [INFO] sha for GitHub repo sirkibsirkib/cardgame: 09ad26188796f859f7e916f83c5d1cfb02eb6f3c [INFO] validating manifest of sirkibsirkib/cardgame on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sirkibsirkib/cardgame on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sirkibsirkib/cardgame [INFO] finished frobbing sirkibsirkib/cardgame [INFO] frobbed toml for sirkibsirkib/cardgame written to work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/cardgame/Cargo.toml [INFO] started frobbing sirkibsirkib/cardgame [INFO] finished frobbing sirkibsirkib/cardgame [INFO] frobbed toml for sirkibsirkib/cardgame written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/cardgame/Cargo.toml [INFO] crate sirkibsirkib/cardgame has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sirkibsirkib/cardgame against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/cardgame:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8779a8e178b47e31b1d94e96e21edec84fa136765f63f9f8d34b35d85c0c949c [INFO] running `"docker" "start" "-a" "8779a8e178b47e31b1d94e96e21edec84fa136765f63f9f8d34b35d85c0c949c"` [INFO] [stderr] Checking cardgame v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | abilities: abilities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `abilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/screen.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:53:4 [INFO] [stderr] | [INFO] [stderr] 53 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/card.rs:54:4 [INFO] [stderr] | [INFO] [stderr] 54 | abilities: abilities, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `abilities` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/screen.rs:33:4 [INFO] [stderr] | [INFO] [stderr] 33 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/card.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `thread_rng` [INFO] [stderr] --> src/card.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use rand::{Rng, thread_rng}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Card` [INFO] [stderr] --> src/stack.rs:1:12 [INFO] [stderr] | [INFO] [stderr] 1 | use card::{Card, CardFlyweight}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `::card::Card` [INFO] [stderr] --> src/combat.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use ::card::Card; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `card::Database` [INFO] [stderr] --> src/screen.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use card::Database; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const abs: [&'static str; 4] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::rc::Rc` [INFO] [stderr] --> src/card.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::rc::Rc; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `thread_rng` [INFO] [stderr] --> src/card.rs:2:17 [INFO] [stderr] | [INFO] [stderr] 2 | use rand::{Rng, thread_rng}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Card` [INFO] [stderr] --> src/stack.rs:1:12 [INFO] [stderr] | [INFO] [stderr] 1 | use card::{Card, CardFlyweight}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `::card::Card` [INFO] [stderr] --> src/combat.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use ::card::Card; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `card::Database` [INFO] [stderr] --> src/screen.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use card::Database; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:17:14 [INFO] [stderr] | [INFO] [stderr] 17 | const abs: [&'static str; 4] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p1_stacks` [INFO] [stderr] --> src/combat.rs:5:10 [INFO] [stderr] | [INFO] [stderr] 5 | let mut p1_stacks: Vec = vec![]; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_p1_stacks` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p2_stacks` [INFO] [stderr] --> src/combat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | let mut p2_stacks: Vec = vec![]; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_p2_stacks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:48:6 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..5 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | x => { worked = false; }, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/screen.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | for j in 0..HEIGHT { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/screen.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..WIDTH { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/combat.rs:5:6 [INFO] [stderr] | [INFO] [stderr] 5 | let mut p1_stacks: Vec = vec![]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/combat.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | let mut p2_stacks: Vec = vec![]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p1_stacks` [INFO] [stderr] --> src/combat.rs:5:10 [INFO] [stderr] | [INFO] [stderr] 5 | let mut p1_stacks: Vec = vec![]; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_p1_stacks` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p2_stacks` [INFO] [stderr] --> src/combat.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | let mut p2_stacks: Vec = vec![]; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_p2_stacks` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/main.rs:48:6 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..5 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/main.rs:117:5 [INFO] [stderr] | [INFO] [stderr] 117 | x => { worked = false; }, [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] [INFO] [stderr] warning: method is never used: `visible` [INFO] [stderr] --> src/card.rs:84:2 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn visible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: unused variable: `j` [INFO] [stderr] --> src/screen.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | for j in 0..HEIGHT { [INFO] [stderr] | ^ help: consider using `_j` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/screen.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | for i in 0..WIDTH { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `CardType` [INFO] [stderr] --> src/card_type.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub enum CardType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `combat` [INFO] [stderr] --> src/combat.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn combat() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `coord` [INFO] [stderr] --> src/screen.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn coord(index: usize) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/combat.rs:5:6 [INFO] [stderr] | [INFO] [stderr] 5 | let mut p1_stacks: Vec = vec![]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/combat.rs:6:6 [INFO] [stderr] | [INFO] [stderr] 6 | let mut p2_stacks: Vec = vec![]; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: method is never used: `visible` [INFO] [stderr] --> src/card.rs:84:2 [INFO] [stderr] | [INFO] [stderr] 84 | pub fn visible(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `CardType` [INFO] [stderr] --> src/card_type.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub enum CardType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `combat` [INFO] [stderr] --> src/combat.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn combat() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `coord` [INFO] [stderr] --> src/screen.rs:43:2 [INFO] [stderr] | [INFO] [stderr] 43 | pub fn coord(index: usize) -> (usize, usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `abs` should have an upper case name such as `ABS` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / const abs: [&'static str; 4] = [ [INFO] [stderr] 18 | | "^:-,~", [INFO] [stderr] 19 | | "<:+", [INFO] [stderr] 20 | | "v:+", [INFO] [stderr] 21 | | ">:-,Ee-", [INFO] [stderr] 22 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | stdin().read_line(&mut s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | let parsed = s.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:85:6 [INFO] [stderr] | [INFO] [stderr] 85 | stacks[index].top_mut().map(|x| x.rot_cw(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.rot_cw(false) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:88:6 [INFO] [stderr] | [INFO] [stderr] 88 | stacks[index].top_mut().map(|x| x.rot_ccw(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.rot_ccw(false) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:91:6 [INFO] [stderr] | [INFO] [stderr] 91 | stacks[index].top_mut().map(|x| x.set_vis(true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.set_vis(true) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | stacks[index].top_mut().map(|x| x.set_vis(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.set_vis(false) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: constant `abs` should have an upper case name such as `ABS` [INFO] [stderr] --> src/main.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / const abs: [&'static str; 4] = [ [INFO] [stderr] 18 | | "^:-,~", [INFO] [stderr] 19 | | "<:+", [INFO] [stderr] 20 | | "v:+", [INFO] [stderr] 21 | | ">:-,Ee-", [INFO] [stderr] 22 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | stdin().read_line(&mut s); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:77:24 [INFO] [stderr] | [INFO] [stderr] 77 | let parsed = s.split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:85:6 [INFO] [stderr] | [INFO] [stderr] 85 | stacks[index].top_mut().map(|x| x.rot_cw(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.rot_cw(false) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:88:6 [INFO] [stderr] | [INFO] [stderr] 88 | stacks[index].top_mut().map(|x| x.rot_ccw(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.rot_ccw(false) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:91:6 [INFO] [stderr] | [INFO] [stderr] 91 | stacks[index].top_mut().map(|x| x.set_vis(true)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.set_vis(true) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/main.rs:95:6 [INFO] [stderr] | [INFO] [stderr] 95 | stacks[index].top_mut().map(|x| x.set_vis(false)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(x) = stacks[index].top_mut() { x.set_vis(false) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "8779a8e178b47e31b1d94e96e21edec84fa136765f63f9f8d34b35d85c0c949c"` [INFO] running `"docker" "rm" "-f" "8779a8e178b47e31b1d94e96e21edec84fa136765f63f9f8d34b35d85c0c949c"` [INFO] [stdout] 8779a8e178b47e31b1d94e96e21edec84fa136765f63f9f8d34b35d85c0c949c