[INFO] updating cached repository simmons/mpsc-stress [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simmons/mpsc-stress [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simmons/mpsc-stress" "work/ex/clippy-test-run/sources/stable/gh/simmons/mpsc-stress"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simmons/mpsc-stress'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simmons/mpsc-stress" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmons/mpsc-stress"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmons/mpsc-stress'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 673090edfbfd53fee1ba54a111bf550a71dd04e0 [INFO] sha for GitHub repo simmons/mpsc-stress: 673090edfbfd53fee1ba54a111bf550a71dd04e0 [INFO] validating manifest of simmons/mpsc-stress on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simmons/mpsc-stress on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simmons/mpsc-stress [INFO] finished frobbing simmons/mpsc-stress [INFO] frobbed toml for simmons/mpsc-stress written to work/ex/clippy-test-run/sources/stable/gh/simmons/mpsc-stress/Cargo.toml [INFO] started frobbing simmons/mpsc-stress [INFO] finished frobbing simmons/mpsc-stress [INFO] frobbed toml for simmons/mpsc-stress written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmons/mpsc-stress/Cargo.toml [INFO] crate simmons/mpsc-stress has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simmons/mpsc-stress against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmons/mpsc-stress:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4741d26b70f14043e6dd404dc860cdede2260bb6d23a3598459f9f5b3bfe8f85 [INFO] running `"docker" "start" "-a" "4741d26b70f14043e6dd404dc860cdede2260bb6d23a3598459f9f5b3bfe8f85"` [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Checking bytes v0.4.9 [INFO] [stderr] Checking crossbeam-epoch v0.4.3 [INFO] [stderr] Checking tokio-timer v0.2.4 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Checking crossbeam-deque v0.3.1 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking tokio-threadpool v0.1.5 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking mpsc-stress v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | const ITERATION_COUNT: usize = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | cmd_tx [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | let cmd_tx = rx.wait().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | const ITERATION_COUNT: usize = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | cmd_tx [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:112:18 [INFO] [stderr] | [INFO] [stderr] 112 | let cmd_tx = rx.wait().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.29s [INFO] running `"docker" "inspect" "4741d26b70f14043e6dd404dc860cdede2260bb6d23a3598459f9f5b3bfe8f85"` [INFO] running `"docker" "rm" "-f" "4741d26b70f14043e6dd404dc860cdede2260bb6d23a3598459f9f5b3bfe8f85"` [INFO] [stdout] 4741d26b70f14043e6dd404dc860cdede2260bb6d23a3598459f9f5b3bfe8f85