[INFO] updating cached repository sierisimo/algorith-mx-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sierisimo/algorith-mx-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sierisimo/algorith-mx-rust" "work/ex/clippy-test-run/sources/stable/gh/sierisimo/algorith-mx-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sierisimo/algorith-mx-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sierisimo/algorith-mx-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sierisimo/algorith-mx-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sierisimo/algorith-mx-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c4a8a431f68c65eb9e9d50ab3a00a451fbf973f2 [INFO] sha for GitHub repo sierisimo/algorith-mx-rust: c4a8a431f68c65eb9e9d50ab3a00a451fbf973f2 [INFO] validating manifest of sierisimo/algorith-mx-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sierisimo/algorith-mx-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sierisimo/algorith-mx-rust [INFO] finished frobbing sierisimo/algorith-mx-rust [INFO] frobbed toml for sierisimo/algorith-mx-rust written to work/ex/clippy-test-run/sources/stable/gh/sierisimo/algorith-mx-rust/Cargo.toml [INFO] started frobbing sierisimo/algorith-mx-rust [INFO] finished frobbing sierisimo/algorith-mx-rust [INFO] frobbed toml for sierisimo/algorith-mx-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sierisimo/algorith-mx-rust/Cargo.toml [INFO] crate sierisimo/algorith-mx-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sierisimo/algorith-mx-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sierisimo/algorith-mx-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6b8c5ca752a897aed72aaf809eb9ba3cc014e874ae1eaef24c9ffa0ad98fa33 [INFO] running `"docker" "start" "-a" "f6b8c5ca752a897aed72aaf809eb9ba3cc014e874ae1eaef24c9ffa0ad98fa33"` [INFO] [stderr] Checking algorith-mx v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/main.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | while(idx_start != idx_end){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/main.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | while(idx_start != idx_end){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `numberToSearch` [INFO] [stderr] --> src/main.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_numberToSearch` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let mut idx_start = 0; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut idx_end = arrayOfInts.len(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function `bigO` should have a snake case name such as `big_o` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] 10 | | let mut idx_start = 0; [INFO] [stderr] 11 | | let mut idx_end = arrayOfInts.len(); [INFO] [stderr] 12 | | [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `arrayOfInts` should have a snake case name such as `array_of_ints` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `numberToSearch` should have a snake case name such as `number_to_search` [INFO] [stderr] --> src/main.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | while(idx_start != idx_end){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: unused variable: `numberToSearch` [INFO] [stderr] --> src/main.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_numberToSearch` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: Could not compile `algorith-mx`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | let mut idx_start = 0; [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | let mut idx_end = arrayOfInts.len(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function `bigO` should have a snake case name such as `big_o` [INFO] [stderr] --> src/main.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] 10 | | let mut idx_start = 0; [INFO] [stderr] 11 | | let mut idx_end = arrayOfInts.len(); [INFO] [stderr] 12 | | [INFO] [stderr] ... | [INFO] [stderr] 15 | | } [INFO] [stderr] 16 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `arrayOfInts` should have a snake case name such as `array_of_ints` [INFO] [stderr] --> src/main.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `numberToSearch` should have a snake case name such as `number_to_search` [INFO] [stderr] --> src/main.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | fn bigO(arrayOfInts: Vec, numberToSearch: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:13:10 [INFO] [stderr] | [INFO] [stderr] 13 | while(idx_start != idx_end){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `algorith-mx`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f6b8c5ca752a897aed72aaf809eb9ba3cc014e874ae1eaef24c9ffa0ad98fa33"` [INFO] running `"docker" "rm" "-f" "f6b8c5ca752a897aed72aaf809eb9ba3cc014e874ae1eaef24c9ffa0ad98fa33"` [INFO] [stdout] f6b8c5ca752a897aed72aaf809eb9ba3cc014e874ae1eaef24c9ffa0ad98fa33