[INFO] updating cached repository shterrett/rust-lru-cache [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shterrett/rust-lru-cache [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shterrett/rust-lru-cache" "work/ex/clippy-test-run/sources/stable/gh/shterrett/rust-lru-cache"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shterrett/rust-lru-cache'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shterrett/rust-lru-cache" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-lru-cache"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-lru-cache'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce2654d9d3c249dd8b55b6bfe96b56e5b0cfb8ec [INFO] sha for GitHub repo shterrett/rust-lru-cache: ce2654d9d3c249dd8b55b6bfe96b56e5b0cfb8ec [INFO] validating manifest of shterrett/rust-lru-cache on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shterrett/rust-lru-cache on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shterrett/rust-lru-cache [INFO] finished frobbing shterrett/rust-lru-cache [INFO] frobbed toml for shterrett/rust-lru-cache written to work/ex/clippy-test-run/sources/stable/gh/shterrett/rust-lru-cache/Cargo.toml [INFO] started frobbing shterrett/rust-lru-cache [INFO] finished frobbing shterrett/rust-lru-cache [INFO] frobbed toml for shterrett/rust-lru-cache written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-lru-cache/Cargo.toml [INFO] crate shterrett/rust-lru-cache has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shterrett/rust-lru-cache against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-lru-cache:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 418ac285767c251eff86d63e2c57dbd2dec6c919b29d09ac0edde452762bd22d [INFO] running `"docker" "start" "-a" "418ac285767c251eff86d63e2c57dbd2dec6c919b29d09ac0edde452762bd22d"` [INFO] [stderr] Checking lru-cache v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/list.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | elem: elem, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `elem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cache.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | let ref e_key = evict.borrow().elem; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let e_key = &evict.borrow().elem;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cache.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | self.cache.remove(&e_key).map(|v| self.size -= v.iter().len() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.cache.remove(&e_key) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cache.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | let old_value = self.cache.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.cache[&key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cache.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | self.size = self.size - (old_value.iter().len() + value.iter().len()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.size -= (old_value.iter().len() + value.iter().len()) as u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/cache.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | let ref e_key = evict.borrow().elem; [INFO] [stderr] | ----^^^^^^^^^----------------------- help: try: `let e_key = &evict.borrow().elem;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/cache.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | self.cache.remove(&e_key).map(|v| self.size -= v.iter().len() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = self.cache.remove(&e_key) { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cache.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | let old_value = self.cache.get(&key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.cache[&key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cache.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | self.size = self.size - (old_value.iter().len() + value.iter().len()) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.size -= (old_value.iter().len() + value.iter().len()) as u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.33s [INFO] running `"docker" "inspect" "418ac285767c251eff86d63e2c57dbd2dec6c919b29d09ac0edde452762bd22d"` [INFO] running `"docker" "rm" "-f" "418ac285767c251eff86d63e2c57dbd2dec6c919b29d09ac0edde452762bd22d"` [INFO] [stdout] 418ac285767c251eff86d63e2c57dbd2dec6c919b29d09ac0edde452762bd22d