[INFO] updating cached repository shterrett/rust-concurrency-tutorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shterrett/rust-concurrency-tutorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shterrett/rust-concurrency-tutorial" "work/ex/clippy-test-run/sources/stable/gh/shterrett/rust-concurrency-tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shterrett/rust-concurrency-tutorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shterrett/rust-concurrency-tutorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-concurrency-tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-concurrency-tutorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d01f54064f6d679bbccd8da7a98835b5b216243 [INFO] sha for GitHub repo shterrett/rust-concurrency-tutorial: 6d01f54064f6d679bbccd8da7a98835b5b216243 [INFO] validating manifest of shterrett/rust-concurrency-tutorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shterrett/rust-concurrency-tutorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shterrett/rust-concurrency-tutorial [INFO] finished frobbing shterrett/rust-concurrency-tutorial [INFO] frobbed toml for shterrett/rust-concurrency-tutorial written to work/ex/clippy-test-run/sources/stable/gh/shterrett/rust-concurrency-tutorial/Cargo.toml [INFO] started frobbing shterrett/rust-concurrency-tutorial [INFO] finished frobbing shterrett/rust-concurrency-tutorial [INFO] frobbed toml for shterrett/rust-concurrency-tutorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-concurrency-tutorial/Cargo.toml [INFO] crate shterrett/rust-concurrency-tutorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shterrett/rust-concurrency-tutorial against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shterrett/rust-concurrency-tutorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a455d9246630c9f8269fc6dff604140e162c9ffee127e4c0617ff7645bd71fc1 [INFO] running `"docker" "start" "-a" "a455d9246630c9f8269fc6dff604140e162c9ffee127e4c0617ff7645bd71fc1"` [INFO] [stderr] Checking chan v0.1.19 [INFO] [stderr] Checking rust-concurrency-tutorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | let mut store = Store::new(format!("R-mart")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"R-mart".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | store.add_item(format!("chocolate"), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | store.add_item(format!("doll"), 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | store.add_item(format!("bike"), 150.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | let mut store = Store::new(format!("Bullseye")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bullseye".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | store.add_item(format!("chocolate"), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | store.add_item(format!("doll"), 23.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | store.add_item(format!("bike"), 145.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | let mut store = Store::new(format!("Woolmart")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Woolmart".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | store.add_item(format!("chocolate"), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | store.add_item(format!("doll"), 23.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | store.add_item(format!("bike"), 146.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:92:39 [INFO] [stderr] | [INFO] [stderr] 92 | let shopping_list = Arc::new(vec![format!("chocolate"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:93:39 [INFO] [stderr] | [INFO] [stderr] 93 | format!("doll"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:94:39 [INFO] [stderr] | [INFO] [stderr] 94 | format!("bike")]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:35:32 [INFO] [stderr] | [INFO] [stderr] 35 | let mut store = Store::new(format!("R-mart")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"R-mart".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:36:20 [INFO] [stderr] | [INFO] [stderr] 36 | store.add_item(format!("chocolate"), 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:37:20 [INFO] [stderr] | [INFO] [stderr] 37 | store.add_item(format!("doll"), 22.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | store.add_item(format!("bike"), 150.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:41:32 [INFO] [stderr] | [INFO] [stderr] 41 | let mut store = Store::new(format!("Bullseye")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Bullseye".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:42:20 [INFO] [stderr] | [INFO] [stderr] 42 | store.add_item(format!("chocolate"), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | store.add_item(format!("doll"), 23.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | store.add_item(format!("bike"), 145.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:47:32 [INFO] [stderr] | [INFO] [stderr] 47 | let mut store = Store::new(format!("Woolmart")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Woolmart".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | store.add_item(format!("chocolate"), 2.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | store.add_item(format!("doll"), 23.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:50:20 [INFO] [stderr] | [INFO] [stderr] 50 | store.add_item(format!("bike"), 146.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:92:39 [INFO] [stderr] | [INFO] [stderr] 92 | let shopping_list = Arc::new(vec![format!("chocolate"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"chocolate".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:93:39 [INFO] [stderr] | [INFO] [stderr] 93 | format!("doll"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"doll".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:94:39 [INFO] [stderr] | [INFO] [stderr] 94 | format!("bike")]); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bike".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.74s [INFO] running `"docker" "inspect" "a455d9246630c9f8269fc6dff604140e162c9ffee127e4c0617ff7645bd71fc1"` [INFO] running `"docker" "rm" "-f" "a455d9246630c9f8269fc6dff604140e162c9ffee127e4c0617ff7645bd71fc1"` [INFO] [stdout] a455d9246630c9f8269fc6dff604140e162c9ffee127e4c0617ff7645bd71fc1