[INFO] updating cached repository shinkwhek/Tapir [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shinkwhek/Tapir [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shinkwhek/Tapir" "work/ex/clippy-test-run/sources/stable/gh/shinkwhek/Tapir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shinkwhek/Tapir'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shinkwhek/Tapir" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shinkwhek/Tapir"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shinkwhek/Tapir'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e2bea30cf34a8046fe4ff16d888fd8214f490a43 [INFO] sha for GitHub repo shinkwhek/Tapir: e2bea30cf34a8046fe4ff16d888fd8214f490a43 [INFO] validating manifest of shinkwhek/Tapir on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shinkwhek/Tapir on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shinkwhek/Tapir [INFO] finished frobbing shinkwhek/Tapir [INFO] frobbed toml for shinkwhek/Tapir written to work/ex/clippy-test-run/sources/stable/gh/shinkwhek/Tapir/Cargo.toml [INFO] started frobbing shinkwhek/Tapir [INFO] finished frobbing shinkwhek/Tapir [INFO] frobbed toml for shinkwhek/Tapir written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shinkwhek/Tapir/Cargo.toml [INFO] crate shinkwhek/Tapir has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shinkwhek/Tapir against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shinkwhek/Tapir:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47d88cae498f8fdd713f4e0431da8f6c98a34a4c20ef737c6b1dcf9a8d595fc8 [INFO] running `"docker" "start" "-a" "47d88cae498f8fdd713f4e0431da8f6c98a34a4c20ef737c6b1dcf9a8d595fc8"` [INFO] [stderr] Checking tapir v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Err(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return Ok(Stmt::LetVar(Box::new(id), Box::new(typ), None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Stmt::LetVar(Box::new(id), Box::new(typ), None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / return Ok(Stmt::LetVar( [INFO] [stderr] 75 | | Box::new(id), [INFO] [stderr] 76 | | Box::new(typ), [INFO] [stderr] 77 | | Some(Box::new(exp)), [INFO] [stderr] 78 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | Ok(Stmt::LetVar( [INFO] [stderr] 75 | Box::new(id), [INFO] [stderr] 76 | Box::new(typ), [INFO] [stderr] 77 | Some(Box::new(exp)), [INFO] [stderr] 78 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / return Ok(Expr::If( [INFO] [stderr] 124 | | Box::new(_cond), [INFO] [stderr] 125 | | Box::new(_then), [INFO] [stderr] 126 | | Some(Box::new(_else)), [INFO] [stderr] 127 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | Ok(Expr::If( [INFO] [stderr] 124 | Box::new(_cond), [INFO] [stderr] 125 | Box::new(_then), [INFO] [stderr] 126 | Some(Box::new(_else)), [INFO] [stderr] 127 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Err(()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | return Ok(Stmt::LetVar(Box::new(id), Box::new(typ), None)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Stmt::LetVar(Box::new(id), Box::new(typ), None))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / return Ok(Stmt::LetVar( [INFO] [stderr] 75 | | Box::new(id), [INFO] [stderr] 76 | | Box::new(typ), [INFO] [stderr] 77 | | Some(Box::new(exp)), [INFO] [stderr] 78 | | )); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 74 | Ok(Stmt::LetVar( [INFO] [stderr] 75 | Box::new(id), [INFO] [stderr] 76 | Box::new(typ), [INFO] [stderr] 77 | Some(Box::new(exp)), [INFO] [stderr] 78 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | / return Ok(Expr::If( [INFO] [stderr] 124 | | Box::new(_cond), [INFO] [stderr] 125 | | Box::new(_then), [INFO] [stderr] 126 | | Some(Box::new(_else)), [INFO] [stderr] 127 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 123 | Ok(Expr::If( [INFO] [stderr] 124 | Box::new(_cond), [INFO] [stderr] 125 | Box::new(_then), [INFO] [stderr] 126 | Some(Box::new(_else)), [INFO] [stderr] 127 | )) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lexer.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 16 | | self.read_token() [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | fn is_symbol(&mut self, t: &Token, sym: Symbol) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:169:19 [INFO] [stderr] | [INFO] [stderr] 169 | fn is_keyword(&mut self, t: &Token, ky: Keyword) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lexer.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn next(&mut self) -> Result { [INFO] [stderr] 16 | | self.read_token() [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | fn is_symbol(&mut self, t: &Token, sym: Symbol) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/parser.rs:169:19 [INFO] [stderr] | [INFO] [stderr] 169 | fn is_keyword(&mut self, t: &Token, ky: Keyword) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.36s [INFO] running `"docker" "inspect" "47d88cae498f8fdd713f4e0431da8f6c98a34a4c20ef737c6b1dcf9a8d595fc8"` [INFO] running `"docker" "rm" "-f" "47d88cae498f8fdd713f4e0431da8f6c98a34a4c20ef737c6b1dcf9a8d595fc8"` [INFO] [stdout] 47d88cae498f8fdd713f4e0431da8f6c98a34a4c20ef737c6b1dcf9a8d595fc8