[INFO] updating cached repository shepmaster/avr-intel-hex-tool [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shepmaster/avr-intel-hex-tool [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shepmaster/avr-intel-hex-tool" "work/ex/clippy-test-run/sources/stable/gh/shepmaster/avr-intel-hex-tool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shepmaster/avr-intel-hex-tool'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shepmaster/avr-intel-hex-tool" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shepmaster/avr-intel-hex-tool"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shepmaster/avr-intel-hex-tool'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b01308239de49926c1323e7542c14d0692e0cedb [INFO] sha for GitHub repo shepmaster/avr-intel-hex-tool: b01308239de49926c1323e7542c14d0692e0cedb [INFO] validating manifest of shepmaster/avr-intel-hex-tool on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shepmaster/avr-intel-hex-tool on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shepmaster/avr-intel-hex-tool [INFO] finished frobbing shepmaster/avr-intel-hex-tool [INFO] frobbed toml for shepmaster/avr-intel-hex-tool written to work/ex/clippy-test-run/sources/stable/gh/shepmaster/avr-intel-hex-tool/Cargo.toml [INFO] started frobbing shepmaster/avr-intel-hex-tool [INFO] finished frobbing shepmaster/avr-intel-hex-tool [INFO] frobbed toml for shepmaster/avr-intel-hex-tool written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shepmaster/avr-intel-hex-tool/Cargo.toml [INFO] crate shepmaster/avr-intel-hex-tool has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shepmaster/avr-intel-hex-tool against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shepmaster/avr-intel-hex-tool:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77beb75a33b030c953337a43fe2c61cc68fafe107d88c5d92254e3791752565f [INFO] running `"docker" "start" "-a" "77beb75a33b030c953337a43fe2c61cc68fafe107d88c5d92254e3791752565f"` [INFO] [stderr] Checking avr-intel-hex-tool v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | 0x00 => Data { address: address, data: data.into() }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:66:28 [INFO] [stderr] | [INFO] [stderr] 66 | 0x00 => Data { address: address, data: data.into() }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `address` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | if ! s.starts_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let address = (raw_data[1] as u16) << 8 | raw_data[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_data[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:51 [INFO] [stderr] | [INFO] [stderr] 57 | let address = (raw_data[1] as u16) << 8 | raw_data[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:32:28 [INFO] [stderr] | [INFO] [stderr] 32 | if ! s.starts_with(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | let address = (raw_data[1] as u16) << 8 | raw_data[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_data[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:57:51 [INFO] [stderr] | [INFO] [stderr] 57 | let address = (raw_data[1] as u16) << 8 | raw_data[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(raw_data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `"docker" "inspect" "77beb75a33b030c953337a43fe2c61cc68fafe107d88c5d92254e3791752565f"` [INFO] running `"docker" "rm" "-f" "77beb75a33b030c953337a43fe2c61cc68fafe107d88c5d92254e3791752565f"` [INFO] [stdout] 77beb75a33b030c953337a43fe2c61cc68fafe107d88c5d92254e3791752565f