[INFO] updating cached repository sharafian/texlite [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sharafian/texlite [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sharafian/texlite" "work/ex/clippy-test-run/sources/stable/gh/sharafian/texlite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sharafian/texlite'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sharafian/texlite" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharafian/texlite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharafian/texlite'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4c5f7fb000ee004f4add64eb38409736dd2ff186 [INFO] sha for GitHub repo sharafian/texlite: 4c5f7fb000ee004f4add64eb38409736dd2ff186 [INFO] validating manifest of sharafian/texlite on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sharafian/texlite on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sharafian/texlite [INFO] finished frobbing sharafian/texlite [INFO] frobbed toml for sharafian/texlite written to work/ex/clippy-test-run/sources/stable/gh/sharafian/texlite/Cargo.toml [INFO] started frobbing sharafian/texlite [INFO] finished frobbing sharafian/texlite [INFO] frobbed toml for sharafian/texlite written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharafian/texlite/Cargo.toml [INFO] crate sharafian/texlite has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sharafian/texlite against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharafian/texlite:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fab5a056c18a06f30693c66382e6e236ce76b0dc25299f9dfc7add6a16f776ea [INFO] running `"docker" "start" "-a" "fab5a056c18a06f30693c66382e6e236ce76b0dc25299f9dfc7add6a16f776ea"` [INFO] [stderr] Checking texlite v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tokenizer.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | fn flush_token (tokens: &mut Vec, token_buf: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokenizer.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | if token_buf.len() == 0 { return } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `token_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/tokenizer.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | let s: String = token_buf.into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tokenizer.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn tokenize (text: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | newlines = newlines + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `newlines += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unparser.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | let internal = match ast { [INFO] [stderr] | __________________^ [INFO] [stderr] 5 | | &AST::Block(ref x) => x, [INFO] [stderr] 6 | | _ => panic!("that's not a block!") [INFO] [stderr] 7 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 4 | let internal = match *ast { [INFO] [stderr] 5 | AST::Block(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unparser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match a { [INFO] [stderr] 11 | | &AST::Word(ref w) => s.push_str(w.as_str()), [INFO] [stderr] 12 | | &AST::Command(ref cmd, ref inner_ast) => unparse_command(s, cmd, inner_ast), [INFO] [stderr] 13 | | _ => panic!("what's this!") [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | match *a { [INFO] [stderr] 11 | AST::Word(ref w) => s.push_str(w.as_str()), [INFO] [stderr] 12 | AST::Command(ref cmd, ref inner_ast) => unparse_command(s, cmd, inner_ast), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/unparser.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | fn unparse_command (s: &mut String, cmd: &String, ast: &AST) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/unparser.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn unparse (block_list: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[AST]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / match &tokens[0] { [INFO] [stderr] 69 | | &Token::EOF => break, [INFO] [stderr] 70 | | &Token::Paragraph => eat(tokens, Token::Paragraph), [INFO] [stderr] 71 | | _ => panic!("expected paragraph break or EOF") [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tokenizer.rs:11:53 [INFO] [stderr] | [INFO] [stderr] 11 | fn flush_token (tokens: &mut Vec, token_buf: &Vec) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tokenizer.rs:12:6 [INFO] [stderr] | [INFO] [stderr] 12 | if token_buf.len() == 0 { return } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `token_buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/tokenizer.rs:14:29 [INFO] [stderr] | [INFO] [stderr] 14 | let s: String = token_buf.into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/tokenizer.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn tokenize (text: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tokenizer.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | newlines = newlines + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `newlines += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unparser.rs:4:18 [INFO] [stderr] | [INFO] [stderr] 4 | let internal = match ast { [INFO] [stderr] | __________________^ [INFO] [stderr] 5 | | &AST::Block(ref x) => x, [INFO] [stderr] 6 | | _ => panic!("that's not a block!") [INFO] [stderr] 7 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 4 | let internal = match *ast { [INFO] [stderr] 5 | AST::Block(ref x) => x, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/unparser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / match a { [INFO] [stderr] 11 | | &AST::Word(ref w) => s.push_str(w.as_str()), [INFO] [stderr] 12 | | &AST::Command(ref cmd, ref inner_ast) => unparse_command(s, cmd, inner_ast), [INFO] [stderr] 13 | | _ => panic!("what's this!") [INFO] [stderr] 14 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 10 | match *a { [INFO] [stderr] 11 | AST::Word(ref w) => s.push_str(w.as_str()), [INFO] [stderr] 12 | AST::Command(ref cmd, ref inner_ast) => unparse_command(s, cmd, inner_ast), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/unparser.rs:20:42 [INFO] [stderr] | [INFO] [stderr] 20 | fn unparse_command (s: &mut String, cmd: &String, ast: &AST) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | match tokens[0] { [INFO] [stderr] 69 | Token::EOF => break, [INFO] [stderr] 70 | Token::Paragraph => eat(tokens, Token::Paragraph), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/unparser.rs:26:29 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn unparse (block_list: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[AST]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / match &tokens[0] { [INFO] [stderr] 69 | | &Token::EOF => break, [INFO] [stderr] 70 | | &Token::Paragraph => eat(tokens, Token::Paragraph), [INFO] [stderr] 71 | | _ => panic!("expected paragraph break or EOF") [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 68 | match tokens[0] { [INFO] [stderr] 69 | Token::EOF => break, [INFO] [stderr] 70 | Token::Paragraph => eat(tokens, Token::Paragraph), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.67s [INFO] running `"docker" "inspect" "fab5a056c18a06f30693c66382e6e236ce76b0dc25299f9dfc7add6a16f776ea"` [INFO] running `"docker" "rm" "-f" "fab5a056c18a06f30693c66382e6e236ce76b0dc25299f9dfc7add6a16f776ea"` [INFO] [stdout] fab5a056c18a06f30693c66382e6e236ce76b0dc25299f9dfc7add6a16f776ea