[INFO] updating cached repository seritools/seri-nes [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seritools/seri-nes [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seritools/seri-nes" "work/ex/clippy-test-run/sources/stable/gh/seritools/seri-nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seritools/seri-nes'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seritools/seri-nes" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/seri-nes"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/seri-nes'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d70b5e1266facc8c36b5f0434e9c12235768f806 [INFO] sha for GitHub repo seritools/seri-nes: d70b5e1266facc8c36b5f0434e9c12235768f806 [INFO] validating manifest of seritools/seri-nes on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seritools/seri-nes on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seritools/seri-nes [INFO] finished frobbing seritools/seri-nes [INFO] frobbed toml for seritools/seri-nes written to work/ex/clippy-test-run/sources/stable/gh/seritools/seri-nes/Cargo.toml [INFO] started frobbing seritools/seri-nes [INFO] finished frobbing seritools/seri-nes [INFO] frobbed toml for seritools/seri-nes written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/seri-nes/Cargo.toml [INFO] crate seritools/seri-nes has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seritools/seri-nes against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/seri-nes:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05aa4e3fffa1e78b5b47c78142babf67b62542bc9cd5360b911ab8c76bb57975 [INFO] running `"docker" "start" "-a" "05aa4e3fffa1e78b5b47c78142babf67b62542bc9cd5360b911ab8c76bb57975"` [INFO] [stderr] Checking seri-nes v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes_system/cartridge.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | Nrom { definition: definition } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `definition` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes_system/memory.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes_system/nesfile.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | mapper_type: mapper_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mapper_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes_system/cartridge.rs:23:16 [INFO] [stderr] | [INFO] [stderr] 23 | Nrom { definition: definition } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `definition` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes_system/memory.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | cartridge: cartridge, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cartridge` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/nes_system/nesfile.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | mapper_type: mapper_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mapper_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nes_system/cpu.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | self.cycles += CYCLE_TABLE[opcode as usize] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CYCLE_TABLE[opcode as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/nes_system/cpu.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | self.cycles += CYCLE_TABLE[opcode as usize] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CYCLE_TABLE[opcode as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes_system/memory.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | self.load_byte(addr) as u16 | (self.load_byte(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes_system/memory.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | self.load_byte(addr) as u16 | (self.load_byte(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes_system/memory.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | self.load_byte(addr) as u16 | (self.load_byte(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte(addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/nes_system/memory.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | self.load_byte(addr) as u16 | (self.load_byte(addr + 1) as u16) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.load_byte(addr + 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/nes_system/nesfile.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | let prg_page_count: u8 = *file.get(4).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&file[4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/nes_system/nesfile.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let chr_page_count: u8 = *file.get(5).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&file[5]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/nes_system/nesfile.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | let prg_page_count: u8 = *file.get(4).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&file[4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/nes_system/nesfile.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let chr_page_count: u8 = *file.get(5).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `&file[5]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "05aa4e3fffa1e78b5b47c78142babf67b62542bc9cd5360b911ab8c76bb57975"` [INFO] running `"docker" "rm" "-f" "05aa4e3fffa1e78b5b47c78142babf67b62542bc9cd5360b911ab8c76bb57975"` [INFO] [stdout] 05aa4e3fffa1e78b5b47c78142babf67b62542bc9cd5360b911ab8c76bb57975