[INFO] updating cached repository seritools/rs-quake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/seritools/rs-quake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/seritools/rs-quake" "work/ex/clippy-test-run/sources/stable/gh/seritools/rs-quake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seritools/rs-quake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/seritools/rs-quake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/rs-quake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/rs-quake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8309cec18730cc3bfedbe82fc3d08ae77403b66d [INFO] sha for GitHub repo seritools/rs-quake: 8309cec18730cc3bfedbe82fc3d08ae77403b66d [INFO] validating manifest of seritools/rs-quake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of seritools/rs-quake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing seritools/rs-quake [INFO] finished frobbing seritools/rs-quake [INFO] frobbed toml for seritools/rs-quake written to work/ex/clippy-test-run/sources/stable/gh/seritools/rs-quake/Cargo.toml [INFO] started frobbing seritools/rs-quake [INFO] finished frobbing seritools/rs-quake [INFO] frobbed toml for seritools/rs-quake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/rs-quake/Cargo.toml [INFO] crate seritools/rs-quake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting seritools/rs-quake against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seritools/rs-quake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8c645950012e43f77a92e4b4767bc3ede1dbe5e04639b5ecca336196006cb97f [INFO] running `"docker" "start" "-a" "8c645950012e43f77a92e4b4767bc3ede1dbe5e04639b5ecca336196006cb97f"` [INFO] [stderr] Checking itertools v0.6.1 [INFO] [stderr] Checking rs-quake v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/float_time.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | instant [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/float_time.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let instant = Instant::now(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmdline.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | const SAFE_ARG: &'static str = "-safe"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmdline.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | const SAFE_ARGVS: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/view.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `BaseParams` [INFO] [stderr] --> src/view.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | use state::{BaseParams, State}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cvar` [INFO] [stderr] --> src/view.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | use cvar::{Cvar, CvarMap, SharedCvar}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | const GAME_NAME: &'static str = "id1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | fn command_execute_cmdline_commands(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:76:56 [INFO] [stderr] | [INFO] [stderr] 76 | fn command_execute_cmdline_commands(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | fn command_execute_script(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | fn command_execute_script(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | fn command_echo(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:84:36 [INFO] [stderr] | [INFO] [stderr] 84 | fn command_echo(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | fn command_alias(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | fn command_alias(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | fn command_send_command_to_server(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | fn command_send_command_to_server(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | fn command_wait(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | fn command_wait(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `host` [INFO] [stderr] --> src/main.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | fn main_loop(host: &mut Host) {} [INFO] [stderr] | ^^^^ help: consider using `_host` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `view` [INFO] [stderr] --> src/host.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let view = View::init(&mut commands, &mut cvars); [INFO] [stderr] | ^^^^ help: consider using `_view` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file_system` [INFO] [stderr] --> src/host.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let file_system = FileSystem::init(&mut commands, &base_params); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_file_system` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/view.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | fn color_shift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/view.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | fn color_shift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/view.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | fn bonus_flash(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/view.rs:51:39 [INFO] [stderr] | [INFO] [stderr] 51 | fn bonus_flash(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/view.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | fn start_pitch_drift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/view.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | fn start_pitch_drift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/filesystem/pack.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | fn load(path: &Path) -> Result { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/filesystem/pack.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn load_game_file(path: &Path) { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/filesystem/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | fn path(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/filesystem/mod.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | fn path(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/float_time.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | instant [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/float_time.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | let instant = Instant::now(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmdline.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | const SAFE_ARG: &'static str = "-safe"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cmdline.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | const SAFE_ARGVS: [&'static str; 7] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::cell::RefCell` [INFO] [stderr] --> src/view.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::cell::RefCell; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `BaseParams` [INFO] [stderr] --> src/view.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | use state::{BaseParams, State}; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Cvar` [INFO] [stderr] --> src/view.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | use cvar::{Cvar, CvarMap, SharedCvar}; [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:23:19 [INFO] [stderr] | [INFO] [stderr] 23 | const GAME_NAME: &'static str = "id1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/float_time.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | self.subsec_nanos() as f64 * NANOSECS_TO_MICROSECS [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/common.rs:21:54 [INFO] [stderr] | [INFO] [stderr] 21 | Some(val) => Continue((acc * 16.0) + (val as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/common.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | return (val * (sign as f64)) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(sign)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/filesystem/mod.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .unwrap_or(base_params.basedir.to_owned().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| base_params.basedir.to_owned().into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/filesystem/mod.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | .unwrap_or(base_params.basedir.to_owned().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `base_params.basedir.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/filesystem/mod.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | Some(ref path) => Some((*path).to_owned().into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(*path).to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:76:37 [INFO] [stderr] | [INFO] [stderr] 76 | fn command_execute_cmdline_commands(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:76:56 [INFO] [stderr] | [INFO] [stderr] 76 | fn command_execute_cmdline_commands(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | fn command_execute_script(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:80:46 [INFO] [stderr] | [INFO] [stderr] 80 | fn command_execute_script(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | fn command_echo(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:84:36 [INFO] [stderr] | [INFO] [stderr] 84 | fn command_echo(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | fn command_alias(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:88:37 [INFO] [stderr] | [INFO] [stderr] 88 | fn command_alias(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:92:35 [INFO] [stderr] | [INFO] [stderr] 92 | fn command_send_command_to_server(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:92:54 [INFO] [stderr] | [INFO] [stderr] 92 | fn command_send_command_to_server(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/host.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | fn command_wait(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/host.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | fn command_wait(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `host` [INFO] [stderr] --> src/main.rs:55:14 [INFO] [stderr] | [INFO] [stderr] 55 | fn main_loop(host: &mut Host) {} [INFO] [stderr] | ^^^^ help: consider using `_host` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `view` [INFO] [stderr] --> src/host.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | let view = View::init(&mut commands, &mut cvars); [INFO] [stderr] | ^^^^ help: consider using `_view` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `file_system` [INFO] [stderr] --> src/host.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | let file_system = FileSystem::init(&mut commands, &base_params); [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_file_system` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/view.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | fn color_shift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/view.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | fn color_shift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/view.rs:51:20 [INFO] [stderr] | [INFO] [stderr] 51 | fn bonus_flash(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/view.rs:51:39 [INFO] [stderr] | [INFO] [stderr] 51 | fn bonus_flash(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/view.rs:56:26 [INFO] [stderr] | [INFO] [stderr] 56 | fn start_pitch_drift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/view.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | fn start_pitch_drift(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/filesystem/pack.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | fn load(path: &Path) -> Result { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `path` [INFO] [stderr] --> src/filesystem/pack.rs:21:23 [INFO] [stderr] | [INFO] [stderr] 21 | fn load_game_file(path: &Path) { [INFO] [stderr] | ^^^^ help: consider using `_path` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/filesystem/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | fn path(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `args` [INFO] [stderr] --> src/filesystem/mod.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | fn path(state: &mut State, args: CommandArgs) { [INFO] [stderr] | ^^^^ help: consider using `_args` instead [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/float_time.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | self.subsec_nanos() as f64 * NANOSECS_TO_MICROSECS [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/common.rs:21:54 [INFO] [stderr] | [INFO] [stderr] 21 | Some(val) => Continue((acc * 16.0) + (val as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/common.rs:26:23 [INFO] [stderr] | [INFO] [stderr] 26 | return (val * (sign as f64)) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(sign)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/filesystem/mod.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | .unwrap_or(base_params.basedir.to_owned().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| base_params.basedir.to_owned().into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/filesystem/mod.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | .unwrap_or(base_params.basedir.to_owned().into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `base_params.basedir.to_owned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/filesystem/mod.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | Some(ref path) => Some((*path).to_owned().into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(*path).to_owned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.14s [INFO] running `"docker" "inspect" "8c645950012e43f77a92e4b4767bc3ede1dbe5e04639b5ecca336196006cb97f"` [INFO] running `"docker" "rm" "-f" "8c645950012e43f77a92e4b4767bc3ede1dbe5e04639b5ecca336196006cb97f"` [INFO] [stdout] 8c645950012e43f77a92e4b4767bc3ede1dbe5e04639b5ecca336196006cb97f