[INFO] updating cached repository serayuzgur/chainake [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/serayuzgur/chainake [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/serayuzgur/chainake" "work/ex/clippy-test-run/sources/stable/gh/serayuzgur/chainake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/serayuzgur/chainake'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/serayuzgur/chainake" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/serayuzgur/chainake"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/serayuzgur/chainake'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c5693bc2e3c41494c0b1c603737e0bf6a9e65787 [INFO] sha for GitHub repo serayuzgur/chainake: c5693bc2e3c41494c0b1c603737e0bf6a9e65787 [INFO] validating manifest of serayuzgur/chainake on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of serayuzgur/chainake on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing serayuzgur/chainake [INFO] finished frobbing serayuzgur/chainake [INFO] frobbed toml for serayuzgur/chainake written to work/ex/clippy-test-run/sources/stable/gh/serayuzgur/chainake/Cargo.toml [INFO] started frobbing serayuzgur/chainake [INFO] finished frobbing serayuzgur/chainake [INFO] frobbed toml for serayuzgur/chainake written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/serayuzgur/chainake/Cargo.toml [INFO] crate serayuzgur/chainake has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting serayuzgur/chainake against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/serayuzgur/chainake:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fdf8cc3702fb5e45bda350cd1a25fde8f839c8f6b54d733f6292497a1384d045 [INFO] running `"docker" "start" "-a" "fdf8cc3702fb5e45bda350cd1a25fde8f839c8f6b54d733f6292497a1384d045"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking chainake v0.0.1-alpha.1 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/apple.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | ' ' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/apple.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | ' ' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return vec.last().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec.last().unwrap().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return last.x == x && last.y == y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last.x == x && last.y == y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return last.x == x_min || last.x == x_max || last.y == y_min || last.y == y_max; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last.x == x_min || last.x == x_max || last.y == y_min || last.y == y_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `difficulty` [INFO] [stderr] --> src/main.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | fn play( &mut self, difficulty: usize) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_difficulty` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/snake.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match &self.direction { [INFO] [stderr] 66 | | &Direction::UP => { [INFO] [stderr] 67 | | next.y = last.y.saturating_sub(1); [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | match self.direction { [INFO] [stderr] 66 | Direction::UP => { [INFO] [stderr] 67 | next.y = last.y.saturating_sub(1); [INFO] [stderr] 68 | } [INFO] [stderr] 69 | Direction::RIGHT => { [INFO] [stderr] 70 | next.x = last.x.saturating_add(1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/snake.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | &body.push(next.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `body.push(next.clone());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/snake.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | &self.ghost.push(deleted.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.ghost.push(deleted.clone());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/snake.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn is_colliding(&mut self, x_min: u16, y_min: u16, x_max: u16, y_max: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/snake.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | &self.ghost.clear(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.ghost.clear();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/apple.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match &self.ghost { [INFO] [stderr] 60 | | Some(ghost) => { [INFO] [stderr] 61 | | write!( [INFO] [stderr] 62 | | stdout, [INFO] [stderr] ... | [INFO] [stderr] 68 | | _=>{} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(ghost) = &self.ghost { [INFO] [stderr] 60 | write!( [INFO] [stderr] 61 | stdout, [INFO] [stderr] 62 | "{}{}", [INFO] [stderr] 63 | cursor::Goto(ghost.x, ghost.y), [INFO] [stderr] 64 | ' ' [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | stdout.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | / match buf.get(0).unwrap() { [INFO] [stderr] 54 | | //113=q 27 starting of arrow and esc keys [INFO] [stderr] 55 | | &113 | &27 => { [INFO] [stderr] 56 | | match buf.get(1).unwrap() { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *buf.get(0).unwrap() { [INFO] [stderr] 54 | //113=q 27 starting of arrow and esc keys [INFO] [stderr] 55 | 113 | 27 => { [INFO] [stderr] 56 | match buf.get(1).unwrap() { [INFO] [stderr] 57 | &91 => { [INFO] [stderr] 58 | match buf.get(2).unwrap() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | / match buf.get(1).unwrap() { [INFO] [stderr] 57 | | &91 => { [INFO] [stderr] 58 | | match buf.get(2).unwrap() { [INFO] [stderr] 59 | | /*TOP*/ [INFO] [stderr] ... | [INFO] [stderr] 73 | | _ => {} [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *buf.get(1).unwrap() { [INFO] [stderr] 57 | 91 => { [INFO] [stderr] 58 | match buf.get(2).unwrap() { [INFO] [stderr] 59 | /*TOP*/ [INFO] [stderr] 60 | &65 => self.snake.set_direction(snake::Direction::UP), [INFO] [stderr] 61 | /*BOTTOM*/ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:58:37 [INFO] [stderr] | [INFO] [stderr] 58 | / match buf.get(2).unwrap() { [INFO] [stderr] 59 | | /*TOP*/ [INFO] [stderr] 60 | | &65 => self.snake.set_direction(snake::Direction::UP), [INFO] [stderr] 61 | | /*BOTTOM*/ [INFO] [stderr] ... | [INFO] [stderr] 67 | | _ => {} [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | match *buf.get(2).unwrap() { [INFO] [stderr] 59 | /*TOP*/ [INFO] [stderr] 60 | 65 => self.snake.set_direction(snake::Direction::UP), [INFO] [stderr] 61 | /*BOTTOM*/ [INFO] [stderr] 62 | 66 => self.snake.set_direction(snake::Direction::DOWN), [INFO] [stderr] 63 | /*RIGHT*/ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | &self.snake.move_1(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake.move_1(true);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | &self.snake.move_1(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake.move_1(false);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | &self.draw(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `self.draw(true);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | return vec.last().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `vec.last().unwrap().clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | return last.x == x && last.y == y; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last.x == x && last.y == y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/snake.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | return last.x == x_min || last.x == x_max || last.y == y_min || last.y == y_max; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last.x == x_min || last.x == x_max || last.y == y_min || last.y == y_max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `difficulty` [INFO] [stderr] --> src/main.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | fn play( &mut self, difficulty: usize) { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_difficulty` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/snake.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | / match &self.direction { [INFO] [stderr] 66 | | &Direction::UP => { [INFO] [stderr] 67 | | next.y = last.y.saturating_sub(1); [INFO] [stderr] 68 | | } [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 65 | match self.direction { [INFO] [stderr] 66 | Direction::UP => { [INFO] [stderr] 67 | next.y = last.y.saturating_sub(1); [INFO] [stderr] 68 | } [INFO] [stderr] 69 | Direction::RIGHT => { [INFO] [stderr] 70 | next.x = last.x.saturating_add(1); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/snake.rs:79:9 [INFO] [stderr] | [INFO] [stderr] 79 | &body.push(next.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `body.push(next.clone());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/snake.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | &self.ghost.push(deleted.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.ghost.push(deleted.clone());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/snake.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn is_colliding(&mut self, x_min: u16, y_min: u16, x_max: u16, y_max: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/snake.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | &self.ghost.clear(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.ghost.clear();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/apple.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | / match &self.ghost { [INFO] [stderr] 60 | | Some(ghost) => { [INFO] [stderr] 61 | | write!( [INFO] [stderr] 62 | | stdout, [INFO] [stderr] ... | [INFO] [stderr] 68 | | _=>{} [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 59 | if let Some(ghost) = &self.ghost { [INFO] [stderr] 60 | write!( [INFO] [stderr] 61 | stdout, [INFO] [stderr] 62 | "{}{}", [INFO] [stderr] 63 | cursor::Goto(ghost.x, ghost.y), [INFO] [stderr] 64 | ' ' [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | stdout.flush(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | / match buf.get(0).unwrap() { [INFO] [stderr] 54 | | //113=q 27 starting of arrow and esc keys [INFO] [stderr] 55 | | &113 | &27 => { [INFO] [stderr] 56 | | match buf.get(1).unwrap() { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 53 | match *buf.get(0).unwrap() { [INFO] [stderr] 54 | //113=q 27 starting of arrow and esc keys [INFO] [stderr] 55 | 113 | 27 => { [INFO] [stderr] 56 | match buf.get(1).unwrap() { [INFO] [stderr] 57 | &91 => { [INFO] [stderr] 58 | match buf.get(2).unwrap() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | / match buf.get(1).unwrap() { [INFO] [stderr] 57 | | &91 => { [INFO] [stderr] 58 | | match buf.get(2).unwrap() { [INFO] [stderr] 59 | | /*TOP*/ [INFO] [stderr] ... | [INFO] [stderr] 73 | | _ => {} [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *buf.get(1).unwrap() { [INFO] [stderr] 57 | 91 => { [INFO] [stderr] 58 | match buf.get(2).unwrap() { [INFO] [stderr] 59 | /*TOP*/ [INFO] [stderr] 60 | &65 => self.snake.set_direction(snake::Direction::UP), [INFO] [stderr] 61 | /*BOTTOM*/ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:58:37 [INFO] [stderr] | [INFO] [stderr] 58 | / match buf.get(2).unwrap() { [INFO] [stderr] 59 | | /*TOP*/ [INFO] [stderr] 60 | | &65 => self.snake.set_direction(snake::Direction::UP), [INFO] [stderr] 61 | | /*BOTTOM*/ [INFO] [stderr] ... | [INFO] [stderr] 67 | | _ => {} [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 58 | match *buf.get(2).unwrap() { [INFO] [stderr] 59 | /*TOP*/ [INFO] [stderr] 60 | 65 => self.snake.set_direction(snake::Direction::UP), [INFO] [stderr] 61 | /*BOTTOM*/ [INFO] [stderr] 62 | 66 => self.snake.set_direction(snake::Direction::DOWN), [INFO] [stderr] 63 | /*RIGHT*/ [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | &self.snake.move_1(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake.move_1(true);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | &self.snake.move_1(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.snake.move_1(false);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | &self.draw(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `self.draw(true);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.03s [INFO] running `"docker" "inspect" "fdf8cc3702fb5e45bda350cd1a25fde8f839c8f6b54d733f6292497a1384d045"` [INFO] running `"docker" "rm" "-f" "fdf8cc3702fb5e45bda350cd1a25fde8f839c8f6b54d733f6292497a1384d045"` [INFO] [stdout] fdf8cc3702fb5e45bda350cd1a25fde8f839c8f6b54d733f6292497a1384d045