[INFO] updating cached repository sepiropht/find-and-count [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sepiropht/find-and-count [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sepiropht/find-and-count" "work/ex/clippy-test-run/sources/stable/gh/sepiropht/find-and-count"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sepiropht/find-and-count'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sepiropht/find-and-count" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sepiropht/find-and-count"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sepiropht/find-and-count'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bcf217ba67ac27d1c790599feae0e603925987f2 [INFO] sha for GitHub repo sepiropht/find-and-count: bcf217ba67ac27d1c790599feae0e603925987f2 [INFO] validating manifest of sepiropht/find-and-count on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sepiropht/find-and-count on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sepiropht/find-and-count [INFO] finished frobbing sepiropht/find-and-count [INFO] frobbed toml for sepiropht/find-and-count written to work/ex/clippy-test-run/sources/stable/gh/sepiropht/find-and-count/Cargo.toml [INFO] started frobbing sepiropht/find-and-count [INFO] finished frobbing sepiropht/find-and-count [INFO] frobbed toml for sepiropht/find-and-count written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sepiropht/find-and-count/Cargo.toml [INFO] crate sepiropht/find-and-count has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sepiropht/find-and-count against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sepiropht/find-and-count:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d0178a485750494581f5fcc321e461dab149d0b049e68e0c5a09f88c91d30b19 [INFO] running `"docker" "start" "-a" "d0178a485750494581f5fcc321e461dab149d0b049e68e0c5a09f88c91d30b19"` [INFO] [stderr] Checking colored v1.6.1 [INFO] [stderr] Checking fdl v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `BufRead` [INFO] [stderr] --> src/main.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{self, BufRead}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file_tree.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const HORIZONTAL_STR: &'static str = "├──"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file_tree.rs:12:29 [INFO] [stderr] | [INFO] [stderr] 12 | const LAST_HORIZONTAL_STR: &'static str = "└──"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_tree.rs:62:6 [INFO] [stderr] | [INFO] [stderr] 62 | return Ok("angular".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("angular".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_tree.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `BufRead` [INFO] [stderr] --> src/main.rs:3:21 [INFO] [stderr] | [INFO] [stderr] 3 | use std::io::{self, BufRead}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file_tree.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const HORIZONTAL_STR: &'static str = "├──"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/file_tree.rs:12:29 [INFO] [stderr] | [INFO] [stderr] 12 | const LAST_HORIZONTAL_STR: &'static str = "└──"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_tree.rs:62:6 [INFO] [stderr] | [INFO] [stderr] 62 | return Ok("angular".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("angular".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_tree.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return Ok("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok("".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | let e = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:147:17 [INFO] [stderr] | [INFO] [stderr] 147 | let d = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | let c = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | let b = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | let expected_tree = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:170:17 [INFO] [stderr] | [INFO] [stderr] 170 | let e = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | let d = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | let c = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | let b = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:186:29 [INFO] [stderr] | [INFO] [stderr] 186 | let expected_tree = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:197:17 [INFO] [stderr] | [INFO] [stderr] 197 | let d = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:201:17 [INFO] [stderr] | [INFO] [stderr] 201 | let c = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:205:17 [INFO] [stderr] | [INFO] [stderr] 205 | let b = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0063]: missing field `frame_work` in initializer of `file_tree::FileTree` [INFO] [stderr] --> src/file_tree.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | let a = FileTree { [INFO] [stderr] | ^^^^^^^^ missing `frame_work` [INFO] [stderr] [INFO] [stderr] error[E0061]: this function takes 4 parameters but 3 parameters were supplied [INFO] [stderr] --> src/file_tree.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 24 | fn print_line(output: &mut W, lasts: &[bool], name: &OsStr, frame_work: &str) -> io::Result<()> { [INFO] [stderr] | --------------------------------------------------------------------------------------------------------- defined here [INFO] [stderr] ... [INFO] [stderr] 225 | print_line(&mut output1, &[], name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 4 parameters [INFO] [stderr] [INFO] [stderr] error[E0061]: this function takes 4 parameters but 3 parameters were supplied [INFO] [stderr] --> src/file_tree.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 24 | fn print_line(output: &mut W, lasts: &[bool], name: &OsStr, frame_work: &str) -> io::Result<()> { [INFO] [stderr] | --------------------------------------------------------------------------------------------------------- defined here [INFO] [stderr] ... [INFO] [stderr] 229 | print_line(&mut output2, &[true, false, true], name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 4 parameters [INFO] [stderr] [INFO] [stderr] error[E0061]: this function takes 4 parameters but 3 parameters were supplied [INFO] [stderr] --> src/file_tree.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 24 | fn print_line(output: &mut W, lasts: &[bool], name: &OsStr, frame_work: &str) -> io::Result<()> { [INFO] [stderr] | --------------------------------------------------------------------------------------------------------- defined here [INFO] [stderr] ... [INFO] [stderr] 233 | print_line(&mut output3, &[true, false, false], name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 4 parameters [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/file_tree.rs:31:8 [INFO] [stderr] | [INFO] [stderr] 31 | if lasts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lasts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 17 previous errors [INFO] [stderr] [INFO] [stderr] Some errors occurred: E0061, E0063. [INFO] [stderr] For more information about an error, try `rustc --explain E0061`. [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:16:38 [INFO] [stderr] | [INFO] [stderr] 16 | let mut input = files.iter().map(|s| OsString::from(s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OsString::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: Could not compile `fdl`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "d0178a485750494581f5fcc321e461dab149d0b049e68e0c5a09f88c91d30b19"` [INFO] running `"docker" "rm" "-f" "d0178a485750494581f5fcc321e461dab149d0b049e68e0c5a09f88c91d30b19"` [INFO] [stdout] d0178a485750494581f5fcc321e461dab149d0b049e68e0c5a09f88c91d30b19