[INFO] updating cached repository segfo/dirwalker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/segfo/dirwalker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/segfo/dirwalker" "work/ex/clippy-test-run/sources/stable/gh/segfo/dirwalker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/segfo/dirwalker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/segfo/dirwalker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/dirwalker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/dirwalker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24bd0713bd6c0087e2d47c94ae4b1b9a014eb1f4 [INFO] sha for GitHub repo segfo/dirwalker: 24bd0713bd6c0087e2d47c94ae4b1b9a014eb1f4 [INFO] validating manifest of segfo/dirwalker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of segfo/dirwalker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing segfo/dirwalker [INFO] finished frobbing segfo/dirwalker [INFO] frobbed toml for segfo/dirwalker written to work/ex/clippy-test-run/sources/stable/gh/segfo/dirwalker/Cargo.toml [INFO] started frobbing segfo/dirwalker [INFO] finished frobbing segfo/dirwalker [INFO] frobbed toml for segfo/dirwalker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/dirwalker/Cargo.toml [INFO] crate segfo/dirwalker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting segfo/dirwalker against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/segfo/dirwalker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 38f3a556f4288faa5a63a39d4618d651ec57b909db9e49e341ae6fdb88325d22 [INFO] running `"docker" "start" "-a" "38f3a556f4288faa5a63a39d4618d651ec57b909db9e49e341ae6fdb88325d22"` [INFO] [stderr] Checking dirwalker v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | dir_list:dir_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `dir_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | root_dir_mode:root_dir_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_dir_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | dir_list:dir_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `dir_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | root_dir_mode:root_dir_mode, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `root_dir_mode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `walker` [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | fn callback(walker:&DirectoryWalker,entry:DirEntry,parent:&DirectoryInfo) -> io::Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_walker` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `entry` [INFO] [stderr] --> src/main.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | fn callback(walker:&DirectoryWalker,entry:DirEntry,parent:&DirectoryInfo) -> io::Result<()> { [INFO] [stderr] | ^^^^^ help: consider using `_entry` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parent` [INFO] [stderr] --> src/main.rs:57:52 [INFO] [stderr] | [INFO] [stderr] 57 | fn callback(walker:&DirectoryWalker,entry:DirEntry,parent:&DirectoryInfo) -> io::Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_parent` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `walker` [INFO] [stderr] --> src/main.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | fn callback(walker:&DirectoryWalker,entry:DirEntry,parent:&DirectoryInfo) -> io::Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_walker` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `entry` [INFO] [stderr] --> src/main.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | fn callback(walker:&DirectoryWalker,entry:DirEntry,parent:&DirectoryInfo) -> io::Result<()> { [INFO] [stderr] | ^^^^^ help: consider using `_entry` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `parent` [INFO] [stderr] --> src/main.rs:57:52 [INFO] [stderr] | [INFO] [stderr] 57 | fn callback(walker:&DirectoryWalker,entry:DirEntry,parent:&DirectoryInfo) -> io::Result<()> { [INFO] [stderr] | ^^^^^^ help: consider using `_parent` instead [INFO] [stderr] [INFO] [stderr] warning: field is never used: `root_dir` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | root_dir:String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `root_dir_mode` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | root_dir_mode:u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | let prog:String = env::args().next().unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if args.len()<1{ [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if walker.dir_list.len()==0{break;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `walker.dir_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: field is never used: `root_dir` [INFO] [stderr] --> src/main.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | root_dir:String, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `root_dir_mode` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | root_dir_mode:u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:62:42 [INFO] [stderr] | [INFO] [stderr] 62 | let prog:String = env::args().next().unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/main.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if args.len()<1{ [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if walker.dir_list.len()==0{break;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `walker.dir_list.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "38f3a556f4288faa5a63a39d4618d651ec57b909db9e49e341ae6fdb88325d22"` [INFO] running `"docker" "rm" "-f" "38f3a556f4288faa5a63a39d4618d651ec57b909db9e49e341ae6fdb88325d22"` [INFO] [stdout] 38f3a556f4288faa5a63a39d4618d651ec57b909db9e49e341ae6fdb88325d22