[INFO] updating cached repository seeba8/rustsweeper
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/seeba8/rustsweeper
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/seeba8/rustsweeper" "work/ex/clippy-test-run/sources/stable/gh/seeba8/rustsweeper"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/seeba8/rustsweeper'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/seeba8/rustsweeper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seeba8/rustsweeper"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seeba8/rustsweeper'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 26af1322ebebf64a2e75e056edaf4161134e0864
[INFO] sha for GitHub repo seeba8/rustsweeper: 26af1322ebebf64a2e75e056edaf4161134e0864
[INFO] validating manifest of seeba8/rustsweeper on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of seeba8/rustsweeper on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing seeba8/rustsweeper
[INFO] finished frobbing seeba8/rustsweeper
[INFO] frobbed toml for seeba8/rustsweeper written to work/ex/clippy-test-run/sources/stable/gh/seeba8/rustsweeper/Cargo.toml
[INFO] started frobbing seeba8/rustsweeper
[INFO] finished frobbing seeba8/rustsweeper
[INFO] frobbed toml for seeba8/rustsweeper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seeba8/rustsweeper/Cargo.toml
[INFO] crate seeba8/rustsweeper has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting seeba8/rustsweeper against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/seeba8/rustsweeper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 45d5e7f6b97464d56d6c00d941f0850aaac7a55f717958258ddf478e7fd91c53
[INFO] running `"docker" "start" "-a" "45d5e7f6b97464d56d6c00d941f0850aaac7a55f717958258ddf478e7fd91c53"`
[INFO] [stderr]     Checking rand v0.4.2
[INFO] [stderr]     Checking rand v0.3.22
[INFO] [stderr]     Checking rustsweeper v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `std::fmt`
[INFO] [stderr]  --> src/main.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::fmt;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 | /                 if self.in_range(x+x_incr,y+y_incr) {
[INFO] [stderr] 107 | |                     if self.field[x+x_incr - 1][y + y_incr - 1] {
[INFO] [stderr] 108 | |                         count += 1;
[INFO] [stderr] 109 | |                     }
[INFO] [stderr] 110 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 if self.in_range(x+x_incr,y+y_incr) && self.field[x+x_incr - 1][y + y_incr - 1] {
[INFO] [stderr] 107 |     count += 1;
[INFO] [stderr] 108 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::fmt`
[INFO] [stderr]  --> src/main.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::fmt;
[INFO] [stderr]   |     ^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 | /                 if self.in_range(x+x_incr,y+y_incr) {
[INFO] [stderr] 107 | |                     if self.field[x+x_incr - 1][y + y_incr - 1] {
[INFO] [stderr] 108 | |                         count += 1;
[INFO] [stderr] 109 | |                     }
[INFO] [stderr] 110 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 if self.in_range(x+x_incr,y+y_incr) && self.field[x+x_incr - 1][y + y_incr - 1] {
[INFO] [stderr] 107 |     count += 1;
[INFO] [stderr] 108 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |         let mut state = [[FieldState::None; 9]; 9];
[INFO] [stderr]    |             ----^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         let mut bombflag = false;
[INFO] [stderr] 24 | |         if v.len() > 2 {
[INFO] [stderr] 25 | |             bombflag = v[2].trim() == "b";
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> bombflag = if v.len() > 2 { v[2].trim() == "b" } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:14:44
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let v: Vec<&str> = guess[..].split(",").collect();
[INFO] [stderr]    |                                            ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:73:28
[INFO] [stderr]    |
[INFO] [stderr] 73 |             let mut line = String::from(format!("{} |", y+1));
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{} |", y+1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:84:25
[INFO] [stderr]    |
[INFO] [stderr] 84 | /                         match self.field[x][y] {
[INFO] [stderr] 85 | |                             true => line.push_str(" X "),
[INFO] [stderr] 86 | |                             false => line.push_str(&format!(" {} ", self.get_number(x,y))[..]),
[INFO] [stderr] 87 | |                         }
[INFO] [stderr]    | |_________________________^ help: consider using an if/else expression: `if self.field[x][y] { line.push_str(" X ") } else { line.push_str(&format!(" {} ", self.get_number(x,y))[..]) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/main.rs:61:13
[INFO] [stderr]    |
[INFO] [stderr] 61 |         let mut state = [[FieldState::None; 9]; 9];
[INFO] [stderr]    |             ----^^^^^
[INFO] [stderr]    |             |
[INFO] [stderr]    |             help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/main.rs:23:9
[INFO] [stderr]    |
[INFO] [stderr] 23 | /         let mut bombflag = false;
[INFO] [stderr] 24 | |         if v.len() > 2 {
[INFO] [stderr] 25 | |             bombflag = v[2].trim() == "b";
[INFO] [stderr] 26 | |         }
[INFO] [stderr]    | |_________^ help: it is more idiomatic to write: `let <mut> bombflag = if v.len() > 2 { v[2].trim() == "b" } else { false };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = note: you might not need `mut` at all
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:14:44
[INFO] [stderr]    |
[INFO] [stderr] 14 |         let v: Vec<&str> = guess[..].split(",").collect();
[INFO] [stderr]    |                                            ^^^ help: try using a char instead: `','`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/main.rs:73:28
[INFO] [stderr]    |
[INFO] [stderr] 73 |             let mut line = String::from(format!("{} |", y+1));
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{} |", y+1)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:84:25
[INFO] [stderr]    |
[INFO] [stderr] 84 | /                         match self.field[x][y] {
[INFO] [stderr] 85 | |                             true => line.push_str(" X "),
[INFO] [stderr] 86 | |                             false => line.push_str(&format!(" {} ", self.get_number(x,y))[..]),
[INFO] [stderr] 87 | |                         }
[INFO] [stderr]    | |_________________________^ help: consider using an if/else expression: `if self.field[x][y] { line.push_str(" X ") } else { line.push_str(&format!(" {} ", self.get_number(x,y))[..]) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.03s
[INFO] running `"docker" "inspect" "45d5e7f6b97464d56d6c00d941f0850aaac7a55f717958258ddf478e7fd91c53"`
[INFO] running `"docker" "rm" "-f" "45d5e7f6b97464d56d6c00d941f0850aaac7a55f717958258ddf478e7fd91c53"`
[INFO] [stdout] 45d5e7f6b97464d56d6c00d941f0850aaac7a55f717958258ddf478e7fd91c53