[INFO] updating cached repository sebglazebrook/walk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sebglazebrook/walk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sebglazebrook/walk" "work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/walk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/walk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sebglazebrook/walk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/walk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/walk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 28372a4fc334f83fc40216c629e2552ed137d413 [INFO] sha for GitHub repo sebglazebrook/walk: 28372a4fc334f83fc40216c629e2552ed137d413 [INFO] validating manifest of sebglazebrook/walk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sebglazebrook/walk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sebglazebrook/walk [INFO] finished frobbing sebglazebrook/walk [INFO] frobbed toml for sebglazebrook/walk written to work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/walk/Cargo.toml [INFO] started frobbing sebglazebrook/walk [INFO] finished frobbing sebglazebrook/walk [INFO] frobbed toml for sebglazebrook/walk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/walk/Cargo.toml [INFO] crate sebglazebrook/walk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sebglazebrook/walk against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/walk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ff5452cd712643ab1c70a86de9afcdde004119960680190c588c2a754492683 [INFO] running `"docker" "start" "-a" "6ff5452cd712643ab1c70a86de9afcdde004119960680190c588c2a754492683"` [INFO] [stderr] Checking libc v0.2.15 [INFO] [stderr] Checking unicode-segmentation v0.1.2 [INFO] [stderr] Checking strsim v0.5.1 [INFO] [stderr] Checking yaml-rust v0.3.3 [INFO] [stderr] Checking term_size v0.2.1 [INFO] [stderr] Checking clap v2.11.2 [INFO] [stderr] Checking walk v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | show_files: show_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | show_directories: show_directories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_directories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | show_hidden: show_hidden, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_hidden` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | show_ignorable: show_ignorable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_ignorable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | start_directory: start_directory [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | show_files: show_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_files` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | show_directories: show_directories, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_directories` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | show_hidden: show_hidden, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_hidden` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | show_ignorable: show_ignorable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `show_ignorable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walk/config.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | start_directory: start_directory [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_directory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `walk::config::Config` [INFO] [stderr] --> src/walk/config.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | let yaml = load_yaml!("../../config/cli.yml"); [INFO] [stderr] 16 | | let matches = App::from_yaml(yaml).get_matches(); [INFO] [stderr] 17 | | [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / let show_files; [INFO] [stderr] 19 | | if matches.is_present("directories_only") { [INFO] [stderr] 20 | | show_files = false; [INFO] [stderr] 21 | | } else { [INFO] [stderr] 22 | | show_files = true; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let show_files = if matches.is_present("directories_only") { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / let show_directories; [INFO] [stderr] 26 | | if matches.is_present("files_only") { [INFO] [stderr] 27 | | show_directories = false; [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | show_directories = true; [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let show_directories = if matches.is_present("files_only") { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / let start_directory; [INFO] [stderr] 33 | | if matches.is_present("start_directory") { [INFO] [stderr] 34 | | start_directory = PathBuf::from(matches.value_of("start_directory").unwrap()); [INFO] [stderr] 35 | | } else { [INFO] [stderr] 36 | | start_directory = PathBuf::from("."); [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let start_directory = if matches.is_present("start_directory") { PathBuf::from(matches.value_of("start_directory").unwrap()) } else { PathBuf::from(".") };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / let mut show_ignorable = false; [INFO] [stderr] 41 | | [INFO] [stderr] 42 | | if matches.is_present("all") { [INFO] [stderr] 43 | | show_hidden = true; [INFO] [stderr] 44 | | show_ignorable = true; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let show_ignorable = if matches.is_present("all") { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `walk::ignorer::Ignorer` [INFO] [stderr] --> src/walk/ignorer.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Ignorer { gitignore_contents: HashMap::new() } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `walk::config::Config` [INFO] [stderr] --> src/walk/config.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / pub fn new() -> Self { [INFO] [stderr] 15 | | let yaml = load_yaml!("../../config/cli.yml"); [INFO] [stderr] 16 | | let matches = App::from_yaml(yaml).get_matches(); [INFO] [stderr] 17 | | [INFO] [stderr] ... | [INFO] [stderr] 53 | | } [INFO] [stderr] 54 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / let show_files; [INFO] [stderr] 19 | | if matches.is_present("directories_only") { [INFO] [stderr] 20 | | show_files = false; [INFO] [stderr] 21 | | } else { [INFO] [stderr] 22 | | show_files = true; [INFO] [stderr] 23 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let show_files = if matches.is_present("directories_only") { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / let show_directories; [INFO] [stderr] 26 | | if matches.is_present("files_only") { [INFO] [stderr] 27 | | show_directories = false; [INFO] [stderr] 28 | | } else { [INFO] [stderr] 29 | | show_directories = true; [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let show_directories = if matches.is_present("files_only") { false } else { true };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / let start_directory; [INFO] [stderr] 33 | | if matches.is_present("start_directory") { [INFO] [stderr] 34 | | start_directory = PathBuf::from(matches.value_of("start_directory").unwrap()); [INFO] [stderr] 35 | | } else { [INFO] [stderr] 36 | | start_directory = PathBuf::from("."); [INFO] [stderr] 37 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let start_directory = if matches.is_present("start_directory") { PathBuf::from(matches.value_of("start_directory").unwrap()) } else { PathBuf::from(".") };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/walk/config.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | / let mut show_ignorable = false; [INFO] [stderr] 41 | | [INFO] [stderr] 42 | | if matches.is_present("all") { [INFO] [stderr] 43 | | show_hidden = true; [INFO] [stderr] 44 | | show_ignorable = true; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let show_ignorable = if matches.is_present("all") { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `walk::ignorer::Ignorer` [INFO] [stderr] --> src/walk/ignorer.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | Ignorer { gitignore_contents: HashMap::new() } [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function `when_a_gitignore_does_NOT_matches_the_filename_it_does_not_get_ignored` should have a snake case name such as `when_a_gitignore_does_not_matches_the_filename_it_does_not_get_ignored` [INFO] [stderr] --> src/walk/ignorer.rs:49:1 [INFO] [stderr] | [INFO] [stderr] 49 | / fn when_a_gitignore_does_NOT_matches_the_filename_it_does_not_get_ignored() { [INFO] [stderr] 50 | | let mut ignorer = Ignorer::new(); [INFO] [stderr] 51 | | let gitignore_contents = "ignore-me.txt"; [INFO] [stderr] 52 | | let gitignore_path = PathBuf::from("/tmp"); [INFO] [stderr] ... | [INFO] [stderr] 55 | | assert_eq!(ignorer.ignore(&file_to_ignore), false); [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:10:80 [INFO] [stderr] | [INFO] [stderr] 10 | fn walk_dir(path: PathBuf, entry_callback: Arc, igorablable_filesources: &Vec<&str>, ignorer: &mut Ignorer) where F : Fn(std::fs::DirEntry) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / match fs::read_dir(path) { [INFO] [stderr] 12 | | Ok(read_dir) => { [INFO] [stderr] 13 | | for entry in read_dir { [INFO] [stderr] 14 | | match entry { [INFO] [stderr] ... | [INFO] [stderr] 38 | | Err(_) => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Ok(read_dir) = fs::read_dir(path) { [INFO] [stderr] 12 | for entry in read_dir { [INFO] [stderr] 13 | match entry { [INFO] [stderr] 14 | Ok(entry) => { [INFO] [stderr] 15 | [INFO] [stderr] 16 | let temp_file_name = entry.file_name(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | / match entry { [INFO] [stderr] 15 | | Ok(entry) => { [INFO] [stderr] 16 | | [INFO] [stderr] 17 | | let temp_file_name = entry.file_name(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | Err(_) => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Ok(entry) = entry { [INFO] [stderr] 15 | [INFO] [stderr] 16 | let temp_file_name = entry.file_name(); [INFO] [stderr] 17 | let file_name = temp_file_name.to_str().unwrap(); [INFO] [stderr] 18 | [INFO] [stderr] 19 | let file_type = entry.file_type().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | if path.starts_with(".") && !config.show_hidden { return; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:10:80 [INFO] [stderr] | [INFO] [stderr] 10 | fn walk_dir(path: PathBuf, entry_callback: Arc, igorablable_filesources: &Vec<&str>, ignorer: &mut Ignorer) where F : Fn(std::fs::DirEntry) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / match fs::read_dir(path) { [INFO] [stderr] 12 | | Ok(read_dir) => { [INFO] [stderr] 13 | | for entry in read_dir { [INFO] [stderr] 14 | | match entry { [INFO] [stderr] ... | [INFO] [stderr] 38 | | Err(_) => {} [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | if let Ok(read_dir) = fs::read_dir(path) { [INFO] [stderr] 12 | for entry in read_dir { [INFO] [stderr] 13 | match entry { [INFO] [stderr] 14 | Ok(entry) => { [INFO] [stderr] 15 | [INFO] [stderr] 16 | let temp_file_name = entry.file_name(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | / match entry { [INFO] [stderr] 15 | | Ok(entry) => { [INFO] [stderr] 16 | | [INFO] [stderr] 17 | | let temp_file_name = entry.file_name(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | Err(_) => {} [INFO] [stderr] 35 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Ok(entry) = entry { [INFO] [stderr] 15 | [INFO] [stderr] 16 | let temp_file_name = entry.file_name(); [INFO] [stderr] 17 | let file_name = temp_file_name.to_str().unwrap(); [INFO] [stderr] 18 | [INFO] [stderr] 19 | let file_type = entry.file_type().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:60:29 [INFO] [stderr] | [INFO] [stderr] 60 | if path.starts_with(".") && !config.show_hidden { return; } [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.59s [INFO] running `"docker" "inspect" "6ff5452cd712643ab1c70a86de9afcdde004119960680190c588c2a754492683"` [INFO] running `"docker" "rm" "-f" "6ff5452cd712643ab1c70a86de9afcdde004119960680190c588c2a754492683"` [INFO] [stdout] 6ff5452cd712643ab1c70a86de9afcdde004119960680190c588c2a754492683