[INFO] updating cached repository sebglazebrook/rust-shell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sebglazebrook/rust-shell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sebglazebrook/rust-shell" "work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/rust-shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/rust-shell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sebglazebrook/rust-shell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/rust-shell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/rust-shell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ed6285943a472e1569bd3c198b0dd64e84e1ecf6 [INFO] sha for GitHub repo sebglazebrook/rust-shell: ed6285943a472e1569bd3c198b0dd64e84e1ecf6 [INFO] validating manifest of sebglazebrook/rust-shell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sebglazebrook/rust-shell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sebglazebrook/rust-shell [INFO] finished frobbing sebglazebrook/rust-shell [INFO] frobbed toml for sebglazebrook/rust-shell written to work/ex/clippy-test-run/sources/stable/gh/sebglazebrook/rust-shell/Cargo.toml [INFO] started frobbing sebglazebrook/rust-shell [INFO] finished frobbing sebglazebrook/rust-shell [INFO] frobbed toml for sebglazebrook/rust-shell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/rust-shell/Cargo.toml [INFO] crate sebglazebrook/rust-shell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sebglazebrook/rust-shell against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sebglazebrook/rust-shell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 034a7d730b7803ab170b0fb22098668af4c7cd01d2ad82bc7b68914bf916fcc9 [INFO] running `"docker" "start" "-a" "034a7d730b7803ab170b0fb22098668af4c7cd01d2ad82bc7b68914bf916fcc9"` [INFO] [stderr] Checking rust-shell v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `command_string` [INFO] [stderr] --> src/lib.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn parse(&self, command_string: &str) -> CommandProxy { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_command_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | struct Parser; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/lib.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn parse(&self, command_string: &str) -> CommandProxy { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `CommandProxy` [INFO] [stderr] --> src/lib.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | struct CommandProxy<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/lib.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn new() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `name` [INFO] [stderr] --> src/lib.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn name(&mut self, name: &'a str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | self.name = name.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 28 | self.name = &(*name).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 28 | self.name = &str::clone(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-shell`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused variable: `command_string` [INFO] [stderr] --> src/lib.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn parse(&self, command_string: &str) -> CommandProxy { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_command_string` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/lib.rs:28:21 [INFO] [stderr] | [INFO] [stderr] 28 | self.name = name.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 28 | self.name = &(*name).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 28 | self.name = &str::clone(name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-shell`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "034a7d730b7803ab170b0fb22098668af4c7cd01d2ad82bc7b68914bf916fcc9"` [INFO] running `"docker" "rm" "-f" "034a7d730b7803ab170b0fb22098668af4c7cd01d2ad82bc7b68914bf916fcc9"` [INFO] [stdout] 034a7d730b7803ab170b0fb22098668af4c7cd01d2ad82bc7b68914bf916fcc9