[INFO] updating cached repository sdbondi/rust-concurrency-examples [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sdbondi/rust-concurrency-examples [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sdbondi/rust-concurrency-examples" "work/ex/clippy-test-run/sources/stable/gh/sdbondi/rust-concurrency-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sdbondi/rust-concurrency-examples'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sdbondi/rust-concurrency-examples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdbondi/rust-concurrency-examples"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdbondi/rust-concurrency-examples'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ad950a5e3c0e31b19228510e888af365dc29487d [INFO] sha for GitHub repo sdbondi/rust-concurrency-examples: ad950a5e3c0e31b19228510e888af365dc29487d [INFO] validating manifest of sdbondi/rust-concurrency-examples on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sdbondi/rust-concurrency-examples on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sdbondi/rust-concurrency-examples [INFO] finished frobbing sdbondi/rust-concurrency-examples [INFO] frobbed toml for sdbondi/rust-concurrency-examples written to work/ex/clippy-test-run/sources/stable/gh/sdbondi/rust-concurrency-examples/Cargo.toml [INFO] started frobbing sdbondi/rust-concurrency-examples [INFO] finished frobbing sdbondi/rust-concurrency-examples [INFO] frobbed toml for sdbondi/rust-concurrency-examples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdbondi/rust-concurrency-examples/Cargo.toml [INFO] crate sdbondi/rust-concurrency-examples has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sdbondi/rust-concurrency-examples against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sdbondi/rust-concurrency-examples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6b621f8792e6483e254d2b541ee3c4452d7af88c48a4736ce67b49a7f99c7a5 [INFO] running `"docker" "start" "-a" "e6b621f8792e6483e254d2b541ee3c4452d7af88c48a4736ce67b49a7f99c7a5"` [INFO] [stderr] Checking concurrency v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/pingpong.rs:23:28 [INFO] [stderr] | [INFO] [stderr] 23 | let ball = (*locked_table).recv().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/pingpong.rs:27:41 [INFO] [stderr] | [INFO] [stderr] 27 | let mut hit_count = ball.lock().unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/pingpong.rs:36:29 [INFO] [stderr] | [INFO] [stderr] 36 | racket.send(ball).unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/pingpong.rs:58:17 [INFO] [stderr] | [INFO] [stderr] 58 | racket.send(Mutex::new(0)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> examples/pingpong.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | table_lock.recv().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/pipeline.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | num = num + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `num += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "e6b621f8792e6483e254d2b541ee3c4452d7af88c48a4736ce67b49a7f99c7a5"` [INFO] running `"docker" "rm" "-f" "e6b621f8792e6483e254d2b541ee3c4452d7af88c48a4736ce67b49a7f99c7a5"` [INFO] [stdout] e6b621f8792e6483e254d2b541ee3c4452d7af88c48a4736ce67b49a7f99c7a5