[INFO] updating cached repository scurest/abrupng [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scurest/abrupng [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scurest/abrupng" "work/ex/clippy-test-run/sources/stable/gh/scurest/abrupng"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scurest/abrupng'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scurest/abrupng" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scurest/abrupng"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scurest/abrupng'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 73ab77f167cee216c9c2f88c70e31d6496d6a7af [INFO] sha for GitHub repo scurest/abrupng: 73ab77f167cee216c9c2f88c70e31d6496d6a7af [INFO] validating manifest of scurest/abrupng on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scurest/abrupng on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scurest/abrupng [INFO] finished frobbing scurest/abrupng [INFO] frobbed toml for scurest/abrupng written to work/ex/clippy-test-run/sources/stable/gh/scurest/abrupng/Cargo.toml [INFO] started frobbing scurest/abrupng [INFO] finished frobbing scurest/abrupng [INFO] frobbed toml for scurest/abrupng written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scurest/abrupng/Cargo.toml [INFO] crate scurest/abrupng has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scurest/abrupng against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scurest/abrupng:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ffc0e7efdbca5154c71255b548182667330ab5f8ca5fa8fb36eb2eed3ff580c7 [INFO] running `"docker" "start" "-a" "ffc0e7efdbca5154c71255b548182667330ab5f8ca5fa8fb36eb2eed3ff580c7"` [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking deflate v0.7.17 [INFO] [stderr] Checking inflate v0.3.3 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking abrupng v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let len = dec.rdr.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dec.rdr.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | let len = dec.rdr.read_u32::()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dec.rdr.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | let width = (right - left) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(right - left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:99:18 [INFO] [stderr] | [INFO] [stderr] 99 | let height = (bottom - top) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bottom - top)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/abr/abr6.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if buf == &b"8bim"[..] { [INFO] [stderr] | ^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b"8bim"[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/abr/abr6.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if buf == &b"samp"[..] { [INFO] [stderr] | ^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b"samp"[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr6.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | rdr.seek(SeekFrom::Current(len as i64))?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr6.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let len = rdr.read_u32::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rdr.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr6.rs:82:15 [INFO] [stderr] | [INFO] [stderr] 82 | let len = dec.rdr.read_u32::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dec.rdr.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/util.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | len += rdr.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rdr.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | .map_err(|e| Error::CouldntOpenAbr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::CouldntOpenAbr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:55:15 [INFO] [stderr] | [INFO] [stderr] 55 | let len = dec.rdr.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dec.rdr.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:74:19 [INFO] [stderr] | [INFO] [stderr] 74 | let len = dec.rdr.read_u32::()? as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(dec.rdr.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | let width = (right - left) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(right - left)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr1.rs:99:18 [INFO] [stderr] | [INFO] [stderr] 99 | let height = (bottom - top) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bottom - top)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/abr/abr6.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if buf == &b"8bim"[..] { [INFO] [stderr] | ^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b"8bim"[..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/abr/abr6.rs:28:12 [INFO] [stderr] | [INFO] [stderr] 28 | if buf == &b"samp"[..] { [INFO] [stderr] | ^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `b"samp"[..]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr6.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | rdr.seek(SeekFrom::Current(len as i64))?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr6.rs:36:15 [INFO] [stderr] | [INFO] [stderr] 36 | let len = rdr.read_u32::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rdr.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/abr6.rs:82:15 [INFO] [stderr] | [INFO] [stderr] 82 | let len = dec.rdr.read_u32::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dec.rdr.read_u32::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/abr/util.rs:21:16 [INFO] [stderr] | [INFO] [stderr] 21 | len += rdr.read_u16::()? as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(rdr.read_u16::()?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | .map_err(|e| Error::CouldntOpenAbr(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::CouldntOpenAbr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.18s [INFO] running `"docker" "inspect" "ffc0e7efdbca5154c71255b548182667330ab5f8ca5fa8fb36eb2eed3ff580c7"` [INFO] running `"docker" "rm" "-f" "ffc0e7efdbca5154c71255b548182667330ab5f8ca5fa8fb36eb2eed3ff580c7"` [INFO] [stdout] ffc0e7efdbca5154c71255b548182667330ab5f8ca5fa8fb36eb2eed3ff580c7