[INFO] updating cached repository scrogson/scotty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/scrogson/scotty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/scrogson/scotty" "work/ex/clippy-test-run/sources/stable/gh/scrogson/scotty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scrogson/scotty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/scrogson/scotty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scrogson/scotty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scrogson/scotty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 735caf46abf81381b5929a9d52d6277b9fa816f7 [INFO] sha for GitHub repo scrogson/scotty: 735caf46abf81381b5929a9d52d6277b9fa816f7 [INFO] validating manifest of scrogson/scotty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of scrogson/scotty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing scrogson/scotty [INFO] finished frobbing scrogson/scotty [INFO] frobbed toml for scrogson/scotty written to work/ex/clippy-test-run/sources/stable/gh/scrogson/scotty/Cargo.toml [INFO] started frobbing scrogson/scotty [INFO] finished frobbing scrogson/scotty [INFO] frobbed toml for scrogson/scotty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scrogson/scotty/Cargo.toml [INFO] crate scrogson/scotty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting scrogson/scotty against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scrogson/scotty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf0ce80a96dc8eaa4eefb9e415fe378d8a6e247a1e09d6e390b58650ad615995 [INFO] running `"docker" "start" "-a" "bf0ce80a96dc8eaa4eefb9e415fe378d8a6e247a1e09d6e390b58650ad615995"` [INFO] [stderr] Checking byteorder v0.3.13 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking scotty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | right: right [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/emitter.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | right: right [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | let val = Term::Integer(code[pc] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(code[pc])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Self { [INFO] [stderr] 9 | | VM { [INFO] [stderr] 10 | | [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/vm/mod.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/interpreter.rs:41:41 [INFO] [stderr] | [INFO] [stderr] 41 | let val = Term::Integer(code[pc] as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i64::from(code[pc])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `vm::VM` [INFO] [stderr] --> src/vm/mod.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | / pub fn new() -> Self { [INFO] [stderr] 9 | | VM { [INFO] [stderr] 10 | | [INFO] [stderr] 11 | | } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/vm/mod.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.19s [INFO] running `"docker" "inspect" "bf0ce80a96dc8eaa4eefb9e415fe378d8a6e247a1e09d6e390b58650ad615995"` [INFO] running `"docker" "rm" "-f" "bf0ce80a96dc8eaa4eefb9e415fe378d8a6e247a1e09d6e390b58650ad615995"` [INFO] [stdout] bf0ce80a96dc8eaa4eefb9e415fe378d8a6e247a1e09d6e390b58650ad615995