[INFO] updating cached repository scoin/rust-poker
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/scoin/rust-poker
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/scoin/rust-poker" "work/ex/clippy-test-run/sources/stable/gh/scoin/rust-poker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/scoin/rust-poker'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/scoin/rust-poker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scoin/rust-poker"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scoin/rust-poker'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 6ba4828bc349e7562ff1f077e352db4d197c493a
[INFO] sha for GitHub repo scoin/rust-poker: 6ba4828bc349e7562ff1f077e352db4d197c493a
[INFO] validating manifest of scoin/rust-poker on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of scoin/rust-poker on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing scoin/rust-poker
[INFO] finished frobbing scoin/rust-poker
[INFO] frobbed toml for scoin/rust-poker written to work/ex/clippy-test-run/sources/stable/gh/scoin/rust-poker/Cargo.toml
[INFO] started frobbing scoin/rust-poker
[INFO] finished frobbing scoin/rust-poker
[INFO] frobbed toml for scoin/rust-poker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scoin/rust-poker/Cargo.toml
[INFO] crate scoin/rust-poker has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting scoin/rust-poker against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/scoin/rust-poker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1ac4e97363f51543182f316b3db8ca6e2de8124024714968aecf8d7f1c178c08
[INFO] running `"docker" "start" "-a" "1ac4e97363f51543182f316b3db8ca6e2de8124024714968aecf8d7f1c178c08"`
[INFO] [stderr]     Checking rand_core v0.1.0
[INFO] [stderr]     Checking rand v0.5.0-pre.1
[INFO] [stderr]     Checking poker v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/deck/card.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |     pub fn value(&self) -> i8 {
[INFO] [stderr]   |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |                 if pair.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pair.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:107:50
[INFO] [stderr]     |
[INFO] [stderr] 107 |             if cards[i].rank == cards[j].rank && pair.len() == 0 {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pair.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:112:23
[INFO] [stderr]     |
[INFO] [stderr] 112 |             } else if pair.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pair.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:154:60
[INFO] [stderr]     |
[INFO] [stderr] 154 |             if cards[i].value() - cards[j].value() == 1 && result.len() == 0{
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:184:50
[INFO] [stderr]     |
[INFO] [stderr] 184 |             if cards[i].suit == cards[j].suit && result.len() == 0 {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/deck/mod.rs:14:14
[INFO] [stderr]    |
[INFO] [stderr] 14 |     for r in vec!['A','2','3','4','5','6','7','8','9','T','J','Q','K'] {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&['A','2','3','4','5','6','7','8','9','T','J','Q','K']`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/deck/mod.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for s in vec!['S', 'C', 'D', 'H'] {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&['S', 'C', 'D', 'H']`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]  --> src/deck/card.rs:8:18
[INFO] [stderr]   |
[INFO] [stderr] 8 |     pub fn value(&self) -> i8 {
[INFO] [stderr]   |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:102:20
[INFO] [stderr]     |
[INFO] [stderr] 102 |                 if pair.len() > 0 {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pair.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:107:50
[INFO] [stderr]     |
[INFO] [stderr] 107 |             if cards[i].rank == cards[j].rank && pair.len() == 0 {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `pair.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:112:23
[INFO] [stderr]     |
[INFO] [stderr] 112 |             } else if pair.len() > 0 {
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pair.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:154:60
[INFO] [stderr]     |
[INFO] [stderr] 154 |             if cards[i].value() - cards[j].value() == 1 && result.len() == 0{
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deck/hand.rs:184:50
[INFO] [stderr]     |
[INFO] [stderr] 184 |             if cards[i].suit == cards[j].suit && result.len() == 0 {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `result.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/deck/mod.rs:14:14
[INFO] [stderr]    |
[INFO] [stderr] 14 |     for r in vec!['A','2','3','4','5','6','7','8','9','T','J','Q','K'] {
[INFO] [stderr]    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&['A','2','3','4','5','6','7','8','9','T','J','Q','K']`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_vec)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `vec!`
[INFO] [stderr]   --> src/deck/mod.rs:15:18
[INFO] [stderr]    |
[INFO] [stderr] 15 |         for s in vec!['S', 'C', 'D', 'H'] {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&['S', 'C', 'D', 'H']`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.48s
[INFO] running `"docker" "inspect" "1ac4e97363f51543182f316b3db8ca6e2de8124024714968aecf8d7f1c178c08"`
[INFO] running `"docker" "rm" "-f" "1ac4e97363f51543182f316b3db8ca6e2de8124024714968aecf8d7f1c178c08"`
[INFO] [stdout] 1ac4e97363f51543182f316b3db8ca6e2de8124024714968aecf8d7f1c178c08