[INFO] updating cached repository sbwtw/LicenseManager
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sbwtw/LicenseManager
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sbwtw/LicenseManager" "work/ex/clippy-test-run/sources/stable/gh/sbwtw/LicenseManager"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sbwtw/LicenseManager'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sbwtw/LicenseManager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/LicenseManager"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/LicenseManager'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2cdcdb5c0ba9cfc17c3fa60cf7dbf5f0fcbbaa1f
[INFO] sha for GitHub repo sbwtw/LicenseManager: 2cdcdb5c0ba9cfc17c3fa60cf7dbf5f0fcbbaa1f
[INFO] validating manifest of sbwtw/LicenseManager on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sbwtw/LicenseManager on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sbwtw/LicenseManager
[INFO] finished frobbing sbwtw/LicenseManager
[INFO] frobbed toml for sbwtw/LicenseManager written to work/ex/clippy-test-run/sources/stable/gh/sbwtw/LicenseManager/Cargo.toml
[INFO] started frobbing sbwtw/LicenseManager
[INFO] finished frobbing sbwtw/LicenseManager
[INFO] frobbed toml for sbwtw/LicenseManager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/LicenseManager/Cargo.toml
[INFO] crate sbwtw/LicenseManager has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sbwtw/LicenseManager against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sbwtw/LicenseManager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2e10f75dd26210247996a652093069da8ff9eb80be3387afc526e899d374a688
[INFO] running `"docker" "start" "-a" "2e10f75dd26210247996a652093069da8ff9eb80be3387afc526e899d374a688"`
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking textwrap v0.7.0
[INFO] [stderr]     Checking clap v2.26.0
[INFO] [stderr]     Checking license_manager v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         f
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 |           let f = Filter {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 24 | |             base_dir: path.to_owned(),
[INFO] [stderr] 25 | |             entry_iter: None,
[INFO] [stderr] 26 | |             search_dirs: vec![path.to_owned()],
[INFO] [stderr] 27 | |             ignore_dirs: vec![],
[INFO] [stderr] 28 | |             match_exts: vec![],
[INFO] [stderr] 29 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         f
[INFO] [stderr]    |         ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:23:17
[INFO] [stderr]    |
[INFO] [stderr] 23 |           let f = Filter {
[INFO] [stderr]    |  _________________^
[INFO] [stderr] 24 | |             base_dir: path.to_owned(),
[INFO] [stderr] 25 | |             entry_iter: None,
[INFO] [stderr] 26 | |             search_dirs: vec![path.to_owned()],
[INFO] [stderr] 27 | |             ignore_dirs: vec![],
[INFO] [stderr] 28 | |             match_exts: vec![],
[INFO] [stderr] 29 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:36
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn ignore(mut self, paths: &Vec<&str>) -> Self {
[INFO] [stderr]    |                                    ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:43:44
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn extension(mut self, extensions: &Vec<&str>) -> Self {
[INFO] [stderr]    |                                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `scaned_lines` is used as a loop counter. Consider using `for (scaned_lines, item) in rdr.lines().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:127:21
[INFO] [stderr]     |
[INFO] [stderr] 127 |         for line in rdr.lines() {
[INFO] [stderr]     |                     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |     while let Some(f) = f.next() {
[INFO] [stderr]     |                         ^^^^^^^^ help: try: `for f in f { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:34:36
[INFO] [stderr]    |
[INFO] [stderr] 34 |     pub fn ignore(mut self, paths: &Vec<&str>) -> Self {
[INFO] [stderr]    |                                    ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:43:44
[INFO] [stderr]    |
[INFO] [stderr] 43 |     pub fn extension(mut self, extensions: &Vec<&str>) -> Self {
[INFO] [stderr]    |                                            ^^^^^^^^^^ help: change this to: `&[&str]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `scaned_lines` is used as a loop counter. Consider using `for (scaned_lines, item) in rdr.lines().enumerate()` or similar iterators
[INFO] [stderr]    --> src/main.rs:127:21
[INFO] [stderr]     |
[INFO] [stderr] 127 |         for line in rdr.lines() {
[INFO] [stderr]     |                     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/main.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |     while let Some(f) = f.next() {
[INFO] [stderr]     |                         ^^^^^^^^ help: try: `for f in f { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.11s
[INFO] running `"docker" "inspect" "2e10f75dd26210247996a652093069da8ff9eb80be3387afc526e899d374a688"`
[INFO] running `"docker" "rm" "-f" "2e10f75dd26210247996a652093069da8ff9eb80be3387afc526e899d374a688"`
[INFO] [stdout] 2e10f75dd26210247996a652093069da8ff9eb80be3387afc526e899d374a688