[INFO] updating cached repository savish/rcomm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/savish/rcomm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/savish/rcomm" "work/ex/clippy-test-run/sources/stable/gh/savish/rcomm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/savish/rcomm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/savish/rcomm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/savish/rcomm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/savish/rcomm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f869288f07f761d2b7161c23b8a1cd8886df6bd [INFO] sha for GitHub repo savish/rcomm: 7f869288f07f761d2b7161c23b8a1cd8886df6bd [INFO] validating manifest of savish/rcomm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of savish/rcomm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing savish/rcomm [INFO] finished frobbing savish/rcomm [INFO] frobbed toml for savish/rcomm written to work/ex/clippy-test-run/sources/stable/gh/savish/rcomm/Cargo.toml [INFO] started frobbing savish/rcomm [INFO] finished frobbing savish/rcomm [INFO] frobbed toml for savish/rcomm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/savish/rcomm/Cargo.toml [INFO] crate savish/rcomm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting savish/rcomm against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/savish/rcomm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89d4647e1bf72893daa2f2637168bd6849ba7d13bf8fe9796ff9660889ae28fd [INFO] running `"docker" "start" "-a" "89d4647e1bf72893daa2f2637168bd6849ba7d13bf8fe9796ff9660889ae28fd"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking rcomm v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | let advance1 = match ignore_case { [INFO] [stderr] | ________________________^ [INFO] [stderr] 94 | | true => line1_string.to_lowercase() < line2_string.to_lowercase(), [INFO] [stderr] 95 | | false => line1_string < line2_string, [INFO] [stderr] 96 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ignore_case { line1_string.to_lowercase() < line2_string.to_lowercase() } else { line1_string < line2_string }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | let advance2 = match ignore_case { [INFO] [stderr] | ________________________^ [INFO] [stderr] 99 | | true => line2_string.to_lowercase() < line1_string.to_lowercase(), [INFO] [stderr] 100 | | false => line2_string < line1_string, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ignore_case { line2_string.to_lowercase() < line1_string.to_lowercase() } else { line2_string < line1_string }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:93:24 [INFO] [stderr] | [INFO] [stderr] 93 | let advance1 = match ignore_case { [INFO] [stderr] | ________________________^ [INFO] [stderr] 94 | | true => line1_string.to_lowercase() < line2_string.to_lowercase(), [INFO] [stderr] 95 | | false => line1_string < line2_string, [INFO] [stderr] 96 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ignore_case { line1_string.to_lowercase() < line2_string.to_lowercase() } else { line1_string < line2_string }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:98:24 [INFO] [stderr] | [INFO] [stderr] 98 | let advance2 = match ignore_case { [INFO] [stderr] | ________________________^ [INFO] [stderr] 99 | | true => line2_string.to_lowercase() < line1_string.to_lowercase(), [INFO] [stderr] 100 | | false => line2_string < line1_string, [INFO] [stderr] 101 | | }; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if ignore_case { line2_string.to_lowercase() < line1_string.to_lowercase() } else { line2_string < line1_string }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.77s [INFO] running `"docker" "inspect" "89d4647e1bf72893daa2f2637168bd6849ba7d13bf8fe9796ff9660889ae28fd"` [INFO] running `"docker" "rm" "-f" "89d4647e1bf72893daa2f2637168bd6849ba7d13bf8fe9796ff9660889ae28fd"` [INFO] [stdout] 89d4647e1bf72893daa2f2637168bd6849ba7d13bf8fe9796ff9660889ae28fd