[INFO] updating cached repository saterus/gilded-rose-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/saterus/gilded-rose-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/saterus/gilded-rose-rust" "work/ex/clippy-test-run/sources/stable/gh/saterus/gilded-rose-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saterus/gilded-rose-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/saterus/gilded-rose-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saterus/gilded-rose-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saterus/gilded-rose-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8a8ec0b54b71eb6cfc764dda770b60843d95b73e
[INFO] sha for GitHub repo saterus/gilded-rose-rust: 8a8ec0b54b71eb6cfc764dda770b60843d95b73e
[INFO] validating manifest of saterus/gilded-rose-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of saterus/gilded-rose-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing saterus/gilded-rose-rust
[INFO] finished frobbing saterus/gilded-rose-rust
[INFO] frobbed toml for saterus/gilded-rose-rust written to work/ex/clippy-test-run/sources/stable/gh/saterus/gilded-rose-rust/Cargo.toml
[INFO] started frobbing saterus/gilded-rose-rust
[INFO] finished frobbing saterus/gilded-rose-rust
[INFO] frobbed toml for saterus/gilded-rose-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saterus/gilded-rose-rust/Cargo.toml
[INFO] crate saterus/gilded-rose-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting saterus/gilded-rose-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saterus/gilded-rose-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] fdb305336e539dcd2a581d196f9cf6abff888c554d261ed71a21c46c50b1c6da
[INFO] running `"docker" "start" "-a" "fdb305336e539dcd2a581d196f9cf6abff888c554d261ed71a21c46c50b1c6da"`
[INFO] [stderr]     Checking gilded_rose v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:32:12
[INFO] [stderr]    |
[INFO] [stderr] 32 |         if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         {
[INFO] [stderr] 44 | |             if (items[i].quality < 50)
[INFO] [stderr] 45 | |             {
[INFO] [stderr] 46 | |                 items[i].quality = items[i].quality + 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |             }
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if (items[i].quality < 50)
[INFO] [stderr] 44 | {
[INFO] [stderr] 45 |     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 46 | 
[INFO] [stderr] 47 |     if (items[i].name == "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr] 48 |     {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:34:16
[INFO] [stderr]    |
[INFO] [stderr] 34 |             if (items[i].quality > 0)
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 | /             if (items[i].quality > 0)
[INFO] [stderr] 35 | |             {
[INFO] [stderr] 36 | |                 if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr] 37 | |                 {
[INFO] [stderr] 38 | |                     items[i].quality = items[i].quality - 1;
[INFO] [stderr] 39 | |                 }
[INFO] [stderr] 40 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 34 |             if (items[i].quality > 0) && (items[i].name != "Sulfuras, Hand of Ragnaros") {
[INFO] [stderr] 35 |     items[i].quality = items[i].quality - 1;
[INFO] [stderr] 36 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:36:20
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:44:16
[INFO] [stderr]    |
[INFO] [stderr] 44 |             if (items[i].quality < 50)
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:48:20
[INFO] [stderr]    |
[INFO] [stderr] 48 |                 if (items[i].name == "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:50:24
[INFO] [stderr]    |
[INFO] [stderr] 50 |                     if (items[i].sell_in < 11)
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 | /                     if (items[i].sell_in < 11)
[INFO] [stderr] 51 | |                     {
[INFO] [stderr] 52 | |                         if (items[i].quality < 50)
[INFO] [stderr] 53 | |                         {
[INFO] [stderr] 54 | |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr] 55 | |                         }
[INFO] [stderr] 56 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |                     if (items[i].sell_in < 11) && (items[i].quality < 50) {
[INFO] [stderr] 51 |     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |                         if (items[i].quality < 50)
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if (items[i].sell_in < 6)
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 | /                     if (items[i].sell_in < 6)
[INFO] [stderr] 59 | |                     {
[INFO] [stderr] 60 | |                         if (items[i].quality < 50)
[INFO] [stderr] 61 | |                         {
[INFO] [stderr] 62 | |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr] 63 | |                         }
[INFO] [stderr] 64 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if (items[i].sell_in < 6) && (items[i].quality < 50) {
[INFO] [stderr] 59 |     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 60 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:60:28
[INFO] [stderr]    |
[INFO] [stderr] 60 |                         if (items[i].quality < 50)
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:69:12
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:74:12
[INFO] [stderr]    |
[INFO] [stderr] 74 |         if (items[i].sell_in < 0)
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:76:16
[INFO] [stderr]    |
[INFO] [stderr] 76 |             if (items[i].name != "Aged Brie")
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 | /             {
[INFO] [stderr] 95 | |                 if (items[i].quality < 50)
[INFO] [stderr] 96 | | {
[INFO] [stderr] 97 | |                     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 98 | |                 }
[INFO] [stderr] 99 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 94 |             if (items[i].quality < 50)
[INFO] [stderr] 95 | {
[INFO] [stderr] 96 |                     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 97 |                 }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:78:20
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 if (items[i].name != "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:80:24
[INFO] [stderr]    |
[INFO] [stderr] 80 |                     if (items[i].quality > 0)
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 | /                     if (items[i].quality > 0)
[INFO] [stderr] 81 | |                     {
[INFO] [stderr] 82 | |                         if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr] 83 | |                         {
[INFO] [stderr] 84 | |                             items[i].quality = items[i].quality - 1;
[INFO] [stderr] 85 | |                         }
[INFO] [stderr] 86 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 80 |                     if (items[i].quality > 0) && (items[i].name != "Sulfuras, Hand of Ragnaros") {
[INFO] [stderr] 81 |     items[i].quality = items[i].quality - 1;
[INFO] [stderr] 82 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:82:28
[INFO] [stderr]    |
[INFO] [stderr] 82 |                         if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:95:20
[INFO] [stderr]    |
[INFO] [stderr] 95 |                 if (items[i].quality < 50)
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:32:12
[INFO] [stderr]    |
[INFO] [stderr] 32 |         if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:43:9
[INFO] [stderr]    |
[INFO] [stderr] 43 | /         {
[INFO] [stderr] 44 | |             if (items[i].quality < 50)
[INFO] [stderr] 45 | |             {
[INFO] [stderr] 46 | |                 items[i].quality = items[i].quality + 1;
[INFO] [stderr] ...  |
[INFO] [stderr] 66 | |             }
[INFO] [stderr] 67 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 43 |         if (items[i].quality < 50)
[INFO] [stderr] 44 | {
[INFO] [stderr] 45 |     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 46 | 
[INFO] [stderr] 47 |     if (items[i].name == "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr] 48 |     {
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:34:16
[INFO] [stderr]    |
[INFO] [stderr] 34 |             if (items[i].quality > 0)
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:34:13
[INFO] [stderr]    |
[INFO] [stderr] 34 | /             if (items[i].quality > 0)
[INFO] [stderr] 35 | |             {
[INFO] [stderr] 36 | |                 if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr] 37 | |                 {
[INFO] [stderr] 38 | |                     items[i].quality = items[i].quality - 1;
[INFO] [stderr] 39 | |                 }
[INFO] [stderr] 40 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 34 |             if (items[i].quality > 0) && (items[i].name != "Sulfuras, Hand of Ragnaros") {
[INFO] [stderr] 35 |     items[i].quality = items[i].quality - 1;
[INFO] [stderr] 36 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:36:20
[INFO] [stderr]    |
[INFO] [stderr] 36 |                 if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:44:16
[INFO] [stderr]    |
[INFO] [stderr] 44 |             if (items[i].quality < 50)
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:48:20
[INFO] [stderr]    |
[INFO] [stderr] 48 |                 if (items[i].name == "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:50:24
[INFO] [stderr]    |
[INFO] [stderr] 50 |                     if (items[i].sell_in < 11)
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 | /                     if (items[i].sell_in < 11)
[INFO] [stderr] 51 | |                     {
[INFO] [stderr] 52 | |                         if (items[i].quality < 50)
[INFO] [stderr] 53 | |                         {
[INFO] [stderr] 54 | |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr] 55 | |                         }
[INFO] [stderr] 56 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 50 |                     if (items[i].sell_in < 11) && (items[i].quality < 50) {
[INFO] [stderr] 51 |     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 52 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:52:28
[INFO] [stderr]    |
[INFO] [stderr] 52 |                         if (items[i].quality < 50)
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:58:24
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if (items[i].sell_in < 6)
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:58:21
[INFO] [stderr]    |
[INFO] [stderr] 58 | /                     if (items[i].sell_in < 6)
[INFO] [stderr] 59 | |                     {
[INFO] [stderr] 60 | |                         if (items[i].quality < 50)
[INFO] [stderr] 61 | |                         {
[INFO] [stderr] 62 | |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr] 63 | |                         }
[INFO] [stderr] 64 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 58 |                     if (items[i].sell_in < 6) && (items[i].quality < 50) {
[INFO] [stderr] 59 |     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 60 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:60:28
[INFO] [stderr]    |
[INFO] [stderr] 60 |                         if (items[i].quality < 50)
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:69:12
[INFO] [stderr]    |
[INFO] [stderr] 69 |         if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:74:12
[INFO] [stderr]    |
[INFO] [stderr] 74 |         if (items[i].sell_in < 0)
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:76:16
[INFO] [stderr]    |
[INFO] [stderr] 76 |             if (items[i].name != "Aged Brie")
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/main.rs:94:13
[INFO] [stderr]    |
[INFO] [stderr] 94 | /             {
[INFO] [stderr] 95 | |                 if (items[i].quality < 50)
[INFO] [stderr] 96 | | {
[INFO] [stderr] 97 | |                     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 98 | |                 }
[INFO] [stderr] 99 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 94 |             if (items[i].quality < 50)
[INFO] [stderr] 95 | {
[INFO] [stderr] 96 |                     items[i].quality = items[i].quality + 1;
[INFO] [stderr] 97 |                 }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:78:20
[INFO] [stderr]    |
[INFO] [stderr] 78 |                 if (items[i].name != "Backstage passes to a TAFKAL80ETC concert")
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:80:24
[INFO] [stderr]    |
[INFO] [stderr] 80 |                     if (items[i].quality > 0)
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/main.rs:80:21
[INFO] [stderr]    |
[INFO] [stderr] 80 | /                     if (items[i].quality > 0)
[INFO] [stderr] 81 | |                     {
[INFO] [stderr] 82 | |                         if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr] 83 | |                         {
[INFO] [stderr] 84 | |                             items[i].quality = items[i].quality - 1;
[INFO] [stderr] 85 | |                         }
[INFO] [stderr] 86 | |                     }
[INFO] [stderr]    | |_____________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 80 |                     if (items[i].quality > 0) && (items[i].name != "Sulfuras, Hand of Ragnaros") {
[INFO] [stderr] 81 |     items[i].quality = items[i].quality - 1;
[INFO] [stderr] 82 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:82:28
[INFO] [stderr]    |
[INFO] [stderr] 82 |                         if (items[i].name != "Sulfuras, Hand of Ragnaros")
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]   --> src/main.rs:95:20
[INFO] [stderr]    |
[INFO] [stderr] 95 |                 if (items[i].quality < 50)
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality`
[INFO] [stderr]    --> src/main.rs:28:1
[INFO] [stderr]     |
[INFO] [stderr] 28  | / fn UpdateQuality(items: &mut [Item])
[INFO] [stderr] 29  | | {
[INFO] [stderr] 30  | |     for i in 0..items.len() 
[INFO] [stderr] 31  | |     {
[INFO] [stderr] ...   |
[INFO] [stderr] 101 | |     }
[INFO] [stderr] 102 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `items`.
[INFO] [stderr]   --> src/main.rs:30:14
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for i in 0..items.len() 
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for <item> in &mut items 
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     items[i].quality = items[i].quality - 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:46:17
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:54:29
[INFO] [stderr]    |
[INFO] [stderr] 54 |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:62:29
[INFO] [stderr]    |
[INFO] [stderr] 62 |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             items[i].sell_in = items[i].sell_in - 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].sell_in -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:84:29
[INFO] [stderr]    |
[INFO] [stderr] 84 |                             items[i].quality = items[i].quality - 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `-`
[INFO] [stderr]   --> src/main.rs:90:40
[INFO] [stderr]    |
[INFO] [stderr] 90 |                     items[i].quality = items[i].quality - items[i].quality;
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality`
[INFO] [stderr]    --> src/main.rs:28:1
[INFO] [stderr]     |
[INFO] [stderr] 28  | / fn UpdateQuality(items: &mut [Item])
[INFO] [stderr] 29  | | {
[INFO] [stderr] 30  | |     for i in 0..items.len() 
[INFO] [stderr] 31  | |     {
[INFO] [stderr] ...   |
[INFO] [stderr] 101 | |     }
[INFO] [stderr] 102 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:97:21
[INFO] [stderr]    |
[INFO] [stderr] 97 |                     items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `items`.
[INFO] [stderr]   --> src/main.rs:30:14
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for i in 0..items.len() 
[INFO] [stderr]    |              ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 30 |     for <item> in &mut items 
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:38:21
[INFO] [stderr]    |
[INFO] [stderr] 38 |                     items[i].quality = items[i].quality - 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:46:17
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:54:29
[INFO] [stderr]    |
[INFO] [stderr] 54 |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:62:29
[INFO] [stderr]    |
[INFO] [stderr] 62 |                             items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:71:13
[INFO] [stderr]    |
[INFO] [stderr] 71 |             items[i].sell_in = items[i].sell_in - 1;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].sell_in -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:84:29
[INFO] [stderr]    |
[INFO] [stderr] 84 |                             items[i].quality = items[i].quality - 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: equal expressions as operands to `-`
[INFO] [stderr]   --> src/main.rs:90:40
[INFO] [stderr]    |
[INFO] [stderr] 90 |                     items[i].quality = items[i].quality - items[i].quality;
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::eq_op)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:97:21
[INFO] [stderr]    |
[INFO] [stderr] 97 |                     items[i].quality = items[i].quality + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `items[i].quality += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `gilded_rose`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: Could not compile `gilded_rose`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "fdb305336e539dcd2a581d196f9cf6abff888c554d261ed71a21c46c50b1c6da"`
[INFO] running `"docker" "rm" "-f" "fdb305336e539dcd2a581d196f9cf6abff888c554d261ed71a21c46c50b1c6da"`
[INFO] [stdout] fdb305336e539dcd2a581d196f9cf6abff888c554d261ed71a21c46c50b1c6da