[INFO] updating cached repository sapphirecat/advent2017-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sapphirecat/advent2017-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sapphirecat/advent2017-rs" "work/ex/clippy-test-run/sources/stable/gh/sapphirecat/advent2017-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sapphirecat/advent2017-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sapphirecat/advent2017-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sapphirecat/advent2017-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sapphirecat/advent2017-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c8fc7cc0947d3e47d3ba9eeb12933e02c7d28d83 [INFO] sha for GitHub repo sapphirecat/advent2017-rs: c8fc7cc0947d3e47d3ba9eeb12933e02c7d28d83 [INFO] validating manifest of sapphirecat/advent2017-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sapphirecat/advent2017-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sapphirecat/advent2017-rs [INFO] finished frobbing sapphirecat/advent2017-rs [INFO] frobbed toml for sapphirecat/advent2017-rs written to work/ex/clippy-test-run/sources/stable/gh/sapphirecat/advent2017-rs/Cargo.toml [INFO] started frobbing sapphirecat/advent2017-rs [INFO] finished frobbing sapphirecat/advent2017-rs [INFO] frobbed toml for sapphirecat/advent2017-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sapphirecat/advent2017-rs/Cargo.toml [INFO] crate sapphirecat/advent2017-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sapphirecat/advent2017-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sapphirecat/advent2017-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d29a8cc7147b29d29524153bbbb414092b698679c213a1301e6eaa276599b817 [INFO] running `"docker" "start" "-a" "d29a8cc7147b29d29524153bbbb414092b698679c213a1301e6eaa276599b817"` [INFO] [stderr] Checking libc v0.2.34 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking advent2017-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | println!("{}", "In the beginning was the NULL, and it was without form, and void*."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | println!("{}", "In the beginning was the NULL, and it was without form, and void*."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `cells`. [INFO] [stderr] --> src/main.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | for j in i..cells.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 171 | for in cells.iter().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:322:85 [INFO] [stderr] | [INFO] [stderr] 322 | } else if offset > 0 && (magnitude > max_head || (max_head - magnitude) < head) { [INFO] [stderr] | _____________________________________________________________________________________^ [INFO] [stderr] 323 | | None // exited right of tape [INFO] [stderr] 324 | | } else if offset >= 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:320:39 [INFO] [stderr] | [INFO] [stderr] 320 | if offset < 0 && magnitude > head { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 321 | | None // exited left of tape [INFO] [stderr] 322 | | } else if offset > 0 && (magnitude > max_head || (max_head - magnitude) < head) { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:377:8 [INFO] [stderr] | [INFO] [stderr] 377 | if tape.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tape.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:390:24 [INFO] [stderr] | [INFO] [stderr] 390 | fn day6_hash_state (v: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `cells`. [INFO] [stderr] --> src/main.rs:171:22 [INFO] [stderr] | [INFO] [stderr] 171 | for j in i..cells.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 171 | for in cells.iter().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent2017-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:322:85 [INFO] [stderr] | [INFO] [stderr] 322 | } else if offset > 0 && (magnitude > max_head || (max_head - magnitude) < head) { [INFO] [stderr] | _____________________________________________________________________________________^ [INFO] [stderr] 323 | | None // exited right of tape [INFO] [stderr] 324 | | } else if offset >= 0 { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:320:39 [INFO] [stderr] | [INFO] [stderr] 320 | if offset < 0 && magnitude > head { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 321 | | None // exited left of tape [INFO] [stderr] 322 | | } else if offset > 0 && (magnitude > max_head || (max_head - magnitude) < head) { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:377:8 [INFO] [stderr] | [INFO] [stderr] 377 | if tape.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tape.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:390:24 [INFO] [stderr] | [INFO] [stderr] 390 | fn day6_hash_state (v: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `advent2017-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d29a8cc7147b29d29524153bbbb414092b698679c213a1301e6eaa276599b817"` [INFO] running `"docker" "rm" "-f" "d29a8cc7147b29d29524153bbbb414092b698679c213a1301e6eaa276599b817"` [INFO] [stdout] d29a8cc7147b29d29524153bbbb414092b698679c213a1301e6eaa276599b817