[INFO] updating cached repository samphippen/expector [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samphippen/expector [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samphippen/expector" "work/ex/clippy-test-run/sources/stable/gh/samphippen/expector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samphippen/expector'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samphippen/expector" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samphippen/expector"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samphippen/expector'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1a365395f51adeda5bdbcc0b35d67f47b94c94f2 [INFO] sha for GitHub repo samphippen/expector: 1a365395f51adeda5bdbcc0b35d67f47b94c94f2 [INFO] validating manifest of samphippen/expector on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samphippen/expector on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samphippen/expector [INFO] finished frobbing samphippen/expector [INFO] frobbed toml for samphippen/expector written to work/ex/clippy-test-run/sources/stable/gh/samphippen/expector/Cargo.toml [INFO] started frobbing samphippen/expector [INFO] finished frobbing samphippen/expector [INFO] frobbed toml for samphippen/expector written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samphippen/expector/Cargo.toml [INFO] crate samphippen/expector has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samphippen/expector against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samphippen/expector:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fecfe35f82049aff740f39a7687d6f2a4cb5ea164d01ba387087bee0b7782b9 [INFO] running `"docker" "start" "-a" "8fecfe35f82049aff740f39a7687d6f2a4cb5ea164d01ba387087bee0b7782b9"` [INFO] [stderr] Checking expector v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/prelude.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | EqualityMatcher { expected: expected } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prelude.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | ExpectationTarget { target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/prelude.rs:4:23 [INFO] [stderr] | [INFO] [stderr] 4 | EqualityMatcher { expected: expected } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `expected` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prelude.rs:5:25 [INFO] [stderr] | [INFO] [stderr] 5 | ExpectationTarget { target: target } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/matchers/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | target.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/matchers/mod.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | target.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `target.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.08s [INFO] running `"docker" "inspect" "8fecfe35f82049aff740f39a7687d6f2a4cb5ea164d01ba387087bee0b7782b9"` [INFO] running `"docker" "rm" "-f" "8fecfe35f82049aff740f39a7687d6f2a4cb5ea164d01ba387087bee0b7782b9"` [INFO] [stdout] 8fecfe35f82049aff740f39a7687d6f2a4cb5ea164d01ba387087bee0b7782b9