[INFO] updating cached repository samlittlewood/rustrace [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/samlittlewood/rustrace [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/samlittlewood/rustrace" "work/ex/clippy-test-run/sources/stable/gh/samlittlewood/rustrace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/samlittlewood/rustrace'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/samlittlewood/rustrace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samlittlewood/rustrace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samlittlewood/rustrace'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4c24aae583c9278a43870994df8eeaad461ec3d3 [INFO] sha for GitHub repo samlittlewood/rustrace: 4c24aae583c9278a43870994df8eeaad461ec3d3 [INFO] validating manifest of samlittlewood/rustrace on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of samlittlewood/rustrace on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing samlittlewood/rustrace [INFO] finished frobbing samlittlewood/rustrace [INFO] frobbed toml for samlittlewood/rustrace written to work/ex/clippy-test-run/sources/stable/gh/samlittlewood/rustrace/Cargo.toml [INFO] started frobbing samlittlewood/rustrace [INFO] finished frobbing samlittlewood/rustrace [INFO] frobbed toml for samlittlewood/rustrace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samlittlewood/rustrace/Cargo.toml [INFO] crate samlittlewood/rustrace has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting samlittlewood/rustrace against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/samlittlewood/rustrace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a68bad8c80cb82f10b976aa4910a4e591826bcb7bbabb19286454a4253d12c8 [INFO] running `"docker" "start" "-a" "5a68bad8c80cb82f10b976aa4910a4e591826bcb7bbabb19286454a4253d12c8"` [INFO] [stderr] Checking rustrace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | u: u, v: v, _w: w, [INFO] [stderr] | ^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | u: u, v: v, _w: w, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/hitable.rs:37:21 [INFO] [stderr] | [INFO] [stderr] 37 | let p = r.point_at_parameter(temp); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | u: u, v: v, _w: w, [INFO] [stderr] | ^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | u: u, v: v, _w: w, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/material.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | pub m: &'a Box [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/material.rs:14:49 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(nt: f32, np: Vec3, nn: Vec3, mm: &'a Box) -> Hit<'a> { Hit { t:nt, p:np, n:nn, m:mm } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/hitable.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match h.hit(r, t_min, closest_so_far) { [INFO] [stderr] 62 | | Some(rec) => { [INFO] [stderr] 63 | | closest_so_far = rec.t; [INFO] [stderr] 64 | | temp_rec = Some(rec); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Some(rec) = h.hit(r, t_min, closest_so_far) { [INFO] [stderr] 62 | closest_so_far = rec.t; [INFO] [stderr] 63 | temp_rec = Some(rec); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | file.write(&ia).expect("can't write"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustrace`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/material.rs:10:12 [INFO] [stderr] | [INFO] [stderr] 10 | pub m: &'a Box [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/material.rs:14:49 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn new(nt: f32, np: Vec3, nn: Vec3, mm: &'a Box) -> Hit<'a> { Hit { t:nt, p:np, n:nn, m:mm } } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&'a Material` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/hitable.rs:61:13 [INFO] [stderr] | [INFO] [stderr] 61 | / match h.hit(r, t_min, closest_so_far) { [INFO] [stderr] 62 | | Some(rec) => { [INFO] [stderr] 63 | | closest_so_far = rec.t; [INFO] [stderr] 64 | | temp_rec = Some(rec); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let Some(rec) = h.hit(r, t_min, closest_so_far) { [INFO] [stderr] 62 | closest_so_far = rec.t; [INFO] [stderr] 63 | temp_rec = Some(rec); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | file.write(&ia).expect("can't write"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rustrace`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5a68bad8c80cb82f10b976aa4910a4e591826bcb7bbabb19286454a4253d12c8"` [INFO] running `"docker" "rm" "-f" "5a68bad8c80cb82f10b976aa4910a4e591826bcb7bbabb19286454a4253d12c8"` [INFO] [stdout] 5a68bad8c80cb82f10b976aa4910a4e591826bcb7bbabb19286454a4253d12c8