[INFO] updating cached repository saik0/rust_boggle_solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saik0/rust_boggle_solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saik0/rust_boggle_solver" "work/ex/clippy-test-run/sources/stable/gh/saik0/rust_boggle_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saik0/rust_boggle_solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saik0/rust_boggle_solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saik0/rust_boggle_solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saik0/rust_boggle_solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5d4602cdfe585c83c836f045adc675e23f9a6e37 [INFO] sha for GitHub repo saik0/rust_boggle_solver: 5d4602cdfe585c83c836f045adc675e23f9a6e37 [INFO] validating manifest of saik0/rust_boggle_solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saik0/rust_boggle_solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saik0/rust_boggle_solver [INFO] finished frobbing saik0/rust_boggle_solver [INFO] frobbed toml for saik0/rust_boggle_solver written to work/ex/clippy-test-run/sources/stable/gh/saik0/rust_boggle_solver/Cargo.toml [INFO] started frobbing saik0/rust_boggle_solver [INFO] finished frobbing saik0/rust_boggle_solver [INFO] frobbed toml for saik0/rust_boggle_solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saik0/rust_boggle_solver/Cargo.toml [INFO] crate saik0/rust_boggle_solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting saik0/rust_boggle_solver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saik0/rust_boggle_solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cdd0d7e670ebd212bedb29624753f07ba67ad415a73d4de69bda6d20cb9ba37 [INFO] running `"docker" "start" "-a" "7cdd0d7e670ebd212bedb29624753f07ba67ad415a73d4de69bda6d20cb9ba37"` [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num_cpus v1.3.0 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking rust_boggle_solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset_32.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset_32.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | trie: trie, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `trie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/radix_board.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/radix_board.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/radix_board.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset_32.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bitset/bitset_32.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | bitset: bitset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | trie: trie, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `trie` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:79:21 [INFO] [stderr] | [INFO] [stderr] 79 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/simple_board.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/radix_board.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/radix_board.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/boggle/radix_board.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | alpha: alpha, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/bitset/mod.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | mod bitset; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | const TWO_POW_64: u64 = 0x8000000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | const MAX: u64 = 0xFFFFFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | self.value |= 0x80000000>>i [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | self.value &= !(0x80000000>>i) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | self.value & 0x80000000>>i > 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:147:45 [INFO] [stderr] | [INFO] [stderr] 147 | let value = self.bitset.value & 0xFFFFFFFF>>i; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/trie.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | fn ins(&mut self, s: &[u8], id: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/boggle/simple_board.rs:94:58 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn set(&mut self, i: usize, v: SimpleBoggleCell) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | const FLAG_NORTHWEST : u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | const FLAG_NORTH : u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | const FLAG_NORTHEAST : u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | const FLAG_WEST : u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | const FLAG_EAST : u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | const FLAG_SOUTHWEST : u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | const FLAG_SOUTH : u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | const FLAG_SOUTHEAST : u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:212:33 [INFO] [stderr] | [INFO] [stderr] 212 | 0 => { self.value &=0b01111111; Some(self.idx - self.width - 1) } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:213:33 [INFO] [stderr] | [INFO] [stderr] 213 | 1 => { self.value &=0b00111111; Some(self.idx - self.width ) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:214:33 [INFO] [stderr] | [INFO] [stderr] 214 | 2 => { self.value &=0b00011111; Some(self.idx - self.width + 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:215:33 [INFO] [stderr] | [INFO] [stderr] 215 | 3 => { self.value &=0b00001111; Some(self.idx - 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:216:33 [INFO] [stderr] | [INFO] [stderr] 216 | 4 => { self.value &=0b00000111; Some(self.idx + 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:217:33 [INFO] [stderr] | [INFO] [stderr] 217 | 5 => { self.value &=0b00000011; Some(self.idx + self.width - 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:218:33 [INFO] [stderr] | [INFO] [stderr] 218 | 6 => { self.value &=0b00000001; Some(self.idx + self.width ) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:219:33 [INFO] [stderr] | [INFO] [stderr] 219 | 7 => { self.value =0b00000000; Some(self.idx + self.width + 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/bitset/mod.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | mod bitset; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | const TWO_POW_64: u64 = 0x8000000000000000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x8000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset.rs:29:25 [INFO] [stderr] | [INFO] [stderr] 29 | const MAX: u64 = 0xFFFFFFFFFFFFFFFF; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xFFFF_FFFF_FFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:47:23 [INFO] [stderr] | [INFO] [stderr] 47 | self.value |= 0x80000000>>i [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:52:25 [INFO] [stderr] | [INFO] [stderr] 52 | self.value &= !(0x80000000>>i) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:70:22 [INFO] [stderr] | [INFO] [stderr] 70 | self.value & 0x80000000>>i > 0 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bitset/bitset_32.rs:147:45 [INFO] [stderr] | [INFO] [stderr] 147 | let value = self.bitset.value & 0xFFFFFFFF>>i; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/trie.rs:77:44 [INFO] [stderr] | [INFO] [stderr] 77 | fn ins(&mut self, s: &[u8], id: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/boggle/simple_board.rs:94:58 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn set(&mut self, i: usize, v: SimpleBoggleCell) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | const FLAG_NORTHWEST : u8 = 0b10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | const FLAG_NORTH : u8 = 0b01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:38:30 [INFO] [stderr] | [INFO] [stderr] 38 | const FLAG_NORTHEAST : u8 = 0b00100000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | const FLAG_WEST : u8 = 0b00010000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:40:30 [INFO] [stderr] | [INFO] [stderr] 40 | const FLAG_EAST : u8 = 0b00001000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:41:30 [INFO] [stderr] | [INFO] [stderr] 41 | const FLAG_SOUTHWEST : u8 = 0b00000100; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:42:30 [INFO] [stderr] | [INFO] [stderr] 42 | const FLAG_SOUTH : u8 = 0b00000010; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:43:30 [INFO] [stderr] | [INFO] [stderr] 43 | const FLAG_SOUTHEAST : u8 = 0b00000001; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:212:33 [INFO] [stderr] | [INFO] [stderr] 212 | 0 => { self.value &=0b01111111; Some(self.idx - self.width - 1) } [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:213:33 [INFO] [stderr] | [INFO] [stderr] 213 | 1 => { self.value &=0b00111111; Some(self.idx - self.width ) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:214:33 [INFO] [stderr] | [INFO] [stderr] 214 | 2 => { self.value &=0b00011111; Some(self.idx - self.width + 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:215:33 [INFO] [stderr] | [INFO] [stderr] 215 | 3 => { self.value &=0b00001111; Some(self.idx - 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:216:33 [INFO] [stderr] | [INFO] [stderr] 216 | 4 => { self.value &=0b00000111; Some(self.idx + 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:217:33 [INFO] [stderr] | [INFO] [stderr] 217 | 5 => { self.value &=0b00000011; Some(self.idx + self.width - 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:218:33 [INFO] [stderr] | [INFO] [stderr] 218 | 6 => { self.value &=0b00000001; Some(self.idx + self.width ) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/boggle/radix_board.rs:219:33 [INFO] [stderr] | [INFO] [stderr] 219 | 7 => { self.value =0b00000000; Some(self.idx + self.width + 1) }, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boggle_util.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | (b - 'a' as u8) as usize [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | let ref data = self.data; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let data = &self.data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let ref mut data = self.data; [INFO] [stderr] | ----^^^^^^^^^^^^------------- help: try: `let data = &mut self.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | let ref mut data = self.data; [INFO] [stderr] | ----^^^^^^^^^^^^------------- help: try: `let data = &mut self.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let ref mut data = self.data; [INFO] [stderr] | ----^^^^^^^^^^^^------------- help: try: `let data = &mut self.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | let ref data = self.bitset.data; [INFO] [stderr] | ----^^^^^^^^-------------------- help: try: `let data = &self.bitset.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bitset/bitset_32.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match v { [INFO] [stderr] 63 | | true => self.add(i), [INFO] [stderr] 64 | | false => self.remove(i), [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if v { self.add(i) } else { self.remove(i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitset/bitset_32.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn get(&self, i: u32) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitset/bitset_32.rs:83:24 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn cardinality(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boggle/simple_board.rs:60:62 [INFO] [stderr] | [INFO] [stderr] 60 | cells.extend(first.as_bytes().iter().map(|b| b - 'a' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/boggle/simple_board.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boggle/simple_board.rs:72:65 [INFO] [stderr] | [INFO] [stderr] 72 | cells.extend(line.as_bytes().iter().map(|b| b - 'a' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | / match trie.node_type() { [INFO] [stderr] 99 | | NodeType::Word(id) => { [INFO] [stderr] 100 | | if !words.get(id) { [INFO] [stderr] 101 | | words.add(id); [INFO] [stderr] ... | [INFO] [stderr] 111 | | _ => () [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | if let NodeType::Word(id) = trie.node_type() { [INFO] [stderr] 99 | if !words.get(id) { [INFO] [stderr] 100 | words.add(id); [INFO] [stderr] 101 | let mut found: Vec = word.clone(); [INFO] [stderr] 102 | for b in found.iter_mut() { [INFO] [stderr] 103 | *b += 'a' as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:104:39 [INFO] [stderr] | [INFO] [stderr] 104 | *b += 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | / match trie.node_type() { [INFO] [stderr] 179 | | NodeType::Word(id) => { [INFO] [stderr] 180 | | if !words.get(id) { [INFO] [stderr] 181 | | words.add(id); [INFO] [stderr] ... | [INFO] [stderr] 191 | | _ => () [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let NodeType::Word(id) = trie.node_type() { [INFO] [stderr] 179 | if !words.get(id) { [INFO] [stderr] 180 | words.add(id); [INFO] [stderr] 181 | let mut found: Vec = word.clone(); [INFO] [stderr] 182 | for b in found.iter_mut() { [INFO] [stderr] 183 | *b += 'a' as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:184:39 [INFO] [stderr] | [INFO] [stderr] 184 | *b += 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:247:46 [INFO] [stderr] | [INFO] [stderr] 247 | if c == 'q' || c == 'q' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `c == 'q'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `||` [INFO] [stderr] --> src/main.rs:247:46 [INFO] [stderr] | [INFO] [stderr] 247 | if c == 'q' || c == 'q' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_boggle_solver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boggle_util.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | (b - 'a' as u8) as usize [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | let ref data = self.data; [INFO] [stderr] | ----^^^^^^^^------------- help: try: `let data = &self.data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | let ref mut data = self.data; [INFO] [stderr] | ----^^^^^^^^^^^^------------- help: try: `let data = &mut self.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | let ref mut data = self.data; [INFO] [stderr] | ----^^^^^^^^^^^^------------- help: try: `let data = &mut self.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | let ref mut data = self.data; [INFO] [stderr] | ----^^^^^^^^^^^^------------- help: try: `let data = &mut self.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/bitset/bitset.rs:180:13 [INFO] [stderr] | [INFO] [stderr] 180 | let ref data = self.bitset.data; [INFO] [stderr] | ----^^^^^^^^-------------------- help: try: `let data = &self.bitset.data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/bitset/bitset_32.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | / match v { [INFO] [stderr] 63 | | true => self.add(i), [INFO] [stderr] 64 | | false => self.remove(i), [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if v { self.add(i) } else { self.remove(i) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitset/bitset_32.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | pub fn get(&self, i: u32) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitset/bitset_32.rs:83:24 [INFO] [stderr] | [INFO] [stderr] 83 | pub fn cardinality(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/bitset/bitset_32.rs:200:29 [INFO] [stderr] | [INFO] [stderr] 200 | while let Some(b) = iter.next() { [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for b in iter { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/trie.rs:186:19 [INFO] [stderr] | [INFO] [stderr] 186 | for s in ('\u{0}' as u8 .. 'A' as u8) [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\u{0}' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/trie.rs:186:36 [INFO] [stderr] | [INFO] [stderr] 186 | for s in ('\u{0}' as u8 .. 'A' as u8) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'A' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/trie.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | .chain('[' as u8 .. 'a' as u8) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'[' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/trie.rs:187:38 [INFO] [stderr] | [INFO] [stderr] 187 | .chain('[' as u8 .. 'a' as u8) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/trie.rs:188:25 [INFO] [stderr] | [INFO] [stderr] 188 | .chain('{' as u8 .. '\u{ff}' as u8) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'{' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/trie.rs:188:38 [INFO] [stderr] | [INFO] [stderr] 188 | .chain('{' as u8 .. '\u{ff}' as u8) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\u{ff}' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boggle/simple_board.rs:60:62 [INFO] [stderr] | [INFO] [stderr] 60 | cells.extend(first.as_bytes().iter().map(|b| b - 'a' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/boggle/simple_board.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | while let Some(line) = lines.next() { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `for line in lines { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/boggle/simple_board.rs:72:65 [INFO] [stderr] | [INFO] [stderr] 72 | cells.extend(line.as_bytes().iter().map(|b| b - 'a' as u8)); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:98:17 [INFO] [stderr] | [INFO] [stderr] 98 | / match trie.node_type() { [INFO] [stderr] 99 | | NodeType::Word(id) => { [INFO] [stderr] 100 | | if !words.get(id) { [INFO] [stderr] 101 | | words.add(id); [INFO] [stderr] ... | [INFO] [stderr] 111 | | _ => () [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | if let NodeType::Word(id) = trie.node_type() { [INFO] [stderr] 99 | if !words.get(id) { [INFO] [stderr] 100 | words.add(id); [INFO] [stderr] 101 | let mut found: Vec = word.clone(); [INFO] [stderr] 102 | for b in found.iter_mut() { [INFO] [stderr] 103 | *b += 'a' as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:104:39 [INFO] [stderr] | [INFO] [stderr] 104 | *b += 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | / match trie.node_type() { [INFO] [stderr] 179 | | NodeType::Word(id) => { [INFO] [stderr] 180 | | if !words.get(id) { [INFO] [stderr] 181 | | words.add(id); [INFO] [stderr] ... | [INFO] [stderr] 191 | | _ => () [INFO] [stderr] 192 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | if let NodeType::Word(id) = trie.node_type() { [INFO] [stderr] 179 | if !words.get(id) { [INFO] [stderr] 180 | words.add(id); [INFO] [stderr] 181 | let mut found: Vec = word.clone(); [INFO] [stderr] 182 | for b in found.iter_mut() { [INFO] [stderr] 183 | *b += 'a' as u8; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:184:39 [INFO] [stderr] | [INFO] [stderr] 184 | *b += 'a' as u8; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:247:46 [INFO] [stderr] | [INFO] [stderr] 247 | if c == 'q' || c == 'q' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `c == 'q'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `||` [INFO] [stderr] --> src/main.rs:247:46 [INFO] [stderr] | [INFO] [stderr] 247 | if c == 'q' || c == 'q' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_boggle_solver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7cdd0d7e670ebd212bedb29624753f07ba67ad415a73d4de69bda6d20cb9ba37"` [INFO] running `"docker" "rm" "-f" "7cdd0d7e670ebd212bedb29624753f07ba67ad415a73d4de69bda6d20cb9ba37"` [INFO] [stdout] 7cdd0d7e670ebd212bedb29624753f07ba67ad415a73d4de69bda6d20cb9ba37