[INFO] updating cached repository saghm/iter_talk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/saghm/iter_talk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/saghm/iter_talk" "work/ex/clippy-test-run/sources/stable/gh/saghm/iter_talk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/saghm/iter_talk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/saghm/iter_talk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saghm/iter_talk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saghm/iter_talk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b765ac1b24fdfebf7a2a0e9f8368a0e09bd3d146 [INFO] sha for GitHub repo saghm/iter_talk: b765ac1b24fdfebf7a2a0e9f8368a0e09bd3d146 [INFO] validating manifest of saghm/iter_talk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of saghm/iter_talk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing saghm/iter_talk [INFO] finished frobbing saghm/iter_talk [INFO] frobbed toml for saghm/iter_talk written to work/ex/clippy-test-run/sources/stable/gh/saghm/iter_talk/Cargo.toml [INFO] started frobbing saghm/iter_talk [INFO] finished frobbing saghm/iter_talk [INFO] frobbed toml for saghm/iter_talk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saghm/iter_talk/Cargo.toml [INFO] crate saghm/iter_talk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting saghm/iter_talk against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/saghm/iter_talk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bc8b92308ed5d7e0d44f7846e31ba8126846d5808817e34cd67fb6a7b021f6c7 [INFO] running `"docker" "start" "-a" "bc8b92308ed5d7e0d44f7846e31ba8126846d5808817e34cd67fb6a7b021f6c7"` [INFO] [stderr] Checking iter_talk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/collect.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | print_set(&Counter::new(10).into_iter().collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `Counter::new(10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/bin/vec_usage.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | .filter(|i| i % 2 == 0) [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 12 | | .fold(1, |i, j| i * j) [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/bin/vec_usage.rs:11:36 [INFO] [stderr] | [INFO] [stderr] 11 | .filter(|i| i % 2 == 0) [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 12 | | .fold(1, |i, j| i * j) [INFO] [stderr] | |__________________________________^ help: try: `.product()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/from_iter.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | let split: Split = (0..10).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/from_iter.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | let split: Split = (0..10).into_iter().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/collect.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | print_set(&Counter::new(10).into_iter().collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `Counter::new(10)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.57s [INFO] running `"docker" "inspect" "bc8b92308ed5d7e0d44f7846e31ba8126846d5808817e34cd67fb6a7b021f6c7"` [INFO] running `"docker" "rm" "-f" "bc8b92308ed5d7e0d44f7846e31ba8126846d5808817e34cd67fb6a7b021f6c7"` [INFO] [stdout] bc8b92308ed5d7e0d44f7846e31ba8126846d5808817e34cd67fb6a7b021f6c7