[INFO] updating cached repository safsom/alif [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/safsom/alif [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/safsom/alif" "work/ex/clippy-test-run/sources/stable/gh/safsom/alif"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/safsom/alif'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/safsom/alif" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/safsom/alif"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/safsom/alif'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 786504c115ca9a5325867a2ff8f9bc87e59afba3 [INFO] sha for GitHub repo safsom/alif: 786504c115ca9a5325867a2ff8f9bc87e59afba3 [INFO] validating manifest of safsom/alif on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of safsom/alif on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing safsom/alif [INFO] finished frobbing safsom/alif [INFO] frobbed toml for safsom/alif written to work/ex/clippy-test-run/sources/stable/gh/safsom/alif/Cargo.toml [INFO] started frobbing safsom/alif [INFO] finished frobbing safsom/alif [INFO] frobbed toml for safsom/alif written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/safsom/alif/Cargo.toml [INFO] crate safsom/alif has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting safsom/alif against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/safsom/alif:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6a446d8cb0594d3354c068763653ff0b359b37cd0d3bf553d023e166c885ca18 [INFO] running `"docker" "start" "-a" "6a446d8cb0594d3354c068763653ff0b359b37cd0d3bf553d023e166c885ca18"` [INFO] [stderr] Checking ac v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:218:80 [INFO] [stderr] | [INFO] [stderr] 218 | TokenType::OpenCurly => println!("token {} at char {} on line {}", "{", token.token_pos, token.token_line), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:219:82 [INFO] [stderr] | [INFO] [stderr] 219 | TokenType::ClosedCurly => println!("token {} at char {} on line {}", "}", token.token_pos, token.token_line), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:230:81 [INFO] [stderr] | [INFO] [stderr] 230 | TokenType::OpenSquare => println!("token {} at char {} on line {}", "[", token.token_line, token.token_pos), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:231:83 [INFO] [stderr] | [INFO] [stderr] 231 | TokenType::ClosedSquare => println!("token {} at char {} on line {}", "]", token.token_line, token.token_pos), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:218:80 [INFO] [stderr] | [INFO] [stderr] 218 | TokenType::OpenCurly => println!("token {} at char {} on line {}", "{", token.token_pos, token.token_line), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:219:82 [INFO] [stderr] | [INFO] [stderr] 219 | TokenType::ClosedCurly => println!("token {} at char {} on line {}", "}", token.token_pos, token.token_line), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:230:81 [INFO] [stderr] | [INFO] [stderr] 230 | TokenType::OpenSquare => println!("token {} at char {} on line {}", "[", token.token_line, token.token_pos), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/lexer.rs:231:83 [INFO] [stderr] | [INFO] [stderr] 231 | TokenType::ClosedSquare => println!("token {} at char {} on line {}", "]", token.token_line, token.token_pos), [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/lexer.rs:229:46 [INFO] [stderr] | [INFO] [stderr] 229 | TokenType::Identifier(ref s, ref b) => println!("identifier {} on line {} at char {}", s, token.token_line, token.token_pos), [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/parser.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | TokenType::String(ref s) => panic!("error: type mismatch: cannot operate on integers and strings"), [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `b` [INFO] [stderr] --> src/lexer.rs:229:46 [INFO] [stderr] | [INFO] [stderr] 229 | TokenType::Identifier(ref s, ref b) => println!("identifier {} on line {} at char {}", s, token.token_line, token.token_pos), [INFO] [stderr] | ^ help: consider using `_b` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `s` [INFO] [stderr] --> src/parser.rs:69:43 [INFO] [stderr] | [INFO] [stderr] 69 | TokenType::String(ref s) => panic!("error: type mismatch: cannot operate on integers and strings"), [INFO] [stderr] | ^ help: consider using `_s` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let mut i = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Division` [INFO] [stderr] --> src/parser.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Division, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LeftShift` [INFO] [stderr] --> src/parser.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | LeftShift, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RightShift` [INFO] [stderr] --> src/parser.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | RightShift, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StringLiteral` [INFO] [stderr] --> src/parser.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | StringLiteral(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Character` [INFO] [stderr] --> src/parser.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Character(char), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Const` [INFO] [stderr] --> src/parser.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | Const(String, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unary` [INFO] [stderr] --> src/parser.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | Unary(Operators, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Call` [INFO] [stderr] --> src/parser.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Call(String, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Function` [INFO] [stderr] --> src/parser.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | Function(String, Vec, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `If` [INFO] [stderr] --> src/parser.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | If(Box, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Else` [INFO] [stderr] --> src/parser.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | Else(Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `keywords` should have an upper case name such as `KEYWORDS` [INFO] [stderr] --> src/lexer.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const keywords: [&str; 10] = ["const", "record", "char", "string", "int", "bool", "if", "else", "match", "enum"]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | fn is_keyword(string: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `keywords`. [INFO] [stderr] --> src/lexer.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 62 | for in &keywords { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lexer.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if keywords[i].to_string() == *string { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/parser.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | let mut i = 0; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Division` [INFO] [stderr] --> src/parser.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Division, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `LeftShift` [INFO] [stderr] --> src/parser.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | LeftShift, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `RightShift` [INFO] [stderr] --> src/parser.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | RightShift, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `StringLiteral` [INFO] [stderr] --> src/parser.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | StringLiteral(String), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Character` [INFO] [stderr] --> src/parser.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Character(char), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Const` [INFO] [stderr] --> src/parser.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | Const(String, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Unary` [INFO] [stderr] --> src/parser.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | Unary(Operators, Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Call` [INFO] [stderr] --> src/parser.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | Call(String, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Function` [INFO] [stderr] --> src/parser.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | Function(String, Vec, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `If` [INFO] [stderr] --> src/parser.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | If(Box, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Else` [INFO] [stderr] --> src/parser.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | Else(Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant `keywords` should have an upper case name such as `KEYWORDS` [INFO] [stderr] --> src/lexer.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | const keywords: [&str; 10] = ["const", "record", "char", "string", "int", "bool", "if", "else", "match", "enum"]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lexer.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | fn is_keyword(string: &String) -> bool { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `keywords`. [INFO] [stderr] --> src/lexer.rs:62:14 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..10 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 62 | for in &keywords { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lexer.rs:63:12 [INFO] [stderr] | [INFO] [stderr] 63 | if keywords[i].to_string() == *string { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match tokens[i].token_type { [INFO] [stderr] 65 | | TokenType::Integer(ref lvalue) => { [INFO] [stderr] 66 | | let option = match_operator(&tokens[i + 1].token_type); [INFO] [stderr] 67 | | let rvalue = match tokens[i + 2].token_type { [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => (), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | if let TokenType::Integer(ref lvalue) = tokens[i].token_type { [INFO] [stderr] 65 | let option = match_operator(&tokens[i + 1].token_type); [INFO] [stderr] 66 | let rvalue = match tokens[i + 2].token_type { [INFO] [stderr] 67 | TokenType::Integer(ref n) => *n, [INFO] [stderr] 68 | TokenType::String(ref s) => panic!("error: type mismatch: cannot operate on integers and strings"), [INFO] [stderr] 69 | _ => 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match tokens[i].token_type { [INFO] [stderr] 65 | | TokenType::Integer(ref lvalue) => { [INFO] [stderr] 66 | | let option = match_operator(&tokens[i + 1].token_type); [INFO] [stderr] 67 | | let rvalue = match tokens[i + 2].token_type { [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => (), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | if let TokenType::Integer(ref lvalue) = tokens[i].token_type { [INFO] [stderr] 65 | let option = match_operator(&tokens[i + 1].token_type); [INFO] [stderr] 66 | let rvalue = match tokens[i + 2].token_type { [INFO] [stderr] 67 | TokenType::Integer(ref n) => *n, [INFO] [stderr] 68 | TokenType::String(ref s) => panic!("error: type mismatch: cannot operate on integers and strings"), [INFO] [stderr] 69 | _ => 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.55s [INFO] running `"docker" "inspect" "6a446d8cb0594d3354c068763653ff0b359b37cd0d3bf553d023e166c885ca18"` [INFO] running `"docker" "rm" "-f" "6a446d8cb0594d3354c068763653ff0b359b37cd0d3bf553d023e166c885ca18"` [INFO] [stdout] 6a446d8cb0594d3354c068763653ff0b359b37cd0d3bf553d023e166c885ca18