[INFO] updating cached repository s7jones/Rust-Wondrous-Numbers [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/s7jones/Rust-Wondrous-Numbers [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/s7jones/Rust-Wondrous-Numbers" "work/ex/clippy-test-run/sources/stable/gh/s7jones/Rust-Wondrous-Numbers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/s7jones/Rust-Wondrous-Numbers'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/s7jones/Rust-Wondrous-Numbers" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s7jones/Rust-Wondrous-Numbers"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s7jones/Rust-Wondrous-Numbers'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9896f74b7d1e710e701447ad5fa0e23dd6621493 [INFO] sha for GitHub repo s7jones/Rust-Wondrous-Numbers: 9896f74b7d1e710e701447ad5fa0e23dd6621493 [INFO] validating manifest of s7jones/Rust-Wondrous-Numbers on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of s7jones/Rust-Wondrous-Numbers on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing s7jones/Rust-Wondrous-Numbers [INFO] finished frobbing s7jones/Rust-Wondrous-Numbers [INFO] frobbed toml for s7jones/Rust-Wondrous-Numbers written to work/ex/clippy-test-run/sources/stable/gh/s7jones/Rust-Wondrous-Numbers/Cargo.toml [INFO] started frobbing s7jones/Rust-Wondrous-Numbers [INFO] finished frobbing s7jones/Rust-Wondrous-Numbers [INFO] frobbed toml for s7jones/Rust-Wondrous-Numbers written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s7jones/Rust-Wondrous-Numbers/Cargo.toml [INFO] crate s7jones/Rust-Wondrous-Numbers has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting s7jones/Rust-Wondrous-Numbers against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s7jones/Rust-Wondrous-Numbers:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36f76ec4a0c1ae42f12a2f92143458aadc584b70e40323625f1a349db7e08015 [INFO] running `"docker" "start" "-a" "36f76ec4a0c1ae42f12a2f92143458aadc584b70e40323625f1a349db7e08015"` [INFO] [stderr] Checking collatz_conjecture v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | io::stdout().flush().ok().expect("didn't flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / io::stdin() [INFO] [stderr] 17 | | .read_line(&mut menu) [INFO] [stderr] 18 | | .ok() [INFO] [stderr] 19 | | .expect("failed to read line"); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | let menu: u8 = menu.trim() [INFO] [stderr] | ____________________^ [INFO] [stderr] 22 | | .parse() [INFO] [stderr] 23 | | .ok() [INFO] [stderr] 24 | | .expect("failed to convert to number"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().flush().ok().expect("didn't flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / io::stdin() [INFO] [stderr] 36 | | .read_line(&mut number) [INFO] [stderr] 37 | | .ok() [INFO] [stderr] 38 | | .expect("failed to read line"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | let mut number: u64 = number.trim() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 41 | | .parse() [INFO] [stderr] 42 | | .ok() [INFO] [stderr] 43 | | .expect("failed to convert to number"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | number = number / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | io::stdout().flush().ok().expect("didn't flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / io::stdin() [INFO] [stderr] 70 | | .read_line(&mut number) [INFO] [stderr] 71 | | .ok() [INFO] [stderr] 72 | | .expect("failed to read line"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:74:35 [INFO] [stderr] | [INFO] [stderr] 74 | let mut number: u64 = number.trim() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 75 | | .parse() [INFO] [stderr] 76 | | .ok() [INFO] [stderr] 77 | | .expect("failed to convert to number"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | number = number / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | io::stdout().flush().ok().expect("didn't flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / io::stdin() [INFO] [stderr] 17 | | .read_line(&mut menu) [INFO] [stderr] 18 | | .ok() [INFO] [stderr] 19 | | .expect("failed to read line"); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:21:20 [INFO] [stderr] | [INFO] [stderr] 21 | let menu: u8 = menu.trim() [INFO] [stderr] | ____________________^ [INFO] [stderr] 22 | | .parse() [INFO] [stderr] 23 | | .ok() [INFO] [stderr] 24 | | .expect("failed to convert to number"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | io::stdout().flush().ok().expect("didn't flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / io::stdin() [INFO] [stderr] 36 | | .read_line(&mut number) [INFO] [stderr] 37 | | .ok() [INFO] [stderr] 38 | | .expect("failed to read line"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:40:35 [INFO] [stderr] | [INFO] [stderr] 40 | let mut number: u64 = number.trim() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 41 | | .parse() [INFO] [stderr] 42 | | .ok() [INFO] [stderr] 43 | | .expect("failed to convert to number"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | number = number / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | io::stdout().flush().ok().expect("didn't flush stdout"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / io::stdin() [INFO] [stderr] 70 | | .read_line(&mut number) [INFO] [stderr] 71 | | .ok() [INFO] [stderr] 72 | | .expect("failed to read line"); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:74:35 [INFO] [stderr] | [INFO] [stderr] 74 | let mut number: u64 = number.trim() [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 75 | | .parse() [INFO] [stderr] 76 | | .ok() [INFO] [stderr] 77 | | .expect("failed to convert to number"); [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:94:21 [INFO] [stderr] | [INFO] [stderr] 94 | number = number / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number /= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "36f76ec4a0c1ae42f12a2f92143458aadc584b70e40323625f1a349db7e08015"` [INFO] running `"docker" "rm" "-f" "36f76ec4a0c1ae42f12a2f92143458aadc584b70e40323625f1a349db7e08015"` [INFO] [stdout] 36f76ec4a0c1ae42f12a2f92143458aadc584b70e40323625f1a349db7e08015