[INFO] updating cached repository s3rvac/yabir
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/s3rvac/yabir
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/s3rvac/yabir" "work/ex/clippy-test-run/sources/stable/gh/s3rvac/yabir"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/s3rvac/yabir'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/s3rvac/yabir" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s3rvac/yabir"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s3rvac/yabir'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e7363c05b4765af29ac180c0472cb8a8a08ba67d
[INFO] sha for GitHub repo s3rvac/yabir: e7363c05b4765af29ac180c0472cb8a8a08ba67d
[INFO] validating manifest of s3rvac/yabir on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of s3rvac/yabir on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing s3rvac/yabir
[INFO] finished frobbing s3rvac/yabir
[INFO] frobbed toml for s3rvac/yabir written to work/ex/clippy-test-run/sources/stable/gh/s3rvac/yabir/Cargo.toml
[INFO] started frobbing s3rvac/yabir
[INFO] finished frobbing s3rvac/yabir
[INFO] frobbed toml for s3rvac/yabir written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s3rvac/yabir/Cargo.toml
[INFO] crate s3rvac/yabir has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting s3rvac/yabir against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/s3rvac/yabir:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 792c8e7886e6f6791f4521e62dc56e920001f2bbdaa65b7fc1c827ca82bf8888
[INFO] running `"docker" "start" "-a" "792c8e7886e6f6791f4521e62dc56e920001f2bbdaa65b7fc1c827ca82bf8888"`
[INFO] [stderr]     Checking yabir v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/runner.rs:112:30
[INFO] [stderr]     |
[INFO] [stderr] 112 |     fn read_value(&mut self, mut input: &mut std::io::Read) -> Result<(), String> {
[INFO] [stderr]     |                              ----^^^^^
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/runner.rs:136:31
[INFO] [stderr]     |
[INFO] [stderr] 136 |     fn write_value(&mut self, mut output: &mut std::io::Write) -> Result<(), String> {
[INFO] [stderr]     |                               ----^^^^^^
[INFO] [stderr]     |                               |
[INFO] [stderr]     |                               help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cli.rs:19:33
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub fn should_print_usage(args: &Vec<String>) -> bool {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lexer.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn tokenize(prog: &String) -> Tokens {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/loader.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn load_prog(path: &String) -> Result<String, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn parse(tokens: &Tokens) -> Result<Instructions, String> {
[INFO] [stderr]    |                      ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:94:44
[INFO] [stderr]    |
[INFO] [stderr] 94 | fn ensure_all_loops_have_ended(loop_stack: &LoopStack) -> Result<(), String> {
[INFO] [stderr]    |                                            ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/runner.rs:112:30
[INFO] [stderr]     |
[INFO] [stderr] 112 |     fn read_value(&mut self, mut input: &mut std::io::Read) -> Result<(), String> {
[INFO] [stderr]     |                              ----^^^^^
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/runner.rs:136:31
[INFO] [stderr]     |
[INFO] [stderr] 136 |     fn write_value(&mut self, mut output: &mut std::io::Write) -> Result<(), String> {
[INFO] [stderr]     |                               ----^^^^^^
[INFO] [stderr]     |                               |
[INFO] [stderr]     |                               help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/cli.rs:19:33
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub fn should_print_usage(args: &Vec<String>) -> bool {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lexer.rs:36:23
[INFO] [stderr]    |
[INFO] [stderr] 36 | pub fn tokenize(prog: &String) -> Tokens {
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/loader.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn load_prog(path: &String) -> Result<String, String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:43:22
[INFO] [stderr]    |
[INFO] [stderr] 43 | pub fn parse(tokens: &Tokens) -> Result<Instructions, String> {
[INFO] [stderr]    |                      ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/parser.rs:94:44
[INFO] [stderr]    |
[INFO] [stderr] 94 | fn ensure_all_loops_have_ended(loop_stack: &LoopStack) -> Result<(), String> {
[INFO] [stderr]    |                                            ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/runner.rs:144:29
[INFO] [stderr]     |
[INFO] [stderr] 144 |     fn is_current_cell_zero(&mut self) -> bool {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/runner.rs:151:22
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for _ in 0..(self.dp - cell_count + 1) {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.dp - cell_count`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/runner.rs:201:60
[INFO] [stderr]     |
[INFO] [stderr] 201 |             let mut input_reader = std::io::BufReader::new(input.as_ref());
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^^^ help: try this: `input`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name
[INFO] [stderr]    --> src/runner.rs:144:29
[INFO] [stderr]     |
[INFO] [stderr] 144 |     fn is_current_cell_zero(&mut self) -> bool {
[INFO] [stderr]     |                             ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::wrong_self_convention)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/runner.rs:151:22
[INFO] [stderr]     |
[INFO] [stderr] 151 |             for _ in 0..(self.dp - cell_count + 1) {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.dp - cell_count`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn run_prog(prog_path: &String) -> Result<(), String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:24:24
[INFO] [stderr]    |
[INFO] [stderr] 24 | fn run_prog(prog_path: &String) -> Result<(), String> {
[INFO] [stderr]    |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn print_error(err: &String) {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:33:21
[INFO] [stderr]    |
[INFO] [stderr] 33 | fn print_error(err: &String) {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.72s
[INFO] running `"docker" "inspect" "792c8e7886e6f6791f4521e62dc56e920001f2bbdaa65b7fc1c827ca82bf8888"`
[INFO] running `"docker" "rm" "-f" "792c8e7886e6f6791f4521e62dc56e920001f2bbdaa65b7fc1c827ca82bf8888"`
[INFO] [stdout] 792c8e7886e6f6791f4521e62dc56e920001f2bbdaa65b7fc1c827ca82bf8888