[INFO] updating cached repository rustkas/rust-101-impl [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rustkas/rust-101-impl [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rustkas/rust-101-impl" "work/ex/clippy-test-run/sources/stable/gh/rustkas/rust-101-impl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rustkas/rust-101-impl'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rustkas/rust-101-impl" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustkas/rust-101-impl"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustkas/rust-101-impl'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 613d00f4626de92ead3dc7534fc6f94a73e95cfb [INFO] sha for GitHub repo rustkas/rust-101-impl: 613d00f4626de92ead3dc7534fc6f94a73e95cfb [INFO] validating manifest of rustkas/rust-101-impl on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rustkas/rust-101-impl on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rustkas/rust-101-impl [INFO] finished frobbing rustkas/rust-101-impl [INFO] frobbed toml for rustkas/rust-101-impl written to work/ex/clippy-test-run/sources/stable/gh/rustkas/rust-101-impl/Cargo.toml [INFO] started frobbing rustkas/rust-101-impl [INFO] finished frobbing rustkas/rust-101-impl [INFO] frobbed toml for rustkas/rust-101-impl written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustkas/rust-101-impl/Cargo.toml [INFO] crate rustkas/rust-101-impl has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rustkas/rust-101-impl against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rustkas/rust-101-impl:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b28409b7bad873735c619bb848168ed5b32bc625b7df7663eb76b905426d1e82 [INFO] running `"docker" "start" "-a" "b28409b7bad873735c619bb848168ed5b32bc625b7df7663eb76b905426d1e82"` [INFO] [stderr] Checking rust-101 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part0.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return min; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `el` [INFO] [stderr] --> src/part0.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | for el in vec { [INFO] [stderr] | ^^ help: consider using `_el` instead [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/part02.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_option(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/part0.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | Number(n) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/part0.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | fn print_number_or_nothing(n: NumberOrNothing) { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/part0.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let mut min = Nothing; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part01.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | fn vec_min(v: &Vec) -> NumberOrNothing { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/part02.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | fn to_option(self) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] --> src/part0.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Number(i32), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `min_i32` [INFO] [stderr] --> src/part0.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | fn min_i32(a: i32, b: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part01.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | fn vec_sum(v: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part01.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | fn vec_print(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/part0.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | return min; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `el` [INFO] [stderr] --> src/part0.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | for el in vec { [INFO] [stderr] | ^^ help: consider using `_el` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/part0.rs:35:20 [INFO] [stderr] | [INFO] [stderr] 35 | Number(n) => { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/part0.rs:70:28 [INFO] [stderr] | [INFO] [stderr] 70 | fn print_number_or_nothing(n: NumberOrNothing) { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/part0.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | let mut min = Nothing; [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Number` [INFO] [stderr] --> src/part0.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | Number(i32), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `min_i32` [INFO] [stderr] --> src/part0.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | fn min_i32(a: i32, b: i32) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part01.rs:37:15 [INFO] [stderr] | [INFO] [stderr] 37 | fn vec_min(v: &Vec) -> NumberOrNothing { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part01.rs:84:15 [INFO] [stderr] | [INFO] [stderr] 84 | fn vec_sum(v: &Vec) -> i32 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/part01.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | fn vec_print(v: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "b28409b7bad873735c619bb848168ed5b32bc625b7df7663eb76b905426d1e82"` [INFO] running `"docker" "rm" "-f" "b28409b7bad873735c619bb848168ed5b32bc625b7df7663eb76b905426d1e82"` [INFO] [stdout] b28409b7bad873735c619bb848168ed5b32bc625b7df7663eb76b905426d1e82