[INFO] updating cached repository russiancow/dotenv_cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/russiancow/dotenv_cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/russiancow/dotenv_cli" "work/ex/clippy-test-run/sources/stable/gh/russiancow/dotenv_cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/russiancow/dotenv_cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/russiancow/dotenv_cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/russiancow/dotenv_cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/russiancow/dotenv_cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cc59f541cc301698b6e24b0cbf9b5791e35644cb [INFO] sha for GitHub repo russiancow/dotenv_cli: cc59f541cc301698b6e24b0cbf9b5791e35644cb [INFO] validating manifest of russiancow/dotenv_cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of russiancow/dotenv_cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing russiancow/dotenv_cli [INFO] finished frobbing russiancow/dotenv_cli [INFO] frobbed toml for russiancow/dotenv_cli written to work/ex/clippy-test-run/sources/stable/gh/russiancow/dotenv_cli/Cargo.toml [INFO] started frobbing russiancow/dotenv_cli [INFO] finished frobbing russiancow/dotenv_cli [INFO] frobbed toml for russiancow/dotenv_cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/russiancow/dotenv_cli/Cargo.toml [INFO] crate russiancow/dotenv_cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting russiancow/dotenv_cli against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/russiancow/dotenv_cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 593d67606d2ae4307500cadc6122c71722f9132d9c4013c3d760468128bd1e7c [INFO] running `"docker" "start" "-a" "593d67606d2ae4307500cadc6122c71722f9132d9c4013c3d760468128bd1e7c"` [INFO] [stderr] Checking dotenv_cli v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 54 | | if character == '=' { [INFO] [stderr] 55 | | is_past_equal_sign = true; [INFO] [stderr] 56 | | } else { [INFO] [stderr] 57 | | key = key + &character.to_string(); [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | } else if character == '=' { [INFO] [stderr] 54 | is_past_equal_sign = true; [INFO] [stderr] 55 | } else { [INFO] [stderr] 56 | key = key + &character.to_string(); [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 54 | | if character == '=' { [INFO] [stderr] 55 | | is_past_equal_sign = true; [INFO] [stderr] 56 | | } else { [INFO] [stderr] 57 | | key = key + &character.to_string(); [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 53 | } else if character == '=' { [INFO] [stderr] 54 | is_past_equal_sign = true; [INFO] [stderr] 55 | } else { [INFO] [stderr] 56 | key = key + &character.to_string(); [INFO] [stderr] 57 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | command.spawn().expect(&format!( [INFO] [stderr] | _____________________^ [INFO] [stderr] 26 | | "Could not run the command: {}", [INFO] [stderr] 27 | | command_name [INFO] [stderr] 28 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Could not run the command: {}", command_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:25:18 [INFO] [stderr] | [INFO] [stderr] 25 | command.spawn().expect(&format!( [INFO] [stderr] | _____________________^ [INFO] [stderr] 26 | | "Could not run the command: {}", [INFO] [stderr] 27 | | command_name [INFO] [stderr] 28 | | )); [INFO] [stderr] | |______^ help: try this: `unwrap_or_else(|_| panic!("Could not run the command: {}", command_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "593d67606d2ae4307500cadc6122c71722f9132d9c4013c3d760468128bd1e7c"` [INFO] running `"docker" "rm" "-f" "593d67606d2ae4307500cadc6122c71722f9132d9c4013c3d760468128bd1e7c"` [INFO] [stdout] 593d67606d2ae4307500cadc6122c71722f9132d9c4013c3d760468128bd1e7c