[INFO] updating cached repository rsk700/streamspeed [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rsk700/streamspeed [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rsk700/streamspeed" "work/ex/clippy-test-run/sources/stable/gh/rsk700/streamspeed"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rsk700/streamspeed'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rsk700/streamspeed" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rsk700/streamspeed"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rsk700/streamspeed'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 74fab21d7f722764ec44c06e7ee7cb671241e85f [INFO] sha for GitHub repo rsk700/streamspeed: 74fab21d7f722764ec44c06e7ee7cb671241e85f [INFO] validating manifest of rsk700/streamspeed on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rsk700/streamspeed on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rsk700/streamspeed [INFO] finished frobbing rsk700/streamspeed [INFO] frobbed toml for rsk700/streamspeed written to work/ex/clippy-test-run/sources/stable/gh/rsk700/streamspeed/Cargo.toml [INFO] started frobbing rsk700/streamspeed [INFO] finished frobbing rsk700/streamspeed [INFO] frobbed toml for rsk700/streamspeed written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rsk700/streamspeed/Cargo.toml [INFO] crate rsk700/streamspeed has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rsk700/streamspeed against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rsk700/streamspeed:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f57c72472c9718cffaee00b60c008052eb864321a1904e16b8a5fffa67cac9a [INFO] running `"docker" "start" "-a" "9f57c72472c9718cffaee00b60c008052eb864321a1904e16b8a5fffa67cac9a"` [INFO] [stderr] Checking streamspeed v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | speed: speed, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `speed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | speed: speed, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `speed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / let mut start_stat: u64 = 0; [INFO] [stderr] 81 | | if total_spent >= 10 { [INFO] [stderr] 82 | | start_stat = total_spent - 10; [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let start_stat = if total_spent >= 10 { total_spent - 10 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut speed: f64 = 0.0; [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | if duration > 0 { [INFO] [stderr] 88 | | let mut size: usize = 0; [INFO] [stderr] ... | [INFO] [stderr] 96 | | speed = size / duration; [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let speed = if duration > 0 { ..; size / duration } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | std_out.write(&buf[0..size]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `streamspeed`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / let mut start_stat: u64 = 0; [INFO] [stderr] 81 | | if total_spent >= 10 { [INFO] [stderr] 82 | | start_stat = total_spent - 10; [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let start_stat = if total_spent >= 10 { total_spent - 10 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | / let mut speed: f64 = 0.0; [INFO] [stderr] 86 | | [INFO] [stderr] 87 | | if duration > 0 { [INFO] [stderr] 88 | | let mut size: usize = 0; [INFO] [stderr] ... | [INFO] [stderr] 96 | | speed = size / duration; [INFO] [stderr] 97 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let speed = if duration > 0 { ..; size / duration } else { 0.0 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:146:9 [INFO] [stderr] | [INFO] [stderr] 146 | std_out.write(&buf[0..size]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `streamspeed`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9f57c72472c9718cffaee00b60c008052eb864321a1904e16b8a5fffa67cac9a"` [INFO] running `"docker" "rm" "-f" "9f57c72472c9718cffaee00b60c008052eb864321a1904e16b8a5fffa67cac9a"` [INFO] [stdout] 9f57c72472c9718cffaee00b60c008052eb864321a1904e16b8a5fffa67cac9a