[INFO] updating cached repository rozgo/monstersim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rozgo/monstersim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rozgo/monstersim" "work/ex/clippy-test-run/sources/stable/gh/rozgo/monstersim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rozgo/monstersim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rozgo/monstersim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rozgo/monstersim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rozgo/monstersim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24817e761e43e8ff19fe0c3f6c5d9801796a5b07 [INFO] sha for GitHub repo rozgo/monstersim: 24817e761e43e8ff19fe0c3f6c5d9801796a5b07 [INFO] validating manifest of rozgo/monstersim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rozgo/monstersim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rozgo/monstersim [INFO] finished frobbing rozgo/monstersim [INFO] frobbed toml for rozgo/monstersim written to work/ex/clippy-test-run/sources/stable/gh/rozgo/monstersim/Cargo.toml [INFO] started frobbing rozgo/monstersim [INFO] finished frobbing rozgo/monstersim [INFO] frobbed toml for rozgo/monstersim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rozgo/monstersim/Cargo.toml [INFO] crate rozgo/monstersim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rozgo/monstersim against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rozgo/monstersim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19400ab3aa581073a3791dbc3df9029966bd228d156731aadf09dfe66d49e496 [INFO] running `"docker" "start" "-a" "19400ab3aa581073a3791dbc3df9029966bd228d156731aadf09dfe66d49e496"` [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking tui v0.2.3 [INFO] [stderr] Checking monstersim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | _map [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let mut deficit = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | let mut _map = ::std::collections::HashMap::with_capacity(_cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let mut deficit = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | _map [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | let mut acc = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | let mut _map = ::std::collections::HashMap::with_capacity(_cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | let mut acc = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | _map [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let mut deficit = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | let mut _map = ::std::collections::HashMap::with_capacity(_cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:30:27 [INFO] [stderr] | [INFO] [stderr] 30 | let mut deficit = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | _map [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | let mut acc = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | let mut _map = ::std::collections::HashMap::with_capacity(_cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/account.rs:70:23 [INFO] [stderr] | [INFO] [stderr] 70 | let mut acc = hashmap![]; [INFO] [stderr] | ---------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/account.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | Some(quantity) => quantity.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*quantity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/account.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | let lhs_quantity = lhs.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lhs[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/account.rs:79:32 [INFO] [stderr] | [INFO] [stderr] 79 | let rhs_quantity = rhs.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rhs[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/account.rs:81:37 [INFO] [stderr] | [INFO] [stderr] 81 | acc.insert(key.clone(), quantity.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/account.rs:20:31 [INFO] [stderr] | [INFO] [stderr] 20 | Some(quantity) => quantity.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*quantity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/account.rs:78:32 [INFO] [stderr] | [INFO] [stderr] 78 | let lhs_quantity = lhs.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&lhs[key]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/account.rs:79:32 [INFO] [stderr] | [INFO] [stderr] 79 | let rhs_quantity = rhs.get(key).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rhs[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/account.rs:81:37 [INFO] [stderr] | [INFO] [stderr] 81 | acc.insert(key.clone(), quantity.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `quantity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/monster.rs:13:37 [INFO] [stderr] | [INFO] [stderr] 13 | Asset::LifeTime => Quantity(1000000), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/account.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/rate.rs:11:37 [INFO] [stderr] | [INFO] [stderr] 11 | Asset::LifeTime => Quantity(1000000), [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/rate.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | Asset::LifeTime => Quantity(999999), [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/rate.rs:77:37 [INFO] [stderr] | [INFO] [stderr] 77 | Asset::LifeTime => Quantity(999998), [INFO] [stderr] | ^^^^^^ help: consider: `999_998` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/rate.rs:43:16 [INFO] [stderr] | [INFO] [stderr] 43 | let rate = rates.get(&Exchange::LifeTimeForState).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rates[&Exchange::LifeTimeForState]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> tests/rate.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | let rate = rates.get(&Exchange::LifeTimeForState).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&rates[&Exchange::LifeTimeForState]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.56s [INFO] running `"docker" "inspect" "19400ab3aa581073a3791dbc3df9029966bd228d156731aadf09dfe66d49e496"` [INFO] running `"docker" "rm" "-f" "19400ab3aa581073a3791dbc3df9029966bd228d156731aadf09dfe66d49e496"` [INFO] [stdout] 19400ab3aa581073a3791dbc3df9029966bd228d156731aadf09dfe66d49e496