[INFO] updating cached repository rossjones/ist_csv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rossjones/ist_csv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rossjones/ist_csv" "work/ex/clippy-test-run/sources/stable/gh/rossjones/ist_csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rossjones/ist_csv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rossjones/ist_csv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossjones/ist_csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossjones/ist_csv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec6043f6906d1988151c865f780269c56f346a4d [INFO] sha for GitHub repo rossjones/ist_csv: ec6043f6906d1988151c865f780269c56f346a4d [INFO] validating manifest of rossjones/ist_csv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rossjones/ist_csv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rossjones/ist_csv [INFO] finished frobbing rossjones/ist_csv [INFO] frobbed toml for rossjones/ist_csv written to work/ex/clippy-test-run/sources/stable/gh/rossjones/ist_csv/Cargo.toml [INFO] started frobbing rossjones/ist_csv [INFO] finished frobbing rossjones/ist_csv [INFO] frobbed toml for rossjones/ist_csv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossjones/ist_csv/Cargo.toml [INFO] crate rossjones/ist_csv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rossjones/ist_csv against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rossjones/ist_csv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e631e1e9c2e4182e618a5115b54ff6c648c1a511d7aaa76ca4dfdd6ca1ceeca6 [INFO] running `"docker" "start" "-a" "e631e1e9c2e4182e618a5115b54ff6c648c1a511d7aaa76ca4dfdd6ca1ceeca6"` [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking csv v0.14.7 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking ist_csv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:44:27 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_encoding(filename: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | fn is_header_row(row: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match cap { [INFO] [stderr] 77 | | Some(x) => {count = count + x.len();} [INFO] [stderr] 78 | | None => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = cap {count = count + x.len();}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | Some(x) => {count = count + x.len();} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += x.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:44:27 [INFO] [stderr] | [INFO] [stderr] 44 | fn get_encoding(filename: &String) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | fn is_header_row(row: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match cap { [INFO] [stderr] 77 | | Some(x) => {count = count + x.len();} [INFO] [stderr] 78 | | None => {} [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = cap {count = count + x.len();}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:77:25 [INFO] [stderr] | [INFO] [stderr] 77 | Some(x) => {count = count + x.len();} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count += x.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.73s [INFO] running `"docker" "inspect" "e631e1e9c2e4182e618a5115b54ff6c648c1a511d7aaa76ca4dfdd6ca1ceeca6"` [INFO] running `"docker" "rm" "-f" "e631e1e9c2e4182e618a5115b54ff6c648c1a511d7aaa76ca4dfdd6ca1ceeca6"` [INFO] [stdout] e631e1e9c2e4182e618a5115b54ff6c648c1a511d7aaa76ca4dfdd6ca1ceeca6