[INFO] updating cached repository rogeruiz/getenv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rogeruiz/getenv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rogeruiz/getenv" "work/ex/clippy-test-run/sources/stable/gh/rogeruiz/getenv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rogeruiz/getenv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rogeruiz/getenv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rogeruiz/getenv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rogeruiz/getenv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 310b69ffe78f21c9c37aac38d638a9095f5ab869 [INFO] sha for GitHub repo rogeruiz/getenv: 310b69ffe78f21c9c37aac38d638a9095f5ab869 [INFO] validating manifest of rogeruiz/getenv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rogeruiz/getenv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rogeruiz/getenv [INFO] finished frobbing rogeruiz/getenv [INFO] frobbed toml for rogeruiz/getenv written to work/ex/clippy-test-run/sources/stable/gh/rogeruiz/getenv/Cargo.toml [INFO] started frobbing rogeruiz/getenv [INFO] finished frobbing rogeruiz/getenv [INFO] frobbed toml for rogeruiz/getenv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rogeruiz/getenv/Cargo.toml [INFO] crate rogeruiz/getenv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rogeruiz/getenv against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rogeruiz/getenv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dd4967496ffb4d62d8151f42b4051e57c7d3b32f20fb2d8d91257c4d45b994b4 [INFO] running `"docker" "start" "-a" "dd4967496ffb4d62d8151f42b4051e57c7d3b32f20fb2d8d91257c4d45b994b4"` [INFO] [stderr] Checking getenv v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | / match env::var( "HOME" ) { [INFO] [stderr] 33 | | Ok( m ) => { [INFO] [stderr] 34 | | let home_match = format!( "export HOME=\"{}\"", m ); [INFO] [stderr] 35 | | println!( "{}", m ); [INFO] [stderr] ... | [INFO] [stderr] 38 | | _ => () [INFO] [stderr] 39 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok( m ) = env::var( "HOME" ) { [INFO] [stderr] 33 | let home_match = format!( "export HOME=\"{}\"", m ); [INFO] [stderr] 34 | println!( "{}", m ); [INFO] [stderr] 35 | assert_eq!( home_match, matched ) [INFO] [stderr] 36 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.66s [INFO] running `"docker" "inspect" "dd4967496ffb4d62d8151f42b4051e57c7d3b32f20fb2d8d91257c4d45b994b4"` [INFO] running `"docker" "rm" "-f" "dd4967496ffb4d62d8151f42b4051e57c7d3b32f20fb2d8d91257c4d45b994b4"` [INFO] [stdout] dd4967496ffb4d62d8151f42b4051e57c7d3b32f20fb2d8d91257c4d45b994b4