[INFO] updating cached repository rodrigo-garcia-leon/tictactoe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rodrigo-garcia-leon/tictactoe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rodrigo-garcia-leon/tictactoe" "work/ex/clippy-test-run/sources/stable/gh/rodrigo-garcia-leon/tictactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rodrigo-garcia-leon/tictactoe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rodrigo-garcia-leon/tictactoe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rodrigo-garcia-leon/tictactoe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rodrigo-garcia-leon/tictactoe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e9106ac4bf3a1440444f1b0b0440f7747b212ed [INFO] sha for GitHub repo rodrigo-garcia-leon/tictactoe: 8e9106ac4bf3a1440444f1b0b0440f7747b212ed [INFO] validating manifest of rodrigo-garcia-leon/tictactoe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rodrigo-garcia-leon/tictactoe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rodrigo-garcia-leon/tictactoe [INFO] finished frobbing rodrigo-garcia-leon/tictactoe [INFO] frobbed toml for rodrigo-garcia-leon/tictactoe written to work/ex/clippy-test-run/sources/stable/gh/rodrigo-garcia-leon/tictactoe/Cargo.toml [INFO] started frobbing rodrigo-garcia-leon/tictactoe [INFO] finished frobbing rodrigo-garcia-leon/tictactoe [INFO] frobbed toml for rodrigo-garcia-leon/tictactoe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rodrigo-garcia-leon/tictactoe/Cargo.toml [INFO] crate rodrigo-garcia-leon/tictactoe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rodrigo-garcia-leon/tictactoe against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rodrigo-garcia-leon/tictactoe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 69e31e6e2fd00963754477a74d46d8860b8fe2dd5579bf26e41c84646e5ffc3b [INFO] running `"docker" "start" "-a" "69e31e6e2fd00963754477a74d46d8860b8fe2dd5579bf26e41c84646e5ffc3b"` [INFO] [stderr] Checking tictactoe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return self.cells[get_cell_index(self.size, row, col)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cells[get_cell_index(self.size, row, col)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return *self.get_cell_at(position.0, position.1) == Cell::Empty; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.get_cell_at(position.0, position.1) == Cell::Empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return (col - 1) + size * (row - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(col - 1) + size * (row - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return self.cells[get_cell_index(self.size, row, col)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.cells[get_cell_index(self.size, row, col)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/board.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return *self.get_cell_at(position.0, position.1) == Cell::Empty; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.get_cell_at(position.0, position.1) == Cell::Empty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/utils.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return (col - 1) + size * (row - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(col - 1) + size * (row - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn is_slice_full(slice: &Vec<&Cell>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Cell]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/utils.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn is_slice_full(slice: &Vec<&Cell>) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[&Cell]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "69e31e6e2fd00963754477a74d46d8860b8fe2dd5579bf26e41c84646e5ffc3b"` [INFO] running `"docker" "rm" "-f" "69e31e6e2fd00963754477a74d46d8860b8fe2dd5579bf26e41c84646e5ffc3b"` [INFO] [stdout] 69e31e6e2fd00963754477a74d46d8860b8fe2dd5579bf26e41c84646e5ffc3b