[INFO] updating cached repository robertpanzer/gol-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/robertpanzer/gol-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/robertpanzer/gol-rust" "work/ex/clippy-test-run/sources/stable/gh/robertpanzer/gol-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/robertpanzer/gol-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/robertpanzer/gol-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertpanzer/gol-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertpanzer/gol-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a330dea117fd2ff44e1b80184c2ca46f1f9b1503 [INFO] sha for GitHub repo robertpanzer/gol-rust: a330dea117fd2ff44e1b80184c2ca46f1f9b1503 [INFO] validating manifest of robertpanzer/gol-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of robertpanzer/gol-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing robertpanzer/gol-rust [INFO] finished frobbing robertpanzer/gol-rust [INFO] frobbed toml for robertpanzer/gol-rust written to work/ex/clippy-test-run/sources/stable/gh/robertpanzer/gol-rust/Cargo.toml [INFO] started frobbing robertpanzer/gol-rust [INFO] finished frobbing robertpanzer/gol-rust [INFO] frobbed toml for robertpanzer/gol-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertpanzer/gol-rust/Cargo.toml [INFO] crate robertpanzer/gol-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting robertpanzer/gol-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/robertpanzer/gol-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ae6e158c384e4ccae7bcfa8d78bef2c1faf1592f6a4cb4a02c48cf7b9fad942 [INFO] running `"docker" "start" "-a" "1ae6e158c384e4ccae7bcfa8d78bef2c1faf1592f6a4cb4a02c48cf7b9fad942"` [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking gag v0.1.9 [INFO] [stderr] Checking rustty v0.1.12 [INFO] [stderr] Checking gol v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:97:50 [INFO] [stderr] | [INFO] [stderr] 97 | match term.get_event(Duration::from_secs(100000)).unwrap() { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:97:50 [INFO] [stderr] | [INFO] [stderr] 97 | match term.get_event(Duration::from_secs(100000)).unwrap() { [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cells` [INFO] [stderr] --> src/main.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 0..self.current.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for (i, ) in cells.iter_mut().enumerate().take(self.current.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | cell.set_ch(match self.current[i] { [INFO] [stderr] | _________________________^ [INFO] [stderr] 39 | | true => 'X', [INFO] [stderr] 40 | | false => ' ' [INFO] [stderr] 41 | | }); [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.current[i] { 'X' } else { ' ' }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `cells` [INFO] [stderr] --> src/main.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | for i in 0..self.current.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 36 | for (i, ) in cells.iter_mut().enumerate().take(self.current.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:38:25 [INFO] [stderr] | [INFO] [stderr] 38 | cell.set_ch(match self.current[i] { [INFO] [stderr] | _________________________^ [INFO] [stderr] 39 | | true => 'X', [INFO] [stderr] 40 | | false => ' ' [INFO] [stderr] 41 | | }); [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.current[i] { 'X' } else { ' ' }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.62s [INFO] running `"docker" "inspect" "1ae6e158c384e4ccae7bcfa8d78bef2c1faf1592f6a4cb4a02c48cf7b9fad942"` [INFO] running `"docker" "rm" "-f" "1ae6e158c384e4ccae7bcfa8d78bef2c1faf1592f6a4cb4a02c48cf7b9fad942"` [INFO] [stdout] 1ae6e158c384e4ccae7bcfa8d78bef2c1faf1592f6a4cb4a02c48cf7b9fad942