[INFO] updating cached repository rmirabelli/scheme_interpreter
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rmirabelli/scheme_interpreter
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rmirabelli/scheme_interpreter" "work/ex/clippy-test-run/sources/stable/gh/rmirabelli/scheme_interpreter"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rmirabelli/scheme_interpreter'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rmirabelli/scheme_interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmirabelli/scheme_interpreter"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmirabelli/scheme_interpreter'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9c868e391ef1eb2b84631da73d9bb0ba433debdb
[INFO] sha for GitHub repo rmirabelli/scheme_interpreter: 9c868e391ef1eb2b84631da73d9bb0ba433debdb
[INFO] validating manifest of rmirabelli/scheme_interpreter on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rmirabelli/scheme_interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rmirabelli/scheme_interpreter
[INFO] finished frobbing rmirabelli/scheme_interpreter
[INFO] frobbed toml for rmirabelli/scheme_interpreter written to work/ex/clippy-test-run/sources/stable/gh/rmirabelli/scheme_interpreter/Cargo.toml
[INFO] started frobbing rmirabelli/scheme_interpreter
[INFO] finished frobbing rmirabelli/scheme_interpreter
[INFO] frobbed toml for rmirabelli/scheme_interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmirabelli/scheme_interpreter/Cargo.toml
[INFO] crate rmirabelli/scheme_interpreter has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rmirabelli/scheme_interpreter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmirabelli/scheme_interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c7f700ba0410026826eacaff189fdb08716ec3d4ab0bd7194fc36ee08fbdd060
[INFO] running `"docker" "start" "-a" "c7f700ba0410026826eacaff189fdb08716ec3d4ab0bd7194fc36ee08fbdd060"`
[INFO] [stderr]     Checking updated_scheme v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         operator: operator,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if_true: if_true,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `if_true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if_false: if_false,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `if_false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:75:3
[INFO] [stderr]    |
[INFO] [stderr] 75 |         operator: operator,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:116:3
[INFO] [stderr]     |
[INFO] [stderr] 116 |         if_true: if_true,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `if_true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:117:3
[INFO] [stderr]     |
[INFO] [stderr] 117 |         if_false: if_false,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `if_false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/environment_parser.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 |         tokens: tokens,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         operator: operator,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:40:9
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if_true: if_true,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^ help: replace it with: `if_true`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:41:9
[INFO] [stderr]    |
[INFO] [stderr] 41 |         if_false: if_false,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `if_false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parser.rs:75:3
[INFO] [stderr]    |
[INFO] [stderr] 75 |         operator: operator,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `operator`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:116:3
[INFO] [stderr]     |
[INFO] [stderr] 116 |         if_true: if_true,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `if_true`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parser.rs:117:3
[INFO] [stderr]     |
[INFO] [stderr] 117 |         if_false: if_false,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `if_false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/environment_parser.rs:56:3
[INFO] [stderr]    |
[INFO] [stderr] 56 |         tokens: tokens,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: replace it with: `tokens`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lexer.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 |     return tokens;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return Expression::Predicate(Box::new(predicate));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expression::Predicate(Box::new(predicate))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interpreter.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return result.unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interpreter.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return result.unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:23:54
[INFO] [stderr]    |
[INFO] [stderr] 23 |             Operator::Greater => if l_val > r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_true.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:23:91
[INFO] [stderr]    |
[INFO] [stderr] 23 |             Operator::Greater => if l_val > r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:24:54
[INFO] [stderr]    |
[INFO] [stderr] 24 |             Operator::Less    => if l_val < r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_true.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:24:91
[INFO] [stderr]    |
[INFO] [stderr] 24 |             Operator::Less    => if l_val < r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:25:55
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_true.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:25:92
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:38:3
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:55:3
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return self.list.iter().fold(0, |acc,f| if f.evaluate_no_expression() { acc + 1 } else { acc } )
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.iter().fold(0, |acc,f| if f.evaluate_no_expression() { acc + 1 } else { acc } )`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lexer.rs:125:5
[INFO] [stderr]     |
[INFO] [stderr] 125 |     return tokens;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `tokens`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 |     return Expression::Predicate(Box::new(predicate));
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Expression::Predicate(Box::new(predicate))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interpreter.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return result.unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/interpreter.rs:31:5
[INFO] [stderr]    |
[INFO] [stderr] 31 |     return result.unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:23:54
[INFO] [stderr]    |
[INFO] [stderr] 23 |             Operator::Greater => if l_val > r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_true.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:23:91
[INFO] [stderr]    |
[INFO] [stderr] 23 |             Operator::Greater => if l_val > r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:24:54
[INFO] [stderr]    |
[INFO] [stderr] 24 |             Operator::Less    => if l_val < r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_true.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:24:91
[INFO] [stderr]    |
[INFO] [stderr] 24 |             Operator::Less    => if l_val < r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:25:55
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_true.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:25:92
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.if_false.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:38:3
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return false;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/predicate.rs:55:3
[INFO] [stderr]    |
[INFO] [stderr] 55 |         return self.list.iter().fold(0, |acc,f| if f.evaluate_no_expression() { acc + 1 } else { acc } )
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.iter().fold(0, |acc,f| if f.evaluate_no_expression() { acc + 1 } else { acc } )`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `l`
[INFO] [stderr]   --> src/environment_parser.rs:26:7
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let l = subs.len();
[INFO] [stderr]    |             ^ help: consider using `_l` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn parse_conditional(mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]    |                      ----^^^^^^
[INFO] [stderr]    |                      |
[INFO] [stderr]    |                      help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:47:27
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn parse_simple_predicate(mut tokens: &mut Vec<Token>, environment: &Environment) -> Predicate {
[INFO] [stderr]    |                           ----^^^^^^
[INFO] [stderr]    |                           |
[INFO] [stderr]    |                           help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:83:56
[INFO] [stderr]    |
[INFO] [stderr] 83 | fn parse_compound_predicate(ct: CompoundPredicateType, mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]    |                                                        ----^^^^^^
[INFO] [stderr]    |                                                        |
[INFO] [stderr]    |                                                        help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/parser.rs:123:34
[INFO] [stderr]     |
[INFO] [stderr] 123 | fn parse_function(fname: String, mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]     |                                  ----^^^^^^
[INFO] [stderr]     |                                  |
[INFO] [stderr]     |                                  help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/parser.rs:139:19
[INFO] [stderr]     |
[INFO] [stderr] 139 | fn parse_compound(mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]     |                   ----^^^^^^
[INFO] [stderr]     |                   |
[INFO] [stderr]     |                   help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/parser.rs:181:14
[INFO] [stderr]     |
[INFO] [stderr] 181 | pub fn parse(mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]     |              ----^^^^^^
[INFO] [stderr]     |              |
[INFO] [stderr]     |              help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]  --> src/environment_parser.rs:9:26
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn parse_to_function(mut v: &mut Vec<Token>) -> (String,Function) {
[INFO] [stderr]   |                          ----^
[INFO] [stderr]   |                          |
[INFO] [stderr]   |                          help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:60:26
[INFO] [stderr]    |
[INFO] [stderr] 60 | pub fn parse_to_variable(mut v: &mut Vec<Token>, environment: &Environment) -> (String,Expression) {
[INFO] [stderr]    |                          ----^
[INFO] [stderr]    |                          |
[INFO] [stderr]    |                          help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:84:29
[INFO] [stderr]    |
[INFO] [stderr] 84 | pub fn parse_to_environment(mut v: &mut Vec<Token>) -> Environment {
[INFO] [stderr]    |                             ----^
[INFO] [stderr]    |                             |
[INFO] [stderr]    |                             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |     let mut hash: HashMap<String,Expression> = HashMap::new();
[INFO] [stderr]    |         ----^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:88:6
[INFO] [stderr]    |
[INFO] [stderr] 88 |     let mut func: HashMap<String,Function> = HashMap::new();
[INFO] [stderr]    |         ----^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lexer.rs:69:31
[INFO] [stderr]    |
[INFO] [stderr] 69 | fn get_constant_or_keyword(v: &Vec<char>) -> Token {
[INFO] [stderr]    |                               ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lexer.rs:121:8
[INFO] [stderr]     |
[INFO] [stderr] 121 |     if accumulation.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!accumulation.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     match e {
[INFO] [stderr] 15 | |         &Expression::Number(a)            => Ok(a),
[INFO] [stderr] 16 | |         &Expression::Plus(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)),
[INFO] [stderr] 17 | |         &Expression::Mult(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)),
[INFO] [stderr] 18 | |         &Expression::Predicate(ref p)     => evaluate(&p.evaluate()),
[INFO] [stderr] 19 | |         &Expression::CompoundPredicate(ref c) => evaluate(&c.evaluate()),
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr] warning: unused variable: `l`
[INFO] [stderr]   --> src/environment_parser.rs:26:7
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let l = subs.len();
[INFO] [stderr]    |             ^ help: consider using `_l` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 14 |     match *e {
[INFO] [stderr] 15 |         Expression::Number(a)            => Ok(a),
[INFO] [stderr] 16 |         Expression::Plus(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)),
[INFO] [stderr] 17 |         Expression::Mult(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)),
[INFO] [stderr] 18 |         Expression::Predicate(ref p)     => evaluate(&p.evaluate()),
[INFO] [stderr] 19 |         Expression::CompoundPredicate(ref c) => evaluate(&c.evaluate()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser.rs:95:3
[INFO] [stderr]    |
[INFO] [stderr] 95 |           match tokens[0] {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 96 | |             Token::RParen => break,
[INFO] [stderr] 97 | |             _ => {},
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Token::RParen = tokens[0] { break }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:127:3
[INFO] [stderr]     |
[INFO] [stderr] 127 |           match tokens.get(0).unwrap() { 
[INFO] [stderr]     |  _________^
[INFO] [stderr] 128 | |             &Token::RParen => (break),
[INFO] [stderr] 129 | |             _ => {args.push(parse(tokens,environment))},
[INFO] [stderr] 130 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 127 |         match *tokens.get(0).unwrap() { 
[INFO] [stderr] 128 |             Token::RParen => (break),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/parser.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 |         match tokens.get(0).unwrap() { 
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         match tokens.get(0).unwrap() {
[INFO] [stderr] 157 | |             &Token::RParen     => break,
[INFO] [stderr] 158 | |             _                  => expressions.push(parse(tokens, environment)),
[INFO] [stderr] 159 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |         match *tokens.get(0).unwrap() {
[INFO] [stderr] 157 |             Token::RParen     => break,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/parser.rs:156:15
[INFO] [stderr]     |
[INFO] [stderr] 156 |         match tokens.get(0).unwrap() {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: variable `functionHash` should have a snake case name such as `function_hash`
[INFO] [stderr]   --> src/interpreter.rs:26:6
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let functionHash: HashMap<String, Function> = HashMap::new();
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/environment_parser.rs:35:10
[INFO] [stderr]    |
[INFO] [stderr] 35 |     assert!(subs.len() > 0);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!subs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | fn parse_conditional(mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]    |                      ----^^^^^^
[INFO] [stderr]    |                      |
[INFO] [stderr]    |                      help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/environment_parser.rs:92:8
[INFO] [stderr]    |
[INFO] [stderr] 92 |     while v.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/environment_parser.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |         let def = v.get(1).unwrap().clone();
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try this: `&v[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/environment_parser.rs:97:29
[INFO] [stderr]     |
[INFO] [stderr] 97  |               Token::Keyword(ref k) => match k{
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 98  | |                 &Keyword::Define => { let (name,expr) = parse_to_variable(v,&environment); environment.variables.insert(name, expr); },
[INFO] [stderr] 99  | |                 &Keyword::Deffun => { let (name,func) = parse_to_function(v);              environment.functions.insert(name, func); },
[INFO] [stderr] 100 | |                 _ => panic!("otherwise unknown keyword"), 
[INFO] [stderr] 101 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 97  |             Token::Keyword(ref k) => match *k{
[INFO] [stderr] 98  |                 Keyword::Define => { let (name,expr) = parse_to_variable(v,&environment); environment.variables.insert(name, expr); },
[INFO] [stderr] 99  |                 Keyword::Deffun => { let (name,func) = parse_to_function(v);              environment.functions.insert(name, func); },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/predicate.rs:25:37
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(l_val - r_val).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/predicate.rs:25:37
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/predicate.rs:35:37
[INFO] [stderr]    |
[INFO] [stderr] 35 |             Operator::Equal   => if l_val == r_val  { return true } else {},
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(l_val - r_val).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/predicate.rs:35:37
[INFO] [stderr]    |
[INFO] [stderr] 35 |             Operator::Equal   => if l_val == r_val  { return true } else {},
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:47:27
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn parse_simple_predicate(mut tokens: &mut Vec<Token>, environment: &Environment) -> Predicate {
[INFO] [stderr]    |                           ----^^^^^^
[INFO] [stderr]    |                           |
[INFO] [stderr]    |                           help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:83:56
[INFO] [stderr]    |
[INFO] [stderr] 83 | fn parse_compound_predicate(ct: CompoundPredicateType, mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]    |                                                        ----^^^^^^
[INFO] [stderr]    |                                                        |
[INFO] [stderr]    |                                                        help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/parser.rs:123:34
[INFO] [stderr]     |
[INFO] [stderr] 123 | fn parse_function(fname: String, mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]     |                                  ----^^^^^^
[INFO] [stderr]     |                                  |
[INFO] [stderr]     |                                  help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/parser.rs:139:19
[INFO] [stderr]     |
[INFO] [stderr] 139 | fn parse_compound(mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]     |                   ----^^^^^^
[INFO] [stderr]     |                   |
[INFO] [stderr]     |                   help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/parser.rs:181:14
[INFO] [stderr]     |
[INFO] [stderr] 181 | pub fn parse(mut tokens: &mut Vec<Token>, environment: &Environment) -> Expression {
[INFO] [stderr]     |              ----^^^^^^
[INFO] [stderr]     |              |
[INFO] [stderr]     |              help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `args`
[INFO] [stderr]   --> src/function.rs:22:12
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for i in 0..args.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for (i, <item>) in args.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]  --> src/environment_parser.rs:9:26
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn parse_to_function(mut v: &mut Vec<Token>) -> (String,Function) {
[INFO] [stderr]   |                          ----^
[INFO] [stderr]   |                          |
[INFO] [stderr]   |                          help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:60:26
[INFO] [stderr]    |
[INFO] [stderr] 60 | pub fn parse_to_variable(mut v: &mut Vec<Token>, environment: &Environment) -> (String,Expression) {
[INFO] [stderr]    |                          ----^
[INFO] [stderr]    |                          |
[INFO] [stderr]    |                          help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:84:29
[INFO] [stderr]    |
[INFO] [stderr] 84 | pub fn parse_to_environment(mut v: &mut Vec<Token>) -> Environment {
[INFO] [stderr]    |                             ----^
[INFO] [stderr]    |                             |
[INFO] [stderr]    |                             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:87:9
[INFO] [stderr]    |
[INFO] [stderr] 87 |     let mut hash: HashMap<String,Expression> = HashMap::new();
[INFO] [stderr]    |         ----^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/environment_parser.rs:88:6
[INFO] [stderr]    |
[INFO] [stderr] 88 |     let mut func: HashMap<String,Function> = HashMap::new();
[INFO] [stderr]    |         ----^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `updated_scheme`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lexer.rs:69:31
[INFO] [stderr]    |
[INFO] [stderr] 69 | fn get_constant_or_keyword(v: &Vec<char>) -> Token {
[INFO] [stderr]    |                               ^^^^^^^^^^ help: change this to: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lexer.rs:121:8
[INFO] [stderr]     |
[INFO] [stderr] 121 |     if accumulation.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!accumulation.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/evaluator.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     match e {
[INFO] [stderr] 15 | |         &Expression::Number(a)            => Ok(a),
[INFO] [stderr] 16 | |         &Expression::Plus(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)),
[INFO] [stderr] 17 | |         &Expression::Mult(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)),
[INFO] [stderr] 18 | |         &Expression::Predicate(ref p)     => evaluate(&p.evaluate()),
[INFO] [stderr] 19 | |         &Expression::CompoundPredicate(ref c) => evaluate(&c.evaluate()),
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 14 |     match *e {
[INFO] [stderr] 15 |         Expression::Number(a)            => Ok(a),
[INFO] [stderr] 16 |         Expression::Plus(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(0.0, |acc, x| acc+x)),
[INFO] [stderr] 17 |         Expression::Mult(ref v)          => Ok(v.iter().map(|y| evaluate(y).ok().unwrap()).fold(1.0, |acc, x| acc*x)),
[INFO] [stderr] 18 |         Expression::Predicate(ref p)     => evaluate(&p.evaluate()),
[INFO] [stderr] 19 |         Expression::CompoundPredicate(ref c) => evaluate(&c.evaluate()),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser.rs:95:3
[INFO] [stderr]    |
[INFO] [stderr] 95 |           match tokens[0] {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 96 | |             Token::RParen => break,
[INFO] [stderr] 97 | |             _ => {},
[INFO] [stderr] 98 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Token::RParen = tokens[0] { break }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:127:3
[INFO] [stderr]     |
[INFO] [stderr] 127 |           match tokens.get(0).unwrap() { 
[INFO] [stderr]     |  _________^
[INFO] [stderr] 128 | |             &Token::RParen => (break),
[INFO] [stderr] 129 | |             _ => {args.push(parse(tokens,environment))},
[INFO] [stderr] 130 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 127 |         match *tokens.get(0).unwrap() { 
[INFO] [stderr] 128 |             Token::RParen => (break),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/parser.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 |         match tokens.get(0).unwrap() { 
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/parser.rs:156:9
[INFO] [stderr]     |
[INFO] [stderr] 156 | /         match tokens.get(0).unwrap() {
[INFO] [stderr] 157 | |             &Token::RParen     => break,
[INFO] [stderr] 158 | |             _                  => expressions.push(parse(tokens, environment)),
[INFO] [stderr] 159 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |         match *tokens.get(0).unwrap() {
[INFO] [stderr] 157 |             Token::RParen     => break,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/parser.rs:156:15
[INFO] [stderr]     |
[INFO] [stderr] 156 |         match tokens.get(0).unwrap() {
[INFO] [stderr]     |               ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tokens[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: variable `functionHash` should have a snake case name such as `function_hash`
[INFO] [stderr]   --> src/interpreter.rs:26:6
[INFO] [stderr]    |
[INFO] [stderr] 26 |     let functionHash: HashMap<String, Function> = HashMap::new();
[INFO] [stderr]    |         ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/environment_parser.rs:35:10
[INFO] [stderr]    |
[INFO] [stderr] 35 |     assert!(subs.len() > 0);
[INFO] [stderr]    |             ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!subs.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/environment_parser.rs:92:8
[INFO] [stderr]    |
[INFO] [stderr] 92 |     while v.len() > 0 {
[INFO] [stderr]    |           ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/environment_parser.rs:95:13
[INFO] [stderr]    |
[INFO] [stderr] 95 |         let def = v.get(1).unwrap().clone();
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: try this: `&v[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/environment_parser.rs:97:29
[INFO] [stderr]     |
[INFO] [stderr] 97  |               Token::Keyword(ref k) => match k{
[INFO] [stderr]     |  ______________________________________^
[INFO] [stderr] 98  | |                 &Keyword::Define => { let (name,expr) = parse_to_variable(v,&environment); environment.variables.insert(name, expr); },
[INFO] [stderr] 99  | |                 &Keyword::Deffun => { let (name,func) = parse_to_function(v);              environment.functions.insert(name, func); },
[INFO] [stderr] 100 | |                 _ => panic!("otherwise unknown keyword"), 
[INFO] [stderr] 101 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 97  |             Token::Keyword(ref k) => match *k{
[INFO] [stderr] 98  |                 Keyword::Define => { let (name,expr) = parse_to_variable(v,&environment); environment.variables.insert(name, expr); },
[INFO] [stderr] 99  |                 Keyword::Deffun => { let (name,func) = parse_to_function(v);              environment.functions.insert(name, func); },
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/predicate.rs:25:37
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(l_val - r_val).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/predicate.rs:25:37
[INFO] [stderr]    |
[INFO] [stderr] 25 |             Operator::Equal   => if l_val == r_val  { return self.if_true.clone() } else { return self.if_false.clone() },
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]   --> src/predicate.rs:35:37
[INFO] [stderr]    |
[INFO] [stderr] 35 |             Operator::Equal   => if l_val == r_val  { return true } else {},
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(l_val - r_val).abs() < error`
[INFO] [stderr]    |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]   --> src/predicate.rs:35:37
[INFO] [stderr]    |
[INFO] [stderr] 35 |             Operator::Equal   => if l_val == r_val  { return true } else {},
[INFO] [stderr]    |                                     ^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `args`
[INFO] [stderr]   --> src/function.rs:22:12
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for i in 0..args.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for (i, <item>) in args.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `updated_scheme`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "c7f700ba0410026826eacaff189fdb08716ec3d4ab0bd7194fc36ee08fbdd060"`
[INFO] running `"docker" "rm" "-f" "c7f700ba0410026826eacaff189fdb08716ec3d4ab0bd7194fc36ee08fbdd060"`
[INFO] [stdout] c7f700ba0410026826eacaff189fdb08716ec3d4ab0bd7194fc36ee08fbdd060