[INFO] updating cached repository rmbreak/life-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rmbreak/life-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rmbreak/life-rs" "work/ex/clippy-test-run/sources/stable/gh/rmbreak/life-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rmbreak/life-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rmbreak/life-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmbreak/life-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmbreak/life-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 229e0eee8369007ceff30d4f82e7e44d48bf2ee0 [INFO] sha for GitHub repo rmbreak/life-rs: 229e0eee8369007ceff30d4f82e7e44d48bf2ee0 [INFO] validating manifest of rmbreak/life-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rmbreak/life-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rmbreak/life-rs [INFO] finished frobbing rmbreak/life-rs [INFO] frobbed toml for rmbreak/life-rs written to work/ex/clippy-test-run/sources/stable/gh/rmbreak/life-rs/Cargo.toml [INFO] started frobbing rmbreak/life-rs [INFO] finished frobbing rmbreak/life-rs [INFO] frobbed toml for rmbreak/life-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmbreak/life-rs/Cargo.toml [INFO] crate rmbreak/life-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rmbreak/life-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rmbreak/life-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3b8ec7836496339f3878480c94fea39c227ff412798fb14cf201304fcf8dc0e [INFO] running `"docker" "start" "-a" "f3b8ec7836496339f3878480c94fea39c227ff412798fb14cf201304fcf8dc0e"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | cells: cells, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | input_rx: input_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:82:73 [INFO] [stderr] | [INFO] [stderr] 82 | print!("{}{}", termion::cursor::Goto(x, y), 'o'); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:85:73 [INFO] [stderr] | [INFO] [stderr] 85 | print!("{}{}", termion::cursor::Goto(x, y), ' '); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | ' ' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:167:25 [INFO] [stderr] | [INFO] [stderr] 167 | ' ' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | 'o' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | cells: cells, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | input_rx: input_rx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `input_rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:82:73 [INFO] [stderr] | [INFO] [stderr] 82 | print!("{}{}", termion::cursor::Goto(x, y), 'o'); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:85:73 [INFO] [stderr] | [INFO] [stderr] 85 | print!("{}{}", termion::cursor::Goto(x, y), ' '); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | ' ' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:167:25 [INFO] [stderr] | [INFO] [stderr] 167 | ' ' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/main.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | 'o' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `cells`. [INFO] [stderr] --> src/main.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..height as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in cells.iter_mut().take(height as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:161:87 [INFO] [stderr] | [INFO] [stderr] 161 | } else if self.cells[i][j].state == CellState::ALIVE && neighbors > 3 { [INFO] [stderr] | _______________________________________________________________________________________^ [INFO] [stderr] 162 | | // die [INFO] [stderr] 163 | | self.cells[i][j].state = CellState::DEAD; [INFO] [stderr] 164 | | print!( [INFO] [stderr] ... | [INFO] [stderr] 168 | | ); [INFO] [stderr] 169 | | } else if self.cells[i][j].state == CellState::DEAD && neighbors == 3 { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:153:80 [INFO] [stderr] | [INFO] [stderr] 153 | if self.cells[i][j].state == CellState::ALIVE && neighbors < 2 { [INFO] [stderr] | ________________________________________________________________________________^ [INFO] [stderr] 154 | | // die [INFO] [stderr] 155 | | self.cells[i][j].state = CellState::DEAD; [INFO] [stderr] 156 | | print!( [INFO] [stderr] ... | [INFO] [stderr] 160 | | ); [INFO] [stderr] 161 | | } else if self.cells[i][j].state == CellState::ALIVE && neighbors > 3 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `life`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is only used to index `cells`. [INFO] [stderr] --> src/main.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..height as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for in cells.iter_mut().take(height as usize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/main.rs:161:87 [INFO] [stderr] | [INFO] [stderr] 161 | } else if self.cells[i][j].state == CellState::ALIVE && neighbors > 3 { [INFO] [stderr] | _______________________________________________________________________________________^ [INFO] [stderr] 162 | | // die [INFO] [stderr] 163 | | self.cells[i][j].state = CellState::DEAD; [INFO] [stderr] 164 | | print!( [INFO] [stderr] ... | [INFO] [stderr] 168 | | ); [INFO] [stderr] 169 | | } else if self.cells[i][j].state == CellState::DEAD && neighbors == 3 { [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/main.rs:153:80 [INFO] [stderr] | [INFO] [stderr] 153 | if self.cells[i][j].state == CellState::ALIVE && neighbors < 2 { [INFO] [stderr] | ________________________________________________________________________________^ [INFO] [stderr] 154 | | // die [INFO] [stderr] 155 | | self.cells[i][j].state = CellState::DEAD; [INFO] [stderr] 156 | | print!( [INFO] [stderr] ... | [INFO] [stderr] 160 | | ); [INFO] [stderr] 161 | | } else if self.cells[i][j].state == CellState::ALIVE && neighbors > 3 { [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `life`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f3b8ec7836496339f3878480c94fea39c227ff412798fb14cf201304fcf8dc0e"` [INFO] running `"docker" "rm" "-f" "f3b8ec7836496339f3878480c94fea39c227ff412798fb14cf201304fcf8dc0e"` [INFO] [stdout] f3b8ec7836496339f3878480c94fea39c227ff412798fb14cf201304fcf8dc0e