[INFO] updating cached repository rlupton20/csv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rlupton20/csv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rlupton20/csv" "work/ex/clippy-test-run/sources/stable/gh/rlupton20/csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rlupton20/csv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rlupton20/csv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/csv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/csv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e966ea1cca9526824260e2be56f0da53e1b541cc [INFO] sha for GitHub repo rlupton20/csv: e966ea1cca9526824260e2be56f0da53e1b541cc [INFO] validating manifest of rlupton20/csv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rlupton20/csv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rlupton20/csv [INFO] finished frobbing rlupton20/csv [INFO] frobbed toml for rlupton20/csv written to work/ex/clippy-test-run/sources/stable/gh/rlupton20/csv/Cargo.toml [INFO] started frobbing rlupton20/csv [INFO] finished frobbing rlupton20/csv [INFO] frobbed toml for rlupton20/csv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/csv/Cargo.toml [INFO] crate rlupton20/csv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rlupton20/csv against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rlupton20/csv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d12b2c359dd5cdf34932277264e736944cc4bdefaee1a90f0ffe7e4ea57ec8e9 [INFO] running `"docker" "start" "-a" "d12b2c359dd5cdf34932277264e736944cc4bdefaee1a90f0ffe7e4ea57ec8e9"` [INFO] [stderr] Checking unicode-segmentation v1.2.0 [INFO] [stderr] Checking textwrap v0.7.0 [INFO] [stderr] Checking clap v2.26.0 [INFO] [stderr] Checking csv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/flag_last.rs:64:12 [INFO] [stderr] | [INFO] [stderr] 64 | if let None = iterator.next() { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 65 | | // All is well [INFO] [stderr] 66 | | } else { [INFO] [stderr] 67 | | assert!(false); [INFO] [stderr] 68 | | } [INFO] [stderr] | |_____- help: try this: `if iterator.next().is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | fn locate(s: &str, v: &Vec<&str>) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | fn get_column_indices(headings: &Vec<&str>, seek: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:69:51 [INFO] [stderr] | [INFO] [stderr] 69 | fn get_column_indices(headings: &Vec<&str>, seek: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:60:23 [INFO] [stderr] | [INFO] [stderr] 60 | fn locate(s: &str, v: &Vec<&str>) -> Option { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | fn get_column_indices(headings: &Vec<&str>, seek: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:69:51 [INFO] [stderr] | [INFO] [stderr] 69 | fn get_column_indices(headings: &Vec<&str>, seek: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.65s [INFO] running `"docker" "inspect" "d12b2c359dd5cdf34932277264e736944cc4bdefaee1a90f0ffe7e4ea57ec8e9"` [INFO] running `"docker" "rm" "-f" "d12b2c359dd5cdf34932277264e736944cc4bdefaee1a90f0ffe7e4ea57ec8e9"` [INFO] [stdout] d12b2c359dd5cdf34932277264e736944cc4bdefaee1a90f0ffe7e4ea57ec8e9