[INFO] updating cached repository rkoeninger/pkmn [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rkoeninger/pkmn [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rkoeninger/pkmn" "work/ex/clippy-test-run/sources/stable/gh/rkoeninger/pkmn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rkoeninger/pkmn'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rkoeninger/pkmn" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rkoeninger/pkmn"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rkoeninger/pkmn'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 979cea5c99c83b12b4eb36a5f45821a9c54fa08e [INFO] sha for GitHub repo rkoeninger/pkmn: 979cea5c99c83b12b4eb36a5f45821a9c54fa08e [INFO] validating manifest of rkoeninger/pkmn on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rkoeninger/pkmn on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rkoeninger/pkmn [INFO] finished frobbing rkoeninger/pkmn [INFO] frobbed toml for rkoeninger/pkmn written to work/ex/clippy-test-run/sources/stable/gh/rkoeninger/pkmn/Cargo.toml [INFO] started frobbing rkoeninger/pkmn [INFO] finished frobbing rkoeninger/pkmn [INFO] frobbed toml for rkoeninger/pkmn written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rkoeninger/pkmn/Cargo.toml [INFO] crate rkoeninger/pkmn has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rkoeninger/pkmn against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rkoeninger/pkmn:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce8e0d4c503e84ddd2b6d6d70bb364b84bc61376e0328eeaea6ac798521de53c [INFO] running `"docker" "start" "-a" "ce8e0d4c503e84ddd2b6d6d70bb364b84bc61376e0328eeaea6ac798521de53c"` [INFO] [stderr] Checking text_io v0.1.6 [INFO] [stderr] Checking pkmn v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/main.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | None => writeln!(f, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/main.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | None => writeln!(f, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `By` [INFO] [stderr] --> src/main.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | / enum TransformMode { [INFO] [stderr] 36 | | ByLevel(u32), [INFO] [stderr] 37 | | ByStone(StoneType), [INFO] [stderr] 38 | | ByTrade [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Stone` [INFO] [stderr] --> src/main.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / enum StoneType { [INFO] [stderr] 42 | | FireStone, [INFO] [stderr] 43 | | WaterStone, [INFO] [stderr] 44 | | ThunderStone, [INFO] [stderr] 45 | | LeafStone, [INFO] [stderr] 46 | | MoonStone [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `By` [INFO] [stderr] --> src/main.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | / enum TransformMode { [INFO] [stderr] 36 | | ByLevel(u32), [INFO] [stderr] 37 | | ByStone(StoneType), [INFO] [stderr] 38 | | ByTrade [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Stone` [INFO] [stderr] --> src/main.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / enum StoneType { [INFO] [stderr] 42 | | FireStone, [INFO] [stderr] 43 | | WaterStone, [INFO] [stderr] 44 | | ThunderStone, [INFO] [stderr] 45 | | LeafStone, [INFO] [stderr] 46 | | MoonStone [INFO] [stderr] 47 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | if line == "quit".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"quit"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:163:13 [INFO] [stderr] | [INFO] [stderr] 163 | if line == "quit".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `"quit"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:203:19 [INFO] [stderr] | [INFO] [stderr] 203 | .position(|r| (**r).name.to_string() == room_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**r).name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | let room = (*current).paths.iter().nth(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:220:19 [INFO] [stderr] | [INFO] [stderr] 220 | .position(|t| t.name.to_string() == thing_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `t.name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:223:18 [INFO] [stderr] | [INFO] [stderr] 223 | let thing = (*current).things.iter().nth(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:203:19 [INFO] [stderr] | [INFO] [stderr] 203 | .position(|r| (**r).name.to_string() == room_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**r).name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | let room = (*current).paths.iter().nth(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_nth)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:220:19 [INFO] [stderr] | [INFO] [stderr] 220 | .position(|t| t.name.to_string() == thing_name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `t.name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable [INFO] [stderr] --> src/main.rs:223:18 [INFO] [stderr] | [INFO] [stderr] 223 | let thing = (*current).things.iter().nth(index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.12s [INFO] running `"docker" "inspect" "ce8e0d4c503e84ddd2b6d6d70bb364b84bc61376e0328eeaea6ac798521de53c"` [INFO] running `"docker" "rm" "-f" "ce8e0d4c503e84ddd2b6d6d70bb364b84bc61376e0328eeaea6ac798521de53c"` [INFO] [stdout] ce8e0d4c503e84ddd2b6d6d70bb364b84bc61376e0328eeaea6ac798521de53c