[INFO] updating cached repository rjmholt/mips-disasm-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/rjmholt/mips-disasm-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/rjmholt/mips-disasm-rust" "work/ex/clippy-test-run/sources/stable/gh/rjmholt/mips-disasm-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rjmholt/mips-disasm-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/rjmholt/mips-disasm-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjmholt/mips-disasm-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjmholt/mips-disasm-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a26360d906f4b7a2bd57e00702baa590ed8ff044 [INFO] sha for GitHub repo rjmholt/mips-disasm-rust: a26360d906f4b7a2bd57e00702baa590ed8ff044 [INFO] validating manifest of rjmholt/mips-disasm-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rjmholt/mips-disasm-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rjmholt/mips-disasm-rust [INFO] finished frobbing rjmholt/mips-disasm-rust [INFO] frobbed toml for rjmholt/mips-disasm-rust written to work/ex/clippy-test-run/sources/stable/gh/rjmholt/mips-disasm-rust/Cargo.toml [INFO] started frobbing rjmholt/mips-disasm-rust [INFO] finished frobbing rjmholt/mips-disasm-rust [INFO] frobbed toml for rjmholt/mips-disasm-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjmholt/mips-disasm-rust/Cargo.toml [INFO] crate rjmholt/mips-disasm-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rjmholt/mips-disasm-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rjmholt/mips-disasm-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a947c0eb4c2e941a23480630d92ef2e237fa8108279a868f2663c91306dd1a14 [INFO] running `"docker" "start" "-a" "a947c0eb4c2e941a23480630d92ef2e237fa8108279a868f2663c91306dd1a14"` [INFO] [stderr] Checking mips v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:13:35 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Instr::AddI(AddI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:13:43 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Instr::AddI(AddI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:13:51 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Instr::AddI(AddI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Instr::AddIU(AddIU { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Instr::AddIU(AddIU { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:18:53 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Instr::AddIU(AddIU { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Instr::AndI(AndI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:23:43 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Instr::AndI(AndI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Instr::AndI(AndI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(Instr::BEq(BEq { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:28:41 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(Instr::BEq(BEq { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:28:49 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(Instr::BEq(BEq { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(Instr::BGTZ(BGTZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:33:43 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(Instr::BGTZ(BGTZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instr::BLEZ(BLEZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instr::BLEZ(BLEZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Instr::BNE(BNE { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Instr::BNE(BNE { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:43:49 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Instr::BNE(BNE { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(Instr::J(J { addr: addr })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | Ok(Instr::JaL(JaL { addr: addr })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(Instr::LB(LB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:58:39 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(Instr::LB(LB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:58:47 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(Instr::LB(LB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | Ok(Instr::LUI(LUI { rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:63:41 [INFO] [stderr] | [INFO] [stderr] 63 | Ok(Instr::LUI(LUI { rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Instr::LW(LW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Instr::LW(LW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:68:47 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Instr::LW(LW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(Instr::OrI(OrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:73:41 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(Instr::OrI(OrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:73:49 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(Instr::OrI(OrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(Instr::SB(SB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(Instr::SB(SB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(Instr::SB(SB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(Instr::SW(SW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(Instr::SW(SW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(Instr::SW(SW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Instr::XOrI(XOrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:88:43 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Instr::XOrI(XOrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:88:51 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Instr::XOrI(XOrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:94:46 [INFO] [stderr] | [INFO] [stderr] 94 | F_MUL => Ok(Instr::Mul(Mul { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:94:54 [INFO] [stderr] | [INFO] [stderr] 94 | F_MUL => Ok(Instr::Mul(Mul { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:94:62 [INFO] [stderr] | [INFO] [stderr] 94 | F_MUL => Ok(Instr::Mul(Mul { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:104:50 [INFO] [stderr] | [INFO] [stderr] 104 | RT_BGEZ => Ok(Instr::BGEZ(BGEZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:104:58 [INFO] [stderr] | [INFO] [stderr] 104 | RT_BGEZ => Ok(Instr::BGEZ(BGEZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:106:50 [INFO] [stderr] | [INFO] [stderr] 106 | RT_BLTZ => Ok(Instr::BLTZ(BLTZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:106:58 [INFO] [stderr] | [INFO] [stderr] 106 | RT_BLTZ => Ok(Instr::BLTZ(BLTZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | F_ADD => Ok(Instr::Add(Add { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:124:50 [INFO] [stderr] | [INFO] [stderr] 124 | F_ADD => Ok(Instr::Add(Add { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:124:58 [INFO] [stderr] | [INFO] [stderr] 124 | F_ADD => Ok(Instr::Add(Add { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | F_ADDU => Ok(Instr::AddU(AddU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | F_ADDU => Ok(Instr::AddU(AddU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:126:60 [INFO] [stderr] | [INFO] [stderr] 126 | F_ADDU => Ok(Instr::AddU(AddU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:128:42 [INFO] [stderr] | [INFO] [stderr] 128 | F_AND => Ok(Instr::And(And { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:128:50 [INFO] [stderr] | [INFO] [stderr] 128 | F_AND => Ok(Instr::And(And { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:128:58 [INFO] [stderr] | [INFO] [stderr] 128 | F_AND => Ok(Instr::And(And { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:130:44 [INFO] [stderr] | [INFO] [stderr] 130 | F_JALR => Ok(Instr::JaLR(JaLR { rs: rs, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:130:52 [INFO] [stderr] | [INFO] [stderr] 130 | F_JALR => Ok(Instr::JaLR(JaLR { rs: rs, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | F_JR => Ok(Instr::JR(JR { rs: rs })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:134:40 [INFO] [stderr] | [INFO] [stderr] 134 | F_OR => Ok(Instr::Or(Or { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:134:48 [INFO] [stderr] | [INFO] [stderr] 134 | F_OR => Ok(Instr::Or(Or { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:134:56 [INFO] [stderr] | [INFO] [stderr] 134 | F_OR => Ok(Instr::Or(Or { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:136:42 [INFO] [stderr] | [INFO] [stderr] 136 | F_SLT => Ok(Instr::SLT(SLT { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:136:50 [INFO] [stderr] | [INFO] [stderr] 136 | F_SLT => Ok(Instr::SLT(SLT { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | F_SLT => Ok(Instr::SLT(SLT { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:138:42 [INFO] [stderr] | [INFO] [stderr] 138 | F_SRA => Ok(Instr::SRA(SRA { rt: rt, rd: rd, shamt: shamt })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:138:50 [INFO] [stderr] | [INFO] [stderr] 138 | F_SRA => Ok(Instr::SRA(SRA { rt: rt, rd: rd, shamt: shamt })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:138:58 [INFO] [stderr] | [INFO] [stderr] 138 | F_SRA => Ok(Instr::SRA(SRA { rt: rt, rd: rd, shamt: shamt })), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shamt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:140:42 [INFO] [stderr] | [INFO] [stderr] 140 | F_SUB => Ok(Instr::Sub(Sub { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:140:50 [INFO] [stderr] | [INFO] [stderr] 140 | F_SUB => Ok(Instr::Sub(Sub { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:140:58 [INFO] [stderr] | [INFO] [stderr] 140 | F_SUB => Ok(Instr::Sub(Sub { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | F_SUBU => Ok(Instr::SubU(SubU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:142:52 [INFO] [stderr] | [INFO] [stderr] 142 | F_SUBU => Ok(Instr::SubU(SubU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:142:60 [INFO] [stderr] | [INFO] [stderr] 142 | F_SUBU => Ok(Instr::SubU(SubU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | F_XOR => Ok(Instr::XOr(XOr { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:146:50 [INFO] [stderr] | [INFO] [stderr] 146 | F_XOR => Ok(Instr::XOr(XOr { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:146:58 [INFO] [stderr] | [INFO] [stderr] 146 | F_XOR => Ok(Instr::XOr(XOr { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:150:37 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Instr::SLL(SLL { rt: rt, rd: rd, shamt: shamt })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Instr::SLL(SLL { rt: rt, rd: rd, shamt: shamt })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:150:53 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Instr::SLL(SLL { rt: rt, rd: rd, shamt: shamt })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shamt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mips/print.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | write!(f, "[0x{:08x}] 0x{:08x} {}\n", curr_addr, code, instr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mips/print.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:13:35 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Instr::AddI(AddI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:13:43 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Instr::AddI(AddI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:13:51 [INFO] [stderr] | [INFO] [stderr] 13 | Ok(Instr::AddI(AddI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:18:37 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Instr::AddIU(AddIU { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:18:45 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Instr::AddIU(AddIU { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:18:53 [INFO] [stderr] | [INFO] [stderr] 18 | Ok(Instr::AddIU(AddIU { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:23:35 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Instr::AndI(AndI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:23:43 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Instr::AndI(AndI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:23:51 [INFO] [stderr] | [INFO] [stderr] 23 | Ok(Instr::AndI(AndI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:28:33 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(Instr::BEq(BEq { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:28:41 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(Instr::BEq(BEq { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:28:49 [INFO] [stderr] | [INFO] [stderr] 28 | Ok(Instr::BEq(BEq { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:33:35 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(Instr::BGTZ(BGTZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:33:43 [INFO] [stderr] | [INFO] [stderr] 33 | Ok(Instr::BGTZ(BGTZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:38:35 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instr::BLEZ(BLEZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:38:43 [INFO] [stderr] | [INFO] [stderr] 38 | Ok(Instr::BLEZ(BLEZ { rs: rs, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Instr::BNE(BNE { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Instr::BNE(BNE { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:43:49 [INFO] [stderr] | [INFO] [stderr] 43 | Ok(Instr::BNE(BNE { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | Ok(Instr::J(J { addr: addr })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | Ok(Instr::JaL(JaL { addr: addr })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:58:31 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(Instr::LB(LB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:58:39 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(Instr::LB(LB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:58:47 [INFO] [stderr] | [INFO] [stderr] 58 | Ok(Instr::LB(LB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:63:33 [INFO] [stderr] | [INFO] [stderr] 63 | Ok(Instr::LUI(LUI { rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:63:41 [INFO] [stderr] | [INFO] [stderr] 63 | Ok(Instr::LUI(LUI { rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:68:31 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Instr::LW(LW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:68:39 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Instr::LW(LW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:68:47 [INFO] [stderr] | [INFO] [stderr] 68 | Ok(Instr::LW(LW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(Instr::OrI(OrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:73:41 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(Instr::OrI(OrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:73:49 [INFO] [stderr] | [INFO] [stderr] 73 | Ok(Instr::OrI(OrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(Instr::SB(SB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(Instr::SB(SB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | Ok(Instr::SB(SB { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:83:31 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(Instr::SW(SW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(Instr::SW(SW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:83:47 [INFO] [stderr] | [INFO] [stderr] 83 | Ok(Instr::SW(SW { rs: rs, rt: rt, off: off })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:88:35 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Instr::XOrI(XOrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:88:43 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Instr::XOrI(XOrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:88:51 [INFO] [stderr] | [INFO] [stderr] 88 | Ok(Instr::XOrI(XOrI { rs: rs, rt: rt, imm: imm })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `imm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:94:46 [INFO] [stderr] | [INFO] [stderr] 94 | F_MUL => Ok(Instr::Mul(Mul { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:94:54 [INFO] [stderr] | [INFO] [stderr] 94 | F_MUL => Ok(Instr::Mul(Mul { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:94:62 [INFO] [stderr] | [INFO] [stderr] 94 | F_MUL => Ok(Instr::Mul(Mul { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:104:50 [INFO] [stderr] | [INFO] [stderr] 104 | RT_BGEZ => Ok(Instr::BGEZ(BGEZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:104:58 [INFO] [stderr] | [INFO] [stderr] 104 | RT_BGEZ => Ok(Instr::BGEZ(BGEZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:106:50 [INFO] [stderr] | [INFO] [stderr] 106 | RT_BLTZ => Ok(Instr::BLTZ(BLTZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:106:58 [INFO] [stderr] | [INFO] [stderr] 106 | RT_BLTZ => Ok(Instr::BLTZ(BLTZ { rs: rs, off: off })), [INFO] [stderr] | ^^^^^^^^ help: replace it with: `off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:124:42 [INFO] [stderr] | [INFO] [stderr] 124 | F_ADD => Ok(Instr::Add(Add { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:124:50 [INFO] [stderr] | [INFO] [stderr] 124 | F_ADD => Ok(Instr::Add(Add { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:124:58 [INFO] [stderr] | [INFO] [stderr] 124 | F_ADD => Ok(Instr::Add(Add { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:126:44 [INFO] [stderr] | [INFO] [stderr] 126 | F_ADDU => Ok(Instr::AddU(AddU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:126:52 [INFO] [stderr] | [INFO] [stderr] 126 | F_ADDU => Ok(Instr::AddU(AddU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:126:60 [INFO] [stderr] | [INFO] [stderr] 126 | F_ADDU => Ok(Instr::AddU(AddU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:128:42 [INFO] [stderr] | [INFO] [stderr] 128 | F_AND => Ok(Instr::And(And { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:128:50 [INFO] [stderr] | [INFO] [stderr] 128 | F_AND => Ok(Instr::And(And { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:128:58 [INFO] [stderr] | [INFO] [stderr] 128 | F_AND => Ok(Instr::And(And { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:130:44 [INFO] [stderr] | [INFO] [stderr] 130 | F_JALR => Ok(Instr::JaLR(JaLR { rs: rs, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:130:52 [INFO] [stderr] | [INFO] [stderr] 130 | F_JALR => Ok(Instr::JaLR(JaLR { rs: rs, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:132:40 [INFO] [stderr] | [INFO] [stderr] 132 | F_JR => Ok(Instr::JR(JR { rs: rs })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:134:40 [INFO] [stderr] | [INFO] [stderr] 134 | F_OR => Ok(Instr::Or(Or { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:134:48 [INFO] [stderr] | [INFO] [stderr] 134 | F_OR => Ok(Instr::Or(Or { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:134:56 [INFO] [stderr] | [INFO] [stderr] 134 | F_OR => Ok(Instr::Or(Or { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:136:42 [INFO] [stderr] | [INFO] [stderr] 136 | F_SLT => Ok(Instr::SLT(SLT { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:136:50 [INFO] [stderr] | [INFO] [stderr] 136 | F_SLT => Ok(Instr::SLT(SLT { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:136:58 [INFO] [stderr] | [INFO] [stderr] 136 | F_SLT => Ok(Instr::SLT(SLT { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:138:42 [INFO] [stderr] | [INFO] [stderr] 138 | F_SRA => Ok(Instr::SRA(SRA { rt: rt, rd: rd, shamt: shamt })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:138:50 [INFO] [stderr] | [INFO] [stderr] 138 | F_SRA => Ok(Instr::SRA(SRA { rt: rt, rd: rd, shamt: shamt })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:138:58 [INFO] [stderr] | [INFO] [stderr] 138 | F_SRA => Ok(Instr::SRA(SRA { rt: rt, rd: rd, shamt: shamt })), [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shamt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:140:42 [INFO] [stderr] | [INFO] [stderr] 140 | F_SUB => Ok(Instr::Sub(Sub { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:140:50 [INFO] [stderr] | [INFO] [stderr] 140 | F_SUB => Ok(Instr::Sub(Sub { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:140:58 [INFO] [stderr] | [INFO] [stderr] 140 | F_SUB => Ok(Instr::Sub(Sub { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:142:44 [INFO] [stderr] | [INFO] [stderr] 142 | F_SUBU => Ok(Instr::SubU(SubU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:142:52 [INFO] [stderr] | [INFO] [stderr] 142 | F_SUBU => Ok(Instr::SubU(SubU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:142:60 [INFO] [stderr] | [INFO] [stderr] 142 | F_SUBU => Ok(Instr::SubU(SubU { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:146:42 [INFO] [stderr] | [INFO] [stderr] 146 | F_XOR => Ok(Instr::XOr(XOr { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:146:50 [INFO] [stderr] | [INFO] [stderr] 146 | F_XOR => Ok(Instr::XOr(XOr { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:146:58 [INFO] [stderr] | [INFO] [stderr] 146 | F_XOR => Ok(Instr::XOr(XOr { rs: rs, rt: rt, rd: rd })), [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:150:37 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Instr::SLL(SLL { rt: rt, rd: rd, shamt: shamt })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:150:45 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Instr::SLL(SLL { rt: rt, rd: rd, shamt: shamt })) [INFO] [stderr] | ^^^^^^ help: replace it with: `rd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mips/decode.rs:150:53 [INFO] [stderr] | [INFO] [stderr] 150 | Ok(Instr::SLL(SLL { rt: rt, rd: rd, shamt: shamt })) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `shamt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mips/print.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | write!(f, "[0x{:08x}] 0x{:08x} {}\n", curr_addr, code, instr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/mips/print.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/mips/read.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Error` [INFO] [stderr] --> src/mips/read.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mips/data.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | pub const TERMINATE: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mips/data.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub const START_ADDR: u32 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/mips/print.rs:5:67 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn print_instrs(f: &mut Write, instr_vec: &Vec<(u32, Instr)>) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | let mut branches = vec![0x00400024]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:116:30 [INFO] [stderr] | [INFO] [stderr] 116 | while index_to_addr(i) < 0x00400024 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/mips/read.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt::Error` [INFO] [stderr] --> src/mips/read.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use std::fmt::Error; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mips/data.rs:68:28 [INFO] [stderr] | [INFO] [stderr] 68 | pub const TERMINATE: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mips/data.rs:72:29 [INFO] [stderr] | [INFO] [stderr] 72 | pub const START_ADDR: u32 = 0x00400000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/mips/print.rs:5:67 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn print_instrs(f: &mut Write, instr_vec: &Vec<(u32, Instr)>) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:73:29 [INFO] [stderr] | [INFO] [stderr] 73 | let mut branches = vec![0x00400024]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:116:30 [INFO] [stderr] | [INFO] [stderr] 116 | while index_to_addr(i) < 0x00400024 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0040_0024` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: value assigned to `curr_addr` is never read [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | curr_addr = mips::START_ADDR; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr_addr` [INFO] [stderr] --> src/mips/data.rs:398:27 [INFO] [stderr] | [INFO] [stderr] 398 | fn branch_addr(&self, curr_addr: u32) -> u32 [INFO] [stderr] | ^^^^^^^^^ help: consider using `_curr_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr_addr` [INFO] [stderr] --> src/mips/data.rs:419:27 [INFO] [stderr] | [INFO] [stderr] 419 | fn branch_addr(&self, curr_addr: u32) -> u32 [INFO] [stderr] | ^^^^^^^^^ help: consider using `_curr_addr` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `curr_addr` is never read [INFO] [stderr] --> src/main.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | curr_addr = mips::START_ADDR; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr_addr` [INFO] [stderr] --> src/mips/data.rs:398:27 [INFO] [stderr] | [INFO] [stderr] 398 | fn branch_addr(&self, curr_addr: u32) -> u32 [INFO] [stderr] | ^^^^^^^^^ help: consider using `_curr_addr` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `curr_addr` [INFO] [stderr] --> src/mips/data.rs:419:27 [INFO] [stderr] | [INFO] [stderr] 419 | fn branch_addr(&self, curr_addr: u32) -> u32 [INFO] [stderr] | ^^^^^^^^^ help: consider using `_curr_addr` instead [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:268:26 [INFO] [stderr] | [INFO] [stderr] 268 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:290:26 [INFO] [stderr] | [INFO] [stderr] 290 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:312:26 [INFO] [stderr] | [INFO] [stderr] 312 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:334:26 [INFO] [stderr] | [INFO] [stderr] 334 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:356:26 [INFO] [stderr] | [INFO] [stderr] 356 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:379:26 [INFO] [stderr] | [INFO] [stderr] 379 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:392:33 [INFO] [stderr] | [INFO] [stderr] 392 | write!(f, "j 0x{:08x}", (BYTE_SIZE as u32) * self.addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:400:21 [INFO] [stderr] | [INFO] [stderr] 400 | self.addr * (BYTE_SIZE as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:413:35 [INFO] [stderr] | [INFO] [stderr] 413 | write!(f, "jal 0x{:08x}", (BYTE_SIZE as u32) * self.addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:421:21 [INFO] [stderr] | [INFO] [stderr] 421 | self.addr * (BYTE_SIZE as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:268:26 [INFO] [stderr] | [INFO] [stderr] 268 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:290:26 [INFO] [stderr] | [INFO] [stderr] 290 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:312:26 [INFO] [stderr] | [INFO] [stderr] 312 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:334:26 [INFO] [stderr] | [INFO] [stderr] 334 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:356:26 [INFO] [stderr] | [INFO] [stderr] 356 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:379:26 [INFO] [stderr] | [INFO] [stderr] 379 | branch_calc_goto(self.off as u32, curr_addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(self.off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:392:33 [INFO] [stderr] | [INFO] [stderr] 392 | write!(f, "j 0x{:08x}", (BYTE_SIZE as u32) * self.addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:400:21 [INFO] [stderr] | [INFO] [stderr] 400 | self.addr * (BYTE_SIZE as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:413:35 [INFO] [stderr] | [INFO] [stderr] 413 | write!(f, "jal 0x{:08x}", (BYTE_SIZE as u32) * self.addr) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:421:21 [INFO] [stderr] | [INFO] [stderr] 421 | self.addr * (BYTE_SIZE as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:698:27 [INFO] [stderr] | [INFO] [stderr] 698 | curr_addr + (offset * (BYTE_SIZE as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/data.rs:698:27 [INFO] [stderr] | [INFO] [stderr] 698 | curr_addr + (offset * (BYTE_SIZE as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mips/print.rs:5:47 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn print_instrs(f: &mut Write, instr_vec: &Vec<(u32, Instr)>) -> () [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, Instr)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mips/print.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | write!(f, "[0x{:08x}] 0x{:08x} {}\n", curr_addr, code, instr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/print.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | curr_addr += mips::BYTE_SIZE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mips::BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mips/print.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | for ref instr in &self.instrs { [INFO] [stderr] | ^^^^^^^^^ ------------ help: try: `let instr = &&self.instrs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/mips/print.rs:5:47 [INFO] [stderr] | [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] 5 | pub fn print_instrs(f: &mut Write, instr_vec: &Vec<(u32, Instr)>) -> () [INFO] [stderr] --> src/main.rs:55:24 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[(u32, Instr)]` [INFO] [stderr] | [INFO] [stderr] 55 | mips::START_ADDR + (mips::BYTE_SIZE as u32) * (index as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mips::BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match instr { [INFO] [stderr] 76 | | &mips::Instr::J(ref j) => [INFO] [stderr] 77 | | branches.push(j.branch_addr(curr_addr)), [INFO] [stderr] 78 | | &mips::Instr::JaL(ref jal) => [INFO] [stderr] ... | [INFO] [stderr] 83 | | _ => () [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *instr { [INFO] [stderr] 76 | mips::Instr::J(ref j) => [INFO] [stderr] 77 | branches.push(j.branch_addr(curr_addr)), [INFO] [stderr] 78 | mips::Instr::JaL(ref jal) => [INFO] [stderr] 79 | branches.push(jal.branch_addr(curr_addr)), [INFO] [stderr] 80 | mips::Instr::BGTZ(ref bgtz) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | curr_addr += mips::BYTE_SIZE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mips::BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / match instr_vec.pop() { [INFO] [stderr] 118 | | Some(instr) => blocks[j].instrs.push(instr.1), [INFO] [stderr] 119 | | None => () // Should break... [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(instr) = instr_vec.pop() { blocks[j].instrs.push(instr.1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match instr_vec.pop() { [INFO] [stderr] 129 | | Some(instr) => blocks[j].instrs.push(instr.1), [INFO] [stderr] 130 | | None => () [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(instr) = instr_vec.pop() { blocks[j].instrs.push(instr.1) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mips/print.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | write!(f, "[0x{:08x}] 0x{:08x} {}\n", curr_addr, code, instr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/mips/print.rs:10:22 [INFO] [stderr] | [INFO] [stderr] 10 | curr_addr += mips::BYTE_SIZE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mips::BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mips/print.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | write!(f, "\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | for ref instr in &self.instrs { [INFO] [stderr] | ^^^^^^^^^ ------------ help: try: `let instr = &&self.instrs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:55:24 [INFO] [stderr] | [INFO] [stderr] 55 | mips::START_ADDR + (mips::BYTE_SIZE as u32) * (index as u32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mips::BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match instr { [INFO] [stderr] 76 | | &mips::Instr::J(ref j) => [INFO] [stderr] 77 | | branches.push(j.branch_addr(curr_addr)), [INFO] [stderr] 78 | | &mips::Instr::JaL(ref jal) => [INFO] [stderr] ... | [INFO] [stderr] 83 | | _ => () [INFO] [stderr] 84 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 75 | match *instr { [INFO] [stderr] 76 | mips::Instr::J(ref j) => [INFO] [stderr] 77 | branches.push(j.branch_addr(curr_addr)), [INFO] [stderr] 78 | mips::Instr::JaL(ref jal) => [INFO] [stderr] 79 | branches.push(jal.branch_addr(curr_addr)), [INFO] [stderr] 80 | mips::Instr::BGTZ(ref bgtz) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | curr_addr += mips::BYTE_SIZE as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mips::BYTE_SIZE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / match instr_vec.pop() { [INFO] [stderr] 118 | | Some(instr) => blocks[j].instrs.push(instr.1), [INFO] [stderr] 119 | | None => () // Should break... [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(instr) = instr_vec.pop() { blocks[j].instrs.push(instr.1) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match instr_vec.pop() { [INFO] [stderr] 129 | | Some(instr) => blocks[j].instrs.push(instr.1), [INFO] [stderr] 130 | | None => () [INFO] [stderr] 131 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(instr) = instr_vec.pop() { blocks[j].instrs.push(instr.1) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.19s [INFO] running `"docker" "inspect" "a947c0eb4c2e941a23480630d92ef2e237fa8108279a868f2663c91306dd1a14"` [INFO] running `"docker" "rm" "-f" "a947c0eb4c2e941a23480630d92ef2e237fa8108279a868f2663c91306dd1a14"` [INFO] [stdout] a947c0eb4c2e941a23480630d92ef2e237fa8108279a868f2663c91306dd1a14