[INFO] updating cached repository rivertam/the-good-things
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/rivertam/the-good-things
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/rivertam/the-good-things" "work/ex/clippy-test-run/sources/stable/gh/rivertam/the-good-things"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/rivertam/the-good-things'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/rivertam/the-good-things" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rivertam/the-good-things"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rivertam/the-good-things'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 7b21c02ec59f375e035fe449733d58dd1fb7ba09
[INFO] sha for GitHub repo rivertam/the-good-things: 7b21c02ec59f375e035fe449733d58dd1fb7ba09
[INFO] validating manifest of rivertam/the-good-things on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of rivertam/the-good-things on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing rivertam/the-good-things
[INFO] finished frobbing rivertam/the-good-things
[INFO] frobbed toml for rivertam/the-good-things written to work/ex/clippy-test-run/sources/stable/gh/rivertam/the-good-things/Cargo.toml
[INFO] started frobbing rivertam/the-good-things
[INFO] finished frobbing rivertam/the-good-things
[INFO] frobbed toml for rivertam/the-good-things written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rivertam/the-good-things/Cargo.toml
[INFO] crate rivertam/the-good-things has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting rivertam/the-good-things against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/rivertam/the-good-things:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cb174501fd9f3fcb15892a6dfeb14cd7491b121438c9a4d8d0666667d132fde9
[INFO] running `"docker" "start" "-a" "cb174501fd9f3fcb15892a6dfeb14cd7491b121438c9a4d8d0666667d132fde9"`
[INFO] [stderr]     Checking the-good-things v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return Ok(vec);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     std::env::home_dir()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 |         return Ok(vec);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/main.rs:50:5
[INFO] [stderr]    |
[INFO] [stderr] 50 |     std::env::home_dir()
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/main.rs:5:24
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn too_similar(thing1: &String, thing2: &String) -> bool {
[INFO] [stderr]   |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/main.rs:5:41
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn too_similar(thing1: &String, thing2: &String) -> bool {
[INFO] [stderr]   |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:18:32
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn get_good_thing(good_things: &std::vec::Vec<String>) -> String {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:52:10
[INFO] [stderr]    |
[INFO] [stderr] 52 |         .unwrap_or("/usr/share/the-good-things".to_string())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "/usr/share/the-good-things".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/main.rs:5:24
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn too_similar(thing1: &String, thing2: &String) -> bool {
[INFO] [stderr]   |                        ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/main.rs:5:41
[INFO] [stderr]   |
[INFO] [stderr] 5 | fn too_similar(thing1: &String, thing2: &String) -> bool {
[INFO] [stderr]   |                                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:18:32
[INFO] [stderr]    |
[INFO] [stderr] 18 | fn get_good_thing(good_things: &std::vec::Vec<String>) -> String {
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[String]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/main.rs:52:10
[INFO] [stderr]    |
[INFO] [stderr] 52 |         .unwrap_or("/usr/share/the-good-things".to_string())
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "/usr/share/the-good-things".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.65s
[INFO] running `"docker" "inspect" "cb174501fd9f3fcb15892a6dfeb14cd7491b121438c9a4d8d0666667d132fde9"`
[INFO] running `"docker" "rm" "-f" "cb174501fd9f3fcb15892a6dfeb14cd7491b121438c9a4d8d0666667d132fde9"`
[INFO] [stdout] cb174501fd9f3fcb15892a6dfeb14cd7491b121438c9a4d8d0666667d132fde9