[INFO] updating cached repository richardjennings/rust_3 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/richardjennings/rust_3 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/richardjennings/rust_3" "work/ex/clippy-test-run/sources/stable/gh/richardjennings/rust_3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/richardjennings/rust_3'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/richardjennings/rust_3" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardjennings/rust_3"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardjennings/rust_3'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c63311a69dda87ca0356bfe213ff01cf6424c80b [INFO] sha for GitHub repo richardjennings/rust_3: c63311a69dda87ca0356bfe213ff01cf6424c80b [INFO] validating manifest of richardjennings/rust_3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of richardjennings/rust_3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing richardjennings/rust_3 [INFO] finished frobbing richardjennings/rust_3 [INFO] frobbed toml for richardjennings/rust_3 written to work/ex/clippy-test-run/sources/stable/gh/richardjennings/rust_3/Cargo.toml [INFO] started frobbing richardjennings/rust_3 [INFO] finished frobbing richardjennings/rust_3 [INFO] frobbed toml for richardjennings/rust_3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardjennings/rust_3/Cargo.toml [INFO] crate richardjennings/rust_3 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting richardjennings/rust_3 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/richardjennings/rust_3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 15ac500e9027b9d6437ed20e178e5d17d3027b85710263c5f051e0adbf9618a4 [INFO] running `"docker" "start" "-a" "15ac500e9027b9d6437ed20e178e5d17d3027b85710263c5f051e0adbf9618a4"` [INFO] [stderr] Checking rust_3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | let c = 'z'; //char is a 'Unicode scalar value', [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let z = 'ℤ'; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | let a = [1u32, 2, 3, 4, 5]; //also specifies type u32 for all elements [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | let c = 'z'; //char is a 'Unicode scalar value', [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | let z = 'ℤ'; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | let a = [1u32, 2, 3, 4, 5]; //also specifies type u32 for all elements [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | nth [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:274:15 [INFO] [stderr] | [INFO] [stderr] 274 | let nth = match n { [INFO] [stderr] | _______________^ [INFO] [stderr] 275 | | 0 => { 0 } [INFO] [stderr] 276 | | 1 => { 1 } [INFO] [stderr] 277 | | _ => { [INFO] [stderr] ... | [INFO] [stderr] 283 | | } [INFO] [stderr] 284 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:285:5 [INFO] [stderr] | [INFO] [stderr] 285 | nth [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:274:15 [INFO] [stderr] | [INFO] [stderr] 274 | let nth = match n { [INFO] [stderr] | _______________^ [INFO] [stderr] 275 | | 0 => { 0 } [INFO] [stderr] 276 | | 1 => { 1 } [INFO] [stderr] 277 | | _ => { [INFO] [stderr] ... | [INFO] [stderr] 283 | | } [INFO] [stderr] 284 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / loop { // indefinite [INFO] [stderr] 211 | | println!("again!"); [INFO] [stderr] 212 | | break; // end [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | number = number - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number -= 1` [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / loop { // indefinite [INFO] [stderr] 211 | | println!("again!"); [INFO] [stderr] 212 | | break; // end [INFO] [stderr] 213 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | number = number - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `number -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | index = index + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust_3`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `rust_3`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "15ac500e9027b9d6437ed20e178e5d17d3027b85710263c5f051e0adbf9618a4"` [INFO] running `"docker" "rm" "-f" "15ac500e9027b9d6437ed20e178e5d17d3027b85710263c5f051e0adbf9618a4"` [INFO] [stdout] 15ac500e9027b9d6437ed20e178e5d17d3027b85710263c5f051e0adbf9618a4