[INFO] updating cached repository renatoathaydes/rust-scraper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/renatoathaydes/rust-scraper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/renatoathaydes/rust-scraper" "work/ex/clippy-test-run/sources/stable/gh/renatoathaydes/rust-scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/renatoathaydes/rust-scraper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/renatoathaydes/rust-scraper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/renatoathaydes/rust-scraper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/renatoathaydes/rust-scraper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 21de9d2b87cc888ddf508af06fa4b06b98a48cd2 [INFO] sha for GitHub repo renatoathaydes/rust-scraper: 21de9d2b87cc888ddf508af06fa4b06b98a48cd2 [INFO] validating manifest of renatoathaydes/rust-scraper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of renatoathaydes/rust-scraper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing renatoathaydes/rust-scraper [INFO] finished frobbing renatoathaydes/rust-scraper [INFO] frobbed toml for renatoathaydes/rust-scraper written to work/ex/clippy-test-run/sources/stable/gh/renatoathaydes/rust-scraper/Cargo.toml [INFO] started frobbing renatoathaydes/rust-scraper [INFO] finished frobbing renatoathaydes/rust-scraper [INFO] frobbed toml for renatoathaydes/rust-scraper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/renatoathaydes/rust-scraper/Cargo.toml [INFO] crate renatoathaydes/rust-scraper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting renatoathaydes/rust-scraper against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/renatoathaydes/rust-scraper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f864b08279926d125810f57544767877a3b3ba25bb074c8bf2da35f4be2802ff [INFO] running `"docker" "start" "-a" "f864b08279926d125810f57544767877a3b3ba25bb074c8bf2da35f4be2802ff"` [INFO] [stderr] Checking rust-scraper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | let parts: Vec<&str> = line.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | let parts: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | let slash_index = url_minus_protocol.find("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:120:22 [INFO] [stderr] | [INFO] [stderr] 120 | if host.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:121:47 [INFO] [stderr] | [INFO] [stderr] 121 | let parts: Vec<&str> = host.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:59:47 [INFO] [stderr] | [INFO] [stderr] 59 | let parts: Vec<&str> = line.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:83:39 [INFO] [stderr] | [INFO] [stderr] 83 | let parts: Vec<&str> = line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:100:51 [INFO] [stderr] | [INFO] [stderr] 100 | let slash_index = url_minus_protocol.find("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:120:22 [INFO] [stderr] | [INFO] [stderr] 120 | if host.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:121:47 [INFO] [stderr] | [INFO] [stderr] 121 | let parts: Vec<&str> = host.splitn(2, ":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.31s [INFO] running `"docker" "inspect" "f864b08279926d125810f57544767877a3b3ba25bb074c8bf2da35f4be2802ff"` [INFO] running `"docker" "rm" "-f" "f864b08279926d125810f57544767877a3b3ba25bb074c8bf2da35f4be2802ff"` [INFO] [stdout] f864b08279926d125810f57544767877a3b3ba25bb074c8bf2da35f4be2802ff